Skip to content
This repository has been archived by the owner on Jun 12, 2024. It is now read-only.

[Assembly v1] ProductMenu #503

Merged
merged 1 commit into from
Sep 16, 2021
Merged

[Assembly v1] ProductMenu #503

merged 1 commit into from
Sep 16, 2021

Conversation

katydecorah
Copy link
Contributor

@katydecorah katydecorah commented Sep 16, 2021 •
edited
Loading

This branch updates ProductMenu to Assembly v1 (and does some clean up 💆)

QA checklist

  • No errors logged to console.
  • Accessibility score in Chrome DevTools Audit/Lighthouse is 100% with Lighthouse version: #.#.#.
  • Component is accessible at mobile-size viewport.
  • Component is accessible at tablet-size viewport.
  • Component is accessible at laptop-size viewport.
  • Component is accessible at big-monitor-size viewport.

Open the test cases app locally on:

  • Chrome, no errors logged to console.
  • Firefox, no errors logged to console.
  • Safari, no errors logged to console.
  • Edge, no errors logged to console.
  • Mobile Safari, no errors logged to console.
  • Android Chrome, no errors logged to console.

Before merge

  • Add entry to CHANGELOG.md to describe changes.
  • If updating dependencies or creating a release, run npx browserslist@latest --update-db to update the browser data and commit any changes to package-lock.json.

katydecorah
katydecorah commented Sep 16, 2021
View reviewed changes
src/components/product-menu/product-menu.js
'color-white color-gray-light-on-hover': props.lightText,
'color-blue-on-hover': !props.lightText
'color-white color-gray-light-on-hover': lightText,
'color-blue-on-hover color-text': !lightText
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm interested in trying out color-text here! I think we can look back at this when we work on PageLayout to see if this is an improvement or distraction. This the only real change to this component (as shown in the updated snapshots), everything else is clean up.

@katydecorah katydecorah marked this pull request as ready for review September 16, 2021 15:59
malwoodsantoro
malwoodsantoro approved these changes Sep 16, 2021
View reviewed changes
Copy link
Contributor

@malwoodsantoro malwoodsantoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨

@katydecorah katydecorah merged commit 5ddfa47 into assembly-v1-update Sep 16, 2021
@katydecorah katydecorah deleted the assembly-v1-product-menu branch September 16, 2021 23:23
malwoodsantoro added a commit that referenced this pull request Oct 11, 2021
@malwoodsantoro
Upgrade to Assembly v1 🌝 (#481)
e75a178 
* update to Node 14

* add requirements section to readme.md

* update assembly and mr-ui

* remove font-size from docs-prose.css

* remove classes with position: sticky

* spacing fix

* replace limiter class

* replace limiter--wide class

* remove unused txt-spacing0 class

* update limiter--wide class

* remove fr-ui--feedback color-gray from docs-prose.css

* remove color-gray code class

* scroll-auto → overflow-auto

* remove double selectors

* add back heading prose selectors

* add mr-ui back as peerdependency

* update snapshots

* update package lock

* Update package-lock.json

* Update CHANGELOG.md

* LevelIndicator (#482)

* Update Assembly v1, remove unneeded classes

* Remove unused align-middle class

* Prevent level squares from shrinking

* [Assembly v1] Browser (#483)

* make w70 inline

* update snapshots

* updae package-lock.json

* update package-lock.json with assembly-v1-update branch

* Update src/components/browser/browser.js

Co-authored-by: Katy DeCorah <decorah@mapbox.com>

* update browser snapshot

Co-authored-by: Katy DeCorah <decorah@mapbox.com>

* [Assembly v1] BackToTopButton (#486)

* [Assembly v1] Themes, Note, Tag (#487)

* [Assembly v1] Themes, Note, Tag

* Update CHANGELOG.md

* [Assembly v1] Card (#489)

* [Assembly v1] Card

* Update snapshots

* [Assembly v1] Phone (#488)

* [Assembly v1] Phone

* Fix border-radius on iOS/Safari by adding overflow-hidden and z-index

* Update background

* [Assembly v1] CardContainer (#493)

* [Assembly v1] CardContainer

* Update CHANGELOG.md

* [Assembly v1] Feedback (#496)

* codemod changes

* update snapshots

* Update src/components/feedback/feedback.js

Co-authored-by: Katy DeCorah <decorah@mapbox.com>

* update snapshots

Co-authored-by: Katy DeCorah <decorah@mapbox.com>

* [Assembly v1] CodeSnippetTitle (#491)

* codemod changes

* update snapshots

* update snapshots from assembly-v1-update

* update snapshots

* fix stacking behavior on small screens

* update snapshots

* [Assembly v1] OverviewHeader (#501)

* [Assembly v1] OverviewHeader

* Reduce changes

* Reduce changes

* Reduce changes

* Reduce changes

* [Assembly v1] OnThisPage (#497)

* codemod changes

* update snapshot

* [Assembly v1] NavigationAccordion (#499)

* [Assembly v1] ProductMenu (#503)

* [Assembly v1] Update mr-ui@1.1.0 (#502)

* [Assembly v1] Update mr-ui

* Update CHANGELOG.md

* Update package-lock.json

* [Assembly v1] Search (#500)

* [Assembly v1] Search

* Clean up

* [Assembly v1] NumberedCodeSnippet (#504)

* codemod changes

* increase line number contrast

* increase contrast of hide code text

* update snapshots

* Update src/components/numbered-code-snippet/show-hide-lines.js

Co-authored-by: Katy DeCorah <decorah@mapbox.com>

* update snapshots

Co-authored-by: Katy DeCorah <decorah@mapbox.com>

* [Assembly v1] RelatedPage (#507)

* codemod changes

* update snapshots

* remove a11y colors

* update snapshots

* [Assembly v1] PageLayout (#510)

* [Assembly v1] PageLayout

* Make `color-text` cascade from PageLayout instead

* Reduce changes

* Add stroke to select, make size match input--s

* Remove `color-text` from NavigationAccordion (allow the color to cascade from PageLayout)

* [Assembly v1] Video (#511)

* codemod changes

* update snapshots

* [Assembly v1] Update catalog site (#512)

* codemode changes

* fix required badge contrast

* darken links in overview header

* remove overview header docs prose css

* change header background color and text color

* Fix package-lock.json

* 5.0.0-beta.0

* Update class in make-table-scroll plugin (#520)

* Update dependencies

* 5.0.0-beta.1

* mbx-assembly@1.2.0

* [Assembly v1] Update default theme to use `color-text` (#522)

* Fix border color and set icon color for `lightText` (#521)

* [Assembly v1] h2 fix (#523)

* Add back `padding-top: 30px;`

* Create "Test pages" group on catalog site

* 5.0.0-beta.2

* [Assembly v1] Replace viewport and scroll classes in PageLayout (#524)

* Fix deprecated viewport classes

* Fix overflow- class

* 5.0.0-beta.3

Co-authored-by: Katy DeCorah <decorah@mapbox.com>
katydecorah pushed a commit that referenced this pull request Oct 25, 2021
@malwoodsantoro
Upgrade to Assembly v1 🌝 (#481)
e13030c 
* update to Node 14

* add requirements section to readme.md

* update assembly and mr-ui

* remove font-size from docs-prose.css

* remove classes with position: sticky

* spacing fix

* replace limiter class

* replace limiter--wide class

* remove unused txt-spacing0 class

* update limiter--wide class

* remove fr-ui--feedback color-gray from docs-prose.css

* remove color-gray code class

* scroll-auto → overflow-auto

* remove double selectors

* add back heading prose selectors

* add mr-ui back as peerdependency

* update snapshots

* update package lock

* Update package-lock.json

* Update CHANGELOG.md

* LevelIndicator (#482)

* Update Assembly v1, remove unneeded classes

* Remove unused align-middle class

* Prevent level squares from shrinking

* [Assembly v1] Browser (#483)

* make w70 inline

* update snapshots

* updae package-lock.json

* update package-lock.json with assembly-v1-update branch

* Update src/components/browser/browser.js

Co-authored-by: Katy DeCorah <decorah@mapbox.com>

* update browser snapshot

Co-authored-by: Katy DeCorah <decorah@mapbox.com>

* [Assembly v1] BackToTopButton (#486)

* [Assembly v1] Themes, Note, Tag (#487)

* [Assembly v1] Themes, Note, Tag

* Update CHANGELOG.md

* [Assembly v1] Card (#489)

* [Assembly v1] Card

* Update snapshots

* [Assembly v1] Phone (#488)

* [Assembly v1] Phone

* Fix border-radius on iOS/Safari by adding overflow-hidden and z-index

* Update background

* [Assembly v1] CardContainer (#493)

* [Assembly v1] CardContainer

* Update CHANGELOG.md

* [Assembly v1] Feedback (#496)

* codemod changes

* update snapshots

* Update src/components/feedback/feedback.js

Co-authored-by: Katy DeCorah <decorah@mapbox.com>

* update snapshots

Co-authored-by: Katy DeCorah <decorah@mapbox.com>

* [Assembly v1] CodeSnippetTitle (#491)

* codemod changes

* update snapshots

* update snapshots from assembly-v1-update

* update snapshots

* fix stacking behavior on small screens

* update snapshots

* [Assembly v1] OverviewHeader (#501)

* [Assembly v1] OverviewHeader

* Reduce changes

* Reduce changes

* Reduce changes

* Reduce changes

* [Assembly v1] OnThisPage (#497)

* codemod changes

* update snapshot

* [Assembly v1] NavigationAccordion (#499)

* [Assembly v1] ProductMenu (#503)

* [Assembly v1] Update mr-ui@1.1.0 (#502)

* [Assembly v1] Update mr-ui

* Update CHANGELOG.md

* Update package-lock.json

* [Assembly v1] Search (#500)

* [Assembly v1] Search

* Clean up

* [Assembly v1] NumberedCodeSnippet (#504)

* codemod changes

* increase line number contrast

* increase contrast of hide code text

* update snapshots

* Update src/components/numbered-code-snippet/show-hide-lines.js

Co-authored-by: Katy DeCorah <decorah@mapbox.com>

* update snapshots

Co-authored-by: Katy DeCorah <decorah@mapbox.com>

* [Assembly v1] RelatedPage (#507)

* codemod changes

* update snapshots

* remove a11y colors

* update snapshots

* [Assembly v1] PageLayout (#510)

* [Assembly v1] PageLayout

* Make `color-text` cascade from PageLayout instead

* Reduce changes

* Add stroke to select, make size match input--s

* Remove `color-text` from NavigationAccordion (allow the color to cascade from PageLayout)

* [Assembly v1] Video (#511)

* codemod changes

* update snapshots

* [Assembly v1] Update catalog site (#512)

* codemode changes

* fix required badge contrast

* darken links in overview header

* remove overview header docs prose css

* change header background color and text color

* Fix package-lock.json

* 5.0.0-beta.0

* Update class in make-table-scroll plugin (#520)

* Update dependencies

* 5.0.0-beta.1

* mbx-assembly@1.2.0

* [Assembly v1] Update default theme to use `color-text` (#522)

* Fix border color and set icon color for `lightText` (#521)

* [Assembly v1] h2 fix (#523)

* Add back `padding-top: 30px;`

* Create "Test pages" group on catalog site

* 5.0.0-beta.2

* [Assembly v1] Replace viewport and scroll classes in PageLayout (#524)

* Fix deprecated viewport classes

* Fix overflow- class

* 5.0.0-beta.3

Co-authored-by: Katy DeCorah <decorah@mapbox.com>
katydecorah pushed a commit that referenced this pull request Oct 25, 2021
@malwoodsantoro
Adjust spacing and size of subPages in GroupedGuides (#526)
1df1605 
* Adjust spacing and size of subPages in GroupedGuides

* Reduce changes

* Upgrade to Assembly v1 🌝 (#481)

* update to Node 14

* add requirements section to readme.md

* update assembly and mr-ui

* remove font-size from docs-prose.css

* remove classes with position: sticky

* spacing fix

* replace limiter class

* replace limiter--wide class

* remove unused txt-spacing0 class

* update limiter--wide class

* remove fr-ui--feedback color-gray from docs-prose.css

* remove color-gray code class

* scroll-auto → overflow-auto

* remove double selectors

* add back heading prose selectors

* add mr-ui back as peerdependency

* update snapshots

* update package lock

* Update package-lock.json

* Update CHANGELOG.md

* LevelIndicator (#482)

* Update Assembly v1, remove unneeded classes

* Remove unused align-middle class

* Prevent level squares from shrinking

* [Assembly v1] Browser (#483)

* make w70 inline

* update snapshots

* updae package-lock.json

* update package-lock.json with assembly-v1-update branch

* Update src/components/browser/browser.js

Co-authored-by: Katy DeCorah <decorah@mapbox.com>

* update browser snapshot

Co-authored-by: Katy DeCorah <decorah@mapbox.com>

* [Assembly v1] BackToTopButton (#486)

* [Assembly v1] Themes, Note, Tag (#487)

* [Assembly v1] Themes, Note, Tag

* Update CHANGELOG.md

* [Assembly v1] Card (#489)

* [Assembly v1] Card

* Update snapshots

* [Assembly v1] Phone (#488)

* [Assembly v1] Phone

* Fix border-radius on iOS/Safari by adding overflow-hidden and z-index

* Update background

* [Assembly v1] CardContainer (#493)

* [Assembly v1] CardContainer

* Update CHANGELOG.md

* [Assembly v1] Feedback (#496)

* codemod changes

* update snapshots

* Update src/components/feedback/feedback.js

Co-authored-by: Katy DeCorah <decorah@mapbox.com>

* update snapshots

Co-authored-by: Katy DeCorah <decorah@mapbox.com>

* [Assembly v1] CodeSnippetTitle (#491)

* codemod changes

* update snapshots

* update snapshots from assembly-v1-update

* update snapshots

* fix stacking behavior on small screens

* update snapshots

* [Assembly v1] OverviewHeader (#501)

* [Assembly v1] OverviewHeader

* Reduce changes

* Reduce changes

* Reduce changes

* Reduce changes

* [Assembly v1] OnThisPage (#497)

* codemod changes

* update snapshot

* [Assembly v1] NavigationAccordion (#499)

* [Assembly v1] ProductMenu (#503)

* [Assembly v1] Update mr-ui@1.1.0 (#502)

* [Assembly v1] Update mr-ui

* Update CHANGELOG.md

* Update package-lock.json

* [Assembly v1] Search (#500)

* [Assembly v1] Search

* Clean up

* [Assembly v1] NumberedCodeSnippet (#504)

* codemod changes

* increase line number contrast

* increase contrast of hide code text

* update snapshots

* Update src/components/numbered-code-snippet/show-hide-lines.js

Co-authored-by: Katy DeCorah <decorah@mapbox.com>

* update snapshots

Co-authored-by: Katy DeCorah <decorah@mapbox.com>

* [Assembly v1] RelatedPage (#507)

* codemod changes

* update snapshots

* remove a11y colors

* update snapshots

* [Assembly v1] PageLayout (#510)

* [Assembly v1] PageLayout

* Make `color-text` cascade from PageLayout instead

* Reduce changes

* Add stroke to select, make size match input--s

* Remove `color-text` from NavigationAccordion (allow the color to cascade from PageLayout)

* [Assembly v1] Video (#511)

* codemod changes

* update snapshots

* [Assembly v1] Update catalog site (#512)

* codemode changes

* fix required badge contrast

* darken links in overview header

* remove overview header docs prose css

* change header background color and text color

* Fix package-lock.json

* 5.0.0-beta.0

* Update class in make-table-scroll plugin (#520)

* Update dependencies

* 5.0.0-beta.1

* mbx-assembly@1.2.0

* [Assembly v1] Update default theme to use `color-text` (#522)

* Fix border color and set icon color for `lightText` (#521)

* [Assembly v1] h2 fix (#523)

* Add back `padding-top: 30px;`

* Create "Test pages" group on catalog site

* 5.0.0-beta.2

* [Assembly v1] Replace viewport and scroll classes in PageLayout (#524)

* Fix deprecated viewport classes

* Fix overflow- class

* 5.0.0-beta.3

Co-authored-by: Katy DeCorah <decorah@mapbox.com>

* Update package-lock.json

* Update package-lock.json

* Update CHANGELOG.md

Co-authored-by: Mal Wood-Santoro <mal.wood@mapbox.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@malwoodsantoro malwoodsantoro malwoodsantoro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@katydecorah @malwoodsantoro