This repository has been archived by the owner on Jun 12, 2024. It is now read-only.
a catalog site #137
Merged
a catalog site #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 14 commits
May 31, 2019 17:00
|
In testing the deploy script, the catalog site is now live at: https://mapbox.github.io/dr-ui/ After working with adding examples and testing out the components, there are a few things that I think should be fixed in separate PRs:
|
added 2 commits
June 4, 2019 08:38
added 11 commits
June 4, 2019 08:49
* master: 0.16.2 Prepare 0.16.2 0.16.1 Prepare 0.16.1 0.16.0 Prepare 0.16.0 [search] update search-ui, add loader, increase debounce length (#145) 0.15.2 Prepare 0.15.2 🐛do not package optionalDependencies and jest (#143) add snapshot tests (#136) 0.15.1 Prepare 0.15.1 0.15.0 Prepare 0.15.0 [search] adds segment tracking for queries and clicks (#140)
* master: Create create-redirect.js (#144) 0.18.2 [search] fix missing proptype (#151) 0.18.1 Update security vulnerabilities in dependencies (#152) 0.18.0 Feedback component (#135) 0.17.0 Prepare 0.17.0 [version-sort] do not push pre-releases of the latest stable version (#148) 🐛make compare-versions a dependency (#142) [PageLayout] add data attribute to prevent Swiftype from indexing sidebar content (#146)
* master: 0.19.0 Prepare 0.19.0 [search] update to v1.0.0 of search-ui (#156)
|
This is ready for review. The current version is deployed at https://mapbox.github.io/dr-ui/ Overview of changes
There should be no changes to the components themselves in this PR. In most cases I used a component's first (basic) test case as the catalog example. I did make some slight changes to a few examples and test cases to make them more palatable for the catalog. |
added 2 commits
June 11, 2020 16:06
danswick
approved these changes
Jun 19, 2020
There was a problem hiding this comment.
🎣 WOO this one's a keeper!
I built the catalog site, ran tests, and reviewed all of the code changes in here. Everything looks great to me. The new /examples organization is really sensible to me and helps make it more obvious what's going on in the test cases. The site looks good and is easy to navigate. The new.js functionality seems useful and the CI changes to require a successful build are a good idea!
added 4 commits
June 25, 2020 08:56
katydecorah
added a commit
that referenced
this pull request
Jul 8, 2020
* main: Add the catalog site (#137) Delete dependabot.yml
katydecorah
pushed a commit
that referenced
this pull request
Jul 8, 2020
katydecorah
pushed a commit
that referenced
this pull request
Jul 8, 2020
katydecorah
pushed a commit
that referenced
this pull request
Jul 8, 2020
katydecorah
pushed a commit
that referenced
this pull request
Jul 8, 2020
* update sentry; set peerDependency * Update CHANGELOG.md * pin the peer dependency version * add test to make sure peerDep matches dep * Update react, react-dom, prop-types, react-test-renderer; Make react and react-dom peerDeps * add mr-ui and mbx-assembly as peerDeps * Update CHANGELOG.md * Update peer-deps.test.js * Merge branch 'main' into peer-deps * main: Remove unused highlight.js and util function (#305) Add aria-label to BackToTopButton (#290) Add the catalog site (#137) Delete dependabot.yml Only direct dependencies Create dependabot.yml (#296) Update Travis bad * Merge branch 'main' into peer-deps * main: Remove unused highlight.js and util function (#305) Add aria-label to BackToTopButton (#290) Add the catalog site (#137) Delete dependabot.yml Only direct dependencies Create dependabot.yml (#296) Update Travis bad * Update sentry * Update package-lock.json
katydecorah
pushed a commit
that referenced
this pull request
Jul 10, 2020
* main: (27 commits) Add Changelog to catalog site 0.29.2 Prepare 0.29.2 Update devDependencies, create jest-setup.js (#311) Set peerDependencies to keep frontend libraries in sync (#292) Remove unused highlight.js and util function (#305) Add aria-label to BackToTopButton (#290) Add the catalog site (#137) Delete dependabot.yml Only direct dependencies Create dependabot.yml (#296) Update Travis bad Update devDependencies (#294) 0.29.1 Update CHANGELOG.md Remove `limiter` from Topbar (#282) 0.29.0 Prepare 0.29.0 Allow Kotlin-only activities (#278) 0.28.0 ...
katydecorah
pushed a commit
that referenced
this pull request
Apr 22, 2021
…toplay (#276) * show video controls on hover; show play button for browsers with disabled autoplay * Merge branch 'main' into video-controls * main: Add the catalog site (#137) Delete dependabot.yml Only direct dependencies Create dependabot.yml (#296) Update Travis bad Update devDependencies (#294) * Add example * More comments * Reduce changes * eslint and fix button styles * Clean up button * Set playsInline to true if autoPlay is true; make `muted` a prop * Update test cases description to indicate the autoplay state * Update description * Update snapshots * Update CHANGELOG.md * Create `playsInline` prop * Append hash to src to enable preview on iOS * Update video.js * Adds optional `poster` prop * Remove hack * Add poster example * Fix paths * Update descriptions * Apply suggestions from code review
katydecorah
pushed a commit
that referenced
this pull request
May 11, 2021
* Prepare 4.0.0 changelog * Make code toggles in test cases interactive or label if they are not (#432) * Update dependencies (#433) * Update dependencies * Update package-lock.json * Update rehype-slug * Fix links * Update page-layout.md * Update snapshots * Replace stateless components with pure components (#414) * Use PureComponent on stateless components * Update package-lock.json * 4.0.0-alpha.0 * Use PureComponents where components do not require rerenders * 4.0.0-alpha.1 * prefer-const * Update CHANGELOG.md * Make more components pure * 4.0.0-alpha.2 * 4.0.0-alpha.3 * Improve color contrast on code and anchor elements (#434) * Expand a code color contrast improvement * Increase color contrast on .color-gray code * Increase color contrast for prism's .token.regex,.token.important * Clean up test cases * Update CHANGELOG.md * Clean up test cases * Clean up test cases * Update docs/src/pages/guides/a11y.md Co-authored-by: Colleen McGinnis <colleen.mcginnis@mapbox.com> * Reduce changes Co-authored-by: Colleen McGinnis <colleen.mcginnis@mapbox.com> * 🔧 Run prettier * Add eslint-plugin-jsx-a11y (#435) * Add eslint-plugin-jsx-a11y * Fix props * Update CHANGELOG.md * Update search.test.js.snap * Update eslint * Update eslint * Create `prepareSitemap` Batfish helper to improve sitemap (#427) * Create prepareSitemap Batfish helper * Update CHANGELOG.md * Clean up, add `docsPath`, and `outputDirectory` * Exclude `splitPage` from sitemap * Assert sitemap * Extract urls * Sort sitemap * Remove snapshot * Update sitemap.test.js * Update batfish-helpers.md * Update batfish-helpers.md * Copyedit * Update package-lock.json * Replace `id` with `aria-label` in VimeoPlayImage (#438) * Replace `id` with aria-label to prevent duplicated id * Update CHANGELOG.md * Make `filename` optional for `CodeSnippetTitle` * Make "With token" `DemoIframe` a no render test case (#440) * Make "With token" `DemoIframe` a no render test case * Rename * Use passive event listeners on `Search`, `NumberedCodeSnippet`, and `OnThisPage` to improve performance (#437) * Use passive event listeners on `Search`, `NumberedCodeSnippet`, and `OnThisPage` to improve performance. * Update CHANGELOG.md * Reconfigure `Video` options to optimize for user's settings around autoplay (#276) * show video controls on hover; show play button for browsers with disabled autoplay * Merge branch 'main' into video-controls * main: Add the catalog site (#137) Delete dependabot.yml Only direct dependencies Create dependabot.yml (#296) Update Travis bad Update devDependencies (#294) * Add example * More comments * Reduce changes * eslint and fix button styles * Clean up button * Set playsInline to true if autoPlay is true; make `muted` a prop * Update test cases description to indicate the autoplay state * Update description * Update snapshots * Update CHANGELOG.md * Create `playsInline` prop * Append hash to src to enable preview on iOS * Update video.js * Adds optional `poster` prop * Remove hack * Add poster example * Fix paths * Update descriptions * Apply suggestions from code review * Load Search with a facade (#430) * Load Search with a facade * Add @loadable/babel-plugin * Update CHANGELOG.md * Fix logic * Update search.test.js.snap * Define development babel env to prevent `@loadable/babel-plugin` from loading on start (because it fails) * Adjusting snapshots * Revert "Adjusting snapshots" This reverts commit d2e7fd9. * Clean up props * Comments * Reduce changes * Reduce changes * Reduce changes * Reduce changes * Clean up props * Use SearchInput in SearchBox * Use SearchButton in SearchBox * Reduce changes * Add missing props * Consolidate wrapper * 4.0.0-alpha.4 * Try dynamic import * Update package-lock.json * 4.0.0-alpha.5 * Update package-lock.json * Reduce changes * Reorganize files * 4.0.0-alpha.6 * Switch to noRenderCase * Reduce changes * Add passive event listener * Allow autofocus * Enable react/jsx-no-bind (#442) * jsx-no-bind * Update CHANGELOG.md * Simplify, reduce changes * The `NumberedCodeSnippet` prop `onCopy` is deprecated and will automatically send a track event to Segment * Remove unused onCopy * Simplify * Add onCopy * Create onCopy function * Update src/components/code-snippet/on-copy.js * Update dependencies * Update caniuse * Update devDependencies * Update CHANGELOG.md * Fix NavigationAccordion tests (#443) * 4.0.0-alpha.7 * Fix prepareSitemap: append index.html to files ending in index.js (#444) * 4.0.0-alpha.8 * Update batfish * Update caniuse-lite * Fix props on search toggle (#448) * Fix props on search toggle * 4.0.0-alpha.9 * For searches with no results, retry if Swiftype thinks there is a spelling error (#451) * pass through swiftype API spelling option * move prettier'd comment * Update search-ui, downshift * Update caniuse-lite * Update @sentry/browser * Send search results with no queries to Sentry (#452) * Send search results with no queries to Sentry * Update CHANGELOG.md * Update prettier * Fix Sentry test * 4.0.0-alpha.10 * Switch Sentry environment back to `main` * Fix Search/Sentry, only send when results change * 4.0.0 * Clean up Co-authored-by: Colleen McGinnis <colleen.mcginnis@mapbox.com> Co-authored-by: Dan Swick <dan.swick@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Borrowing from our very good friend mr-ui
To do:
fixes #23