This repository has been archived by the owner on Jun 12, 2024. It is now read-only.
Remove limiter from Topbar
#282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 2, 2020 09:40
katydecorah
pushed a commit
that referenced
this pull request
Jun 9, 2020
* master: (50 commits) 0.29.1 Update CHANGELOG.md Remove `limiter` from Topbar (#282) 0.29.0 Prepare 0.29.0 Allow Kotlin-only activities (#278) 0.28.0 Prepare 0.28.0 Prevent `ProductMenu` from truncating `tag` (#277) Update mr-ui and npm audit (#266) Add `Topbar` component (#274) Fix bug in NumberedCodeSnippet (#268) Update issue templates Fix padding and background on NumberedCodeSnippet (#269) Prepare 0.27.0 Update Sentry Send basic user metadata along with Feedback (#255) Set character limit for `Feedback` texteara (#244) Add tests to assert Segment event in Feedback component (#256) Add `icon` option for third level items in NavigationAccordion (#252) ...
katydecorah
pushed a commit
that referenced
this pull request
Jun 25, 2020
* master: 0.29.1 Update CHANGELOG.md Remove `limiter` from Topbar (#282) 0.29.0 Prepare 0.29.0 Allow Kotlin-only activities (#278) 0.28.0 Prepare 0.28.0 Prevent `ProductMenu` from truncating `tag` (#277) Update mr-ui and npm audit (#266) Add `Topbar` component (#274) Fix bug in NumberedCodeSnippet (#268) Update issue templates
katydecorah
pushed a commit
that referenced
this pull request
Jul 10, 2020
* main: (27 commits) Add Changelog to catalog site 0.29.2 Prepare 0.29.2 Update devDependencies, create jest-setup.js (#311) Set peerDependencies to keep frontend libraries in sync (#292) Remove unused highlight.js and util function (#305) Add aria-label to BackToTopButton (#290) Add the catalog site (#137) Delete dependabot.yml Only direct dependencies Create dependabot.yml (#296) Update Travis bad Update devDependencies (#294) 0.29.1 Update CHANGELOG.md Remove `limiter` from Topbar (#282) 0.29.0 Prepare 0.29.0 Allow Kotlin-only activities (#278) 0.28.0 ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #274, I added
<div className="limiter">to the newTopbarcomponent in an effort to reduce code in individual repos. I think this was an over eager misstep, as it would require us to make a manual update to every page-shell to remove the now duplicated<div className="limiter">.This PR reverts that change to prevent having to make lots of small updates in each repo.