[search] adds segment tracking for queries and clicks #140
Conversation
package.json
Outdated
| @@ -35,6 +35,7 @@ | |||
| "@mapbox/eslint-config-mapbox": "^1.2.1", | |||
| "@mapbox/mbx-assembly": "^0.28.2", | |||
| "@mapbox/react-test-kitchen": "^0.1.3", | |||
| "@mapbox/web-analytics": "^0.5.1", | |||
There was a problem hiding this comment.
Note: this is a private module. Including it makes it far easier to test segment events, but not easy for teammates who don't have access. I think we should leave for now for testing purposes, but can circle back if it becomes a blocker for others.
There was a problem hiding this comment.
Is this still an issue now that it's moved to optional dependencies?
There was a problem hiding this comment.
@colleenmcginnis now that it's an optional dependencies, I don't think non-aws users will have an issue installing this repo locally.
Also want to note that web-analytics is installed here for local testing only (so we can make sure events are getting tracked) - it won't get bundled in the dr-ui build.
There was a problem hiding this comment.
@katydecorah thanks for helping me debug the debugger! Looks good to me. 💐
* master: [search] add ability to filter results (#138)
* master: add snapshot tests (#136) 0.15.1 Prepare 0.15.1 0.15.0 Prepare 0.15.0 [search] adds segment tracking for queries and clicks (#140) [search] add ability to filter results (#138) increase modal zindex to prevent collision with topbar sticker (#139) 0.14.0 Prepare 0.14.0 [PageLayout/TopbarSticker] increase zIndex (#134) [search] Introduce search modal (#133) prepare 0.13.0 adjust version-sort for XX.XX.XX format (#132)
* master: 0.16.2 Prepare 0.16.2 0.16.1 Prepare 0.16.1 0.16.0 Prepare 0.16.0 [search] update search-ui, add loader, increase debounce length (#145) 0.15.2 Prepare 0.15.2 🐛do not package optionalDependencies and jest (#143) add snapshot tests (#136) 0.15.1 Prepare 0.15.1 0.15.0 Prepare 0.15.0 [search] adds segment tracking for queries and clicks (#140)
This PR adds tracking to our Search component for:
How to test:
When you click "Raw" you'll see the metadata attached with the event, including page searched from 🎉