Skip to content
This repository has been archived by the owner on Jun 12, 2024. It is now read-only.

Add eslint-plugin-jsx-a11y #435

Merged
merged 7 commits into from
Apr 14, 2021
Merged

Add eslint-plugin-jsx-a11y #435

merged 7 commits into from
Apr 14, 2021

Conversation

katydecorah
Copy link
Contributor

@katydecorah katydecorah commented Apr 12, 2021 •
edited
Loading

This branch merges into #431

This PR adds https://github.com/jsx-eslint/eslint-plugin-jsx-a11y and fixes accessibility issues.

How to test

Check that the following components function as expected in the test cases app:

  • NumberedCodeSnippet (hide/show buttons)
  • RelatedPage (link and video modal)

Before merge

  • Add entry to CHANGELOG.md to describe changes.

@katydecorah katydecorah marked this pull request as ready for review April 12, 2021 19:31
Katy DeCorah added 4 commits April 12, 2021 15:41
Update search.test.js.snap
f710852
Merge branch '4.0.0' into 4-jsx-a11y
430f8d4 
* 4.0.0:
  🔧 Run prettier
  Improve color contrast on code and anchor elements (#434)
  Replace stateless components with pure components (#414)
Update eslint
3b60d64
Update eslint
0e5e79f
@katydecorah katydecorah requested a review from a team April 13, 2021 15:38
@danswick danswick requested review from danswick and removed request for a team April 14, 2021 01:59
danswick
danswick approved these changes Apr 14, 2021
View reviewed changes
Copy link
Contributor

@danswick danswick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, @katydecorah. Tested locally as well and everything is humming along 🙌

src/components/related-page/related-page.js
@@ -109,11 +109,16 @@ class RelatedPage extends React.PureComponent {
wmin180: showVideoThumbnail
});

const Element = showVideoModal ? 'button' : 'a';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neat!

@katydecorah katydecorah merged commit a6b95c0 into 4.0.0 Apr 14, 2021
@katydecorah katydecorah deleted the 4-jsx-a11y branch April 14, 2021 13:29
katydecorah pushed a commit that referenced this pull request Apr 14, 2021
Merge branch '4.0.0' into jsx-no-bind
a28153d 
* 4.0.0:
  Create `prepareSitemap` Batfish helper to improve sitemap (#427)
  Add eslint-plugin-jsx-a11y (#435)
katydecorah pushed a commit that referenced this pull request Apr 14, 2021
Merge branch '4.0.0' into video-controls
ddf040e 
* 4.0.0:
  Create `prepareSitemap` Batfish helper to improve sitemap (#427)
  Add eslint-plugin-jsx-a11y (#435)
  🔧 Run prettier
  Improve color contrast on code and anchor elements (#434)
  Replace stateless components with pure components (#414)
  Update dependencies (#433)
  Make code toggles in test cases interactive or label if they are not (#432)
  Prepare 4.0.0 changelog
katydecorah pushed a commit that referenced this pull request Apr 16, 2021
Merge branch '4.0.0' into lh-ci
d98202b 
* 4.0.0:
  Make `filename` optional for `CodeSnippetTitle`
  Replace `id` with `aria-label` in VimeoPlayImage (#438)
  Create `prepareSitemap` Batfish helper to improve sitemap (#427)
  Add eslint-plugin-jsx-a11y (#435)
  🔧 Run prettier
  Improve color contrast on code and anchor elements (#434)
  Replace stateless components with pure components (#414)
  Update dependencies (#433)
  Make code toggles in test cases interactive or label if they are not (#432)
  Prepare 4.0.0 changelog
katydecorah pushed a commit that referenced this pull request Apr 22, 2021
Merge branch '4.0.0' into add-search-facade
687093a 
* 4.0.0:
  Use passive event listeners on `Search`, `NumberedCodeSnippet`, and `OnThisPage` to improve performance (#437)
  Make "With token" `DemoIframe` a no render test case (#440)
  Make `filename` optional for `CodeSnippetTitle`
  Replace `id` with `aria-label` in VimeoPlayImage (#438)
  Create `prepareSitemap` Batfish helper to improve sitemap (#427)
  Add eslint-plugin-jsx-a11y (#435)
katydecorah pushed a commit that referenced this pull request May 11, 2021
@danswick
⚡️ 4.0.0 (#431)
d35b4d6 
* Prepare 4.0.0 changelog

* Make code toggles in test cases interactive or label if they are not (#432)

* Update dependencies (#433)

* Update dependencies

* Update package-lock.json

* Update rehype-slug

* Fix links

* Update page-layout.md

* Update snapshots

* Replace stateless components with pure components (#414)

* Use PureComponent on stateless components

* Update package-lock.json

* 4.0.0-alpha.0

* Use PureComponents where components do not require rerenders

* 4.0.0-alpha.1

* prefer-const

* Update CHANGELOG.md

* Make more components pure

* 4.0.0-alpha.2

* 4.0.0-alpha.3

* Improve color contrast on code and anchor elements (#434)

* Expand a code color contrast improvement

* Increase color contrast on .color-gray code

* Increase color contrast for prism's .token.regex,.token.important

* Clean up test cases

* Update CHANGELOG.md

* Clean up test cases

* Clean up test cases

* Update docs/src/pages/guides/a11y.md

Co-authored-by: Colleen McGinnis <colleen.mcginnis@mapbox.com>

* Reduce changes

Co-authored-by: Colleen McGinnis <colleen.mcginnis@mapbox.com>

* 🔧 Run prettier

* Add eslint-plugin-jsx-a11y (#435)

* Add eslint-plugin-jsx-a11y

* Fix props

* Update CHANGELOG.md

* Update search.test.js.snap

* Update eslint

* Update eslint

* Create `prepareSitemap` Batfish helper to improve sitemap (#427)

* Create prepareSitemap Batfish helper

* Update CHANGELOG.md

* Clean up, add `docsPath`, and `outputDirectory`

* Exclude `splitPage` from sitemap

* Assert sitemap

* Extract urls

* Sort sitemap

* Remove snapshot

* Update sitemap.test.js

* Update batfish-helpers.md

* Update batfish-helpers.md

* Copyedit

* Update package-lock.json

* Replace `id` with `aria-label` in VimeoPlayImage (#438)

* Replace `id` with aria-label to prevent duplicated id

* Update CHANGELOG.md

* Make `filename` optional for `CodeSnippetTitle`

* Make "With token" `DemoIframe` a no render test case (#440)

* Make "With token" `DemoIframe` a no render test case

* Rename

* Use passive event listeners on `Search`, `NumberedCodeSnippet`, and `OnThisPage` to improve performance (#437)

* Use passive event listeners on `Search`, `NumberedCodeSnippet`, and `OnThisPage` to improve performance.

* Update CHANGELOG.md

* Reconfigure `Video` options to optimize for user's settings around autoplay (#276)

* show video controls on hover; show play button for browsers with disabled autoplay

* Merge branch 'main' into video-controls

* main:
  Add the catalog site  (#137)
  Delete dependabot.yml
  Only direct dependencies
  Create dependabot.yml (#296)
  Update Travis bad
  Update devDependencies (#294)

* Add example

* More comments

* Reduce changes

* eslint and fix button styles

* Clean up button

* Set playsInline to true if autoPlay is true; make `muted` a prop

* Update test cases description to indicate the autoplay state

* Update description

* Update snapshots

* Update CHANGELOG.md

* Create `playsInline` prop

* Append hash to src to enable preview on iOS

* Update video.js

* Adds optional `poster` prop

* Remove hack

* Add poster example

* Fix paths

* Update descriptions

* Apply suggestions from code review

* Load Search with a facade (#430)

* Load Search with a facade

* Add @loadable/babel-plugin

* Update CHANGELOG.md

* Fix logic

* Update search.test.js.snap

* Define development babel env to prevent `@loadable/babel-plugin` from loading on start (because it fails)

* Adjusting snapshots

* Revert "Adjusting snapshots"

This reverts commit d2e7fd9.

* Clean up props

* Comments

* Reduce changes

* Reduce changes

* Reduce changes

* Reduce changes

* Clean up props

* Use SearchInput in SearchBox

* Use SearchButton in SearchBox

* Reduce changes

* Add missing props

* Consolidate wrapper

* 4.0.0-alpha.4

* Try dynamic import

* Update package-lock.json

* 4.0.0-alpha.5

* Update package-lock.json

* Reduce changes

* Reorganize files

* 4.0.0-alpha.6

* Switch to noRenderCase

* Reduce changes

* Add passive event listener

* Allow autofocus

* Enable react/jsx-no-bind (#442)

* jsx-no-bind

* Update CHANGELOG.md

* Simplify, reduce changes

* The `NumberedCodeSnippet` prop `onCopy` is deprecated and will automatically send a track event to Segment

* Remove unused onCopy

* Simplify

* Add onCopy

* Create onCopy function

* Update src/components/code-snippet/on-copy.js

* Update dependencies

* Update caniuse

* Update devDependencies

* Update CHANGELOG.md

* Fix NavigationAccordion tests (#443)

* 4.0.0-alpha.7

* Fix prepareSitemap: append index.html to files ending in index.js (#444)

* 4.0.0-alpha.8

* Update batfish

* Update caniuse-lite

* Fix props on search toggle (#448)

* Fix props on search toggle

* 4.0.0-alpha.9

* For searches with no results, retry if Swiftype thinks there is a spelling error (#451)

* pass through swiftype API spelling option

* move prettier'd comment

* Update search-ui, downshift

* Update caniuse-lite

* Update @sentry/browser

* Send search results with no queries to Sentry (#452)

* Send search results with no queries to Sentry

* Update CHANGELOG.md

* Update prettier

* Fix Sentry test

* 4.0.0-alpha.10

* Switch Sentry environment back to `main`

* Fix Search/Sentry, only send when results change

* 4.0.0

* Clean up

Co-authored-by: Colleen McGinnis <colleen.mcginnis@mapbox.com>
Co-authored-by: Dan Swick <dan.swick@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@danswick danswick danswick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@katydecorah @danswick