Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What is current Playwright test coverage? #7051

Closed
yangwao opened this issue Aug 30, 2023 · 12 comments
Closed

What is current Playwright test coverage? #7051

yangwao opened this issue Aug 30, 2023 · 12 comments
Labels
$ ~<50usd A-maintenance A-nuxt A-tests A-vue3 chief p2 core functionality, or is affecting 60% of app

Comments

@yangwao
Copy link
Member

yangwao commented Aug 30, 2023

I think we should have test coverage for current functionality before we switch to Nuxt3

This is currently we had with Cypress?

Current playwright tests

Probably we should extended them at least on level we've had with Cypress

Originally posted by @yangwao in #6920 (comment)

@yangwao yangwao added p3 non-core, affecting less than 40% A-nuxt A-tests A-vue3 A-maintenance $ ~<50usd chief labels Aug 30, 2023
@prury
Copy link
Member

prury commented Aug 30, 2023

@yangwao i can start with the ones that are simpler, some others are complex and I'll take some to to study/re implement them

@prury prury self-assigned this Aug 30, 2023
@kodabot
Copy link
Collaborator

kodabot commented Aug 30, 2023

ASSIGNED - @prury 🔒 LOCKED -> Thursday, August 31st 2023, 18:34:34 UTC -> 24 hours

@kodabot
Copy link
Collaborator

kodabot commented Aug 31, 2023

ASSIGNMENT EXPIRED - @prury has been unassigned.

@pbkompasz pbkompasz mentioned this issue Sep 4, 2023
6 tasks
@yangwao yangwao added p2 core functionality, or is affecting 60% of app and removed p3 non-core, affecting less than 40% labels Sep 6, 2023
@prury
Copy link
Member

prury commented Sep 19, 2023

@nick-dev123 please lmk if you are going to refactor another one so we can split the load

@yangwao
Copy link
Member Author

yangwao commented Sep 25, 2023

@prury
Copy link
Member

prury commented Sep 25, 2023

So currently, there are 24 tests?

* https://github.com/kodadot/nft-gallery/actions/runs/6295705890/job/17089393328?pr=7354#step:7:48

Yes, and I'm already coding some new ones as we speak, expect a PR from me this week

Seems we don't cover inputs well

* [Listing price: I set the price 1 DOT it listed item for 100 DOTs! #7343](https://github.com/kodadot/nft-gallery/issues/7343)

Change price modal got introduced recently, and to test anything that requires signing a transaction needs something different than just a mockaddress to interact with koda. I have been studying the subject tho, talked with some ppl in the last few days.

I'm separating tests by their page/relation, instead of testing all the possible inputs in one test.

Usually my workflow is as follows:

Check test list priority(example):

Test Page Priority
Drops Page p2
Create Collection ✔️
Create NFT p1 - after #7208
Chain Change ✔️
Language Change ✔️
Profile Sidebar p1
Notifications p5
Shopping Cart p3
Transfer under development
Teleport Bridge p2
Explore Items ✔️ (@nick-dev123 )
Open graph ✔️
Filters p4
Explore Collections ✔️ (@nick-dev123 )
Sort p3
Identity wait for #7294 and #7361
Assets wait for future refactor
Collection items Tab p2
Collection Activity Tab p3
Gallery Item ✔️
Change NFT Price p3
Redirection ✔️
Chain Change ✔️
Transfer NFT p3
Profile Page Interactions p1
Wallet Interactions p1
Landing under development
Footer ✔️
Overall CSS p5
Blog p5
Search ✔️
Navbar p2

then i think about test cases for a specific page/component

Transfer Page:

  • button interactions
  • copy address button
  • check balances
  • address input
  • amount input
  • add and remove recipients
  • same transfer amount functionality
  • alternate between currencies
  • check token conversion
  • check if network fee loads
  • error message when inputting address
  • success messages when inputting address
  • alternate between possible transfer currencies
  • check if total changes

As you can observe, there are many test related work fronts

lmk what you think of it

@nick-dev123
Copy link

@prury Which tests are you working on from the list?

@prury
Copy link
Member

prury commented Sep 27, 2023

@prury Which tests are you working on from the list?

Transfer and Landing so far, also adding some small fixtures, let me improve this list, just a moment

@prury
Copy link
Member

prury commented Sep 27, 2023

@nick-dev123 done, this list will suffer changes as we go, but that's it for now! lmk which one you want!
hit me on telegram if you need anything

@prury prury mentioned this issue Sep 27, 2023
7 tasks
@yangwao
Copy link
Member Author

yangwao commented Oct 5, 2023

@prury
Copy link
Member

prury commented Oct 5, 2023

Do tests works on nuxt ? Doesn't look like?

* https://github.com/kodadot/nft-gallery/actions/runs/6417977813/job/17424815975?pr=7449

* https://github.com/kodadot/nft-gallery/actions/workflows/playwright.yml

some work, some don't, i am aware and i have been trying to fix them for nuxt in the last few days, but will need a bit more of time

@vikiival
Copy link
Member

Duplicate of #7826

@vikiival vikiival marked this as a duplicate of #7826 Jul 31, 2024
@vikiival vikiival closed this as not planned Won't fix, can't repro, duplicate, stale Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
$ ~<50usd A-maintenance A-nuxt A-tests A-vue3 chief p2 core functionality, or is affecting 60% of app
Projects
None yet
Development

No branches or pull requests

5 participants