Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor explore.spec.ts #7301

Merged
merged 7 commits into from
Sep 24, 2023
Merged

Refactor explore.spec.ts #7301

merged 7 commits into from
Sep 24, 2023

Conversation

nick-dev123
Copy link

@nick-dev123 nick-dev123 commented Sep 19, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ksm/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

Copilot Summary

🤖 Generated by Copilot at ccf9e6d

This pull request refactors several pages to use the composition API and the useHead composable from @vueuse/head library. This improves the code readability and consistency, and simplifies the document head management. The pages affected are pages/e2e-login.vue, pages/privacy-policy.vue, pages/series-insight.vue, pages/carbonless.vue, pages/cookie-notice.vue, pages/hot.vue, pages/qrCode.vue, and pages/sales.vue.

🤖 Generated by Copilot at ccf9e6d

To manage the document head
They used useHead instead
Of the old head method
That was not so splendid
And refactored some pages they said

@nick-dev123 nick-dev123 requested a review from a team as a code owner September 19, 2023 12:33
@nick-dev123 nick-dev123 requested review from preschian and Jarsen136 and removed request for a team September 19, 2023 12:33
@netlify
Copy link

netlify bot commented Sep 19, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit a69002f
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/650d4909e8070d0008aff466
😎 Deploy Preview https://deploy-preview-7301--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad
Copy link
Contributor

reviewpad bot commented Sep 19, 2023

AI-Generated Summary: This pull request contains four patches from the same author, focused on refining tests and tweaking a configuration:

  1. The first patch refactors the tests related to collection and item exploration in the end-to-end explore.spec.ts test file. A new file is created for these tests with more sophisticated block navigation and sorting tests.
  2. The second patch increases the timeout of the playwright testing configuration to 2 minutes for its associated server.
  3. The third patch enhances the 'SidebarFilter.vue' component by adding a 'data-testid' attribute to the 'PriceFilter' element for better identification in the tests.
  4. The final patch removes deprecated tests from the 'explore.cy.ts' file under the cypress-deprecated directory. This clean-up would likely improve the stability and maintainability of the test suite.

@reviewpad reviewpad bot added medium Pull request is medium waiting-for-review labels Sep 19, 2023
@reviewpad
Copy link
Contributor

reviewpad bot commented Sep 19, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

@roiLeo roiLeo requested a review from prury September 19, 2023 12:39
@prury
Copy link
Member

prury commented Sep 19, 2023

oh, nice! thanks!
i may be wrong, but running it with --trace on locally only validates that the skeletons are there, but not verifying if the images itself are loading
the global timeout i would leave it like i did on #7267
can we replace regex with something more tangible? since Sonar Cloud is reporting Security Hotspot

@prury
Copy link
Member

prury commented Sep 20, 2023

playwright not passing because of redirect test that i poorly refactored, but already made some changes on another PR

@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Sep 20, 2023
@roiLeo
Copy link
Contributor

roiLeo commented Sep 22, 2023

playwright not passing because of redirect test that i poorly refactored, but already made some changes on another PR

which one?

@codeclimate
Copy link

codeclimate bot commented Sep 22, 2023

Code Climate has analyzed commit a69002f and detected 0 issues on this pull request.

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented Sep 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@prury
Copy link
Member

prury commented Sep 22, 2023

playwright not passing because of redirect test that i poorly refactored, but already made some changes on another PR

which one?

yeah, now many are failing, i see it, previously was only redirect.spec.ts

@yangwao
Copy link
Member

yangwao commented Sep 24, 2023

pay 30 usd

@yangwao yangwao merged commit f55a836 into kodadot:main Sep 24, 2023
14 checks passed
This was referenced Sep 24, 2023
@nick-dev123
Copy link
Author

@yangwao The payment didn't go through

@yangwao
Copy link
Member

yangwao commented Sep 25, 2023

pay 30 usd

@yangwao
Copy link
Member

yangwao commented Sep 25, 2023

😍 Perfect, I’ve sent the payout
💵 $30 @ 4.03 USD/DOT ~ 7.444 $DOT
🧗 12ZLwasAvpdxDiiMedr11VeKUyQkY3WfneMkswBCAHVvxAqe
🔗 0x60d3bb900e13ddbfde340b1d506df6aedf499f197ac254f4f986d56568dde0b7

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Sep 25, 2023
@yangwao
Copy link
Member

yangwao commented Sep 25, 2023

@yangwao The payment didn't go through

This was referenced Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium Pull request is medium paid pull-request has been paid S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants