-
-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: clear identity #7361
feat: clear identity #7361
Conversation
WARNING @Jarsen136 PR for issue #7328 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #7328 |
✅ Deploy Preview for koda-canary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
AI-Generated Summary: This pull request implements a "clear identity" feature. The IdentityForm component has been modified to include this feature. Changes in this form either updates the identity if it already exists or creates a new one. A new "clearIdentity" function is added which clears the identity when it's called. Identity data can also be enhanced using the "enhanceIdentityData" function. In addition, changes were made to locales/en.json file to provide new locale strings related to the feature. It also includes a new CSS class |
unrelated: was testing and stumbled upon #7362
|
identity burning works and value previously deposited gets refunded also closes: #6188 |
✅ Done @exezbcz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise ok
Co-authored-by: roiLeo <medina.leo42@gmail.com>
Code Climate has analyzed commit f46b73e and detected 0 issues on this pull request. View more on Code Climate. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
did a second round of tests after the changes and is working fine ✔️ |
Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.
👇 __ Let's make a quick check before the contribution.
PR Type
Needs Design check
Context
Did your issue had any of the "$" label on it?
Screenshot 📸
Copilot Summary
🤖 Generated by Copilot at c147be4
Improved the identity form component and the useIdentity composable to handle different chains and identity data. Added new translations and styles to support the UI changes. Updated
identity.set
translation key and addedidentity.clear
,identity.existing
, andidentity.establishedIdentity
. Added.border-k-shade
class toglobal.scss
.🤖 Generated by Copilot at c147be4