Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: clear identity #7361

Merged
merged 9 commits into from
Sep 28, 2023
Merged

feat: clear identity #7361

merged 9 commits into from
Sep 28, 2023

Conversation

Jarsen136
Copy link
Contributor

@Jarsen136 Jarsen136 commented Sep 25, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature

Needs Design check

Context

Did your issue had any of the "$" label on it?

Screenshot 📸

  • My fix has changed UI
image

Copilot Summary

🤖 Generated by Copilot at c147be4

Improved the identity form component and the useIdentity composable to handle different chains and identity data. Added new translations and styles to support the UI changes. Updated identity.set translation key and added identity.clear, identity.existing, and identity.establishedIdentity. Added .border-k-shade class to global.scss.

🤖 Generated by Copilot at c147be4

Sing, O Muse, of the mighty pull request
That changed the identity form with skill and zest
How the coder, wise in translation keys, updated the set
And added new ones for clear, existing, and establishedIdentity yet

@Jarsen136 Jarsen136 requested a review from a team as a code owner September 25, 2023 17:59
@Jarsen136 Jarsen136 requested review from roiLeo and floyd-li and removed request for a team September 25, 2023 17:59
@kodabot
Copy link
Collaborator

kodabot commented Sep 25, 2023

WARNING @Jarsen136 PR for issue #7328 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #7328

@netlify
Copy link

netlify bot commented Sep 25, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit f46b73e
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/65142592e20f3c0008a19720
😎 Deploy Preview https://deploy-preview-7361--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad
Copy link
Contributor

reviewpad bot commented Sep 25, 2023

AI-Generated Summary: This pull request implements a "clear identity" feature. The IdentityForm component has been modified to include this feature. Changes in this form either updates the identity if it already exists or creates a new one. A new "clearIdentity" function is added which clears the identity when it's called. Identity data can also be enhanced using the "enhanceIdentityData" function. In addition, changes were made to locales/en.json file to provide new locale strings related to the feature. It also includes a new CSS class .border-k-shade in styles/global.scss for styling purposes. Moreover, the useIdentity composable file is updated to use these functions accordingly.

@reviewpad reviewpad bot added medium Pull request is medium waiting-for-review labels Sep 25, 2023
@prury
Copy link
Member

prury commented Sep 25, 2023

unrelated: was testing and stumbled upon #7362

related to this PR: it seems that the deposit value are not updating accordingly, or its kind of not reacting to chain change

@prury
Copy link
Member

prury commented Sep 25, 2023

identity burning works and value previously deposited gets refunded

also closes: #6188

@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Sep 25, 2023
@exezbcz
Copy link
Member

exezbcz commented Sep 25, 2023

this button should have the same effect as the ones in profile sidebar
image
image

otherwise okay for me, thnkas!

@Jarsen136
Copy link
Contributor Author

this button should have the same effect as the ones in profile sidebar image image

otherwise okay for me, thnkas!

✅ Done @exezbcz
image

Copy link
Member

@vikiival vikiival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise ok

styles/global.scss Outdated Show resolved Hide resolved
Co-authored-by: roiLeo <medina.leo42@gmail.com>
@codeclimate
Copy link

codeclimate bot commented Sep 27, 2023

Code Climate has analyzed commit f46b73e and detected 0 issues on this pull request.

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented Sep 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.4% 1.4% Duplication

@prury
Copy link
Member

prury commented Sep 27, 2023

did a second round of tests after the changes and is working fine ✔️

@yangwao yangwao merged commit 14fae3f into kodadot:main Sep 28, 2023
14 checks passed
This was referenced Sep 30, 2023
This was referenced Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium Pull request is medium S-visual-ok-✅ S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Identity clear Add option to clear identity
7 participants