-
-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix playwright test #7145
Fix playwright test #7145
Conversation
✅ Deploy Preview for koda-canary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
AI-Generated Summary: This pull request includes two different changes. In the first change, the developer adds a 5-minute timeout to the build process in the file 'playwright.config.ts'. This is likely to prevent excessively long build times. In the second change, the developer fixes a failing test in the 'BaseCollectionForm.vue' file. Specifically, he changes an HTML header from h2 to h1, probably to correctly represent the hierarchy of the content. |
Reviewpad Report
|
Code Climate has analyzed commit 4574f34 and detected 0 issues on this pull request. View more on Code Climate. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
aren't we using the new create collection already that already generates a h1 in the collection create page? |
can i close this one then? |
Did you try to run playwright tests on your local env? |
oh, got what you've said now, will try |
Closing as is not needed |
Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.
👇 __ Let's make a quick check before the contribution.
PR Type
Context
Did your issue had any of the "$" label on it?
Copilot Summary
🤖 Generated by Copilot at 4574f34
Refactored the collection form component to use NeoField and changed the heading level to
<h1>
. Increased the playwright test timeout to 5 minutes to prevent test failures.🤖 Generated by Copilot at 4574f34