Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix playwright test #7145

Closed
wants to merge 2 commits into from
Closed

Conversation

pbkompasz
Copy link
Contributor

@pbkompasz pbkompasz commented Sep 4, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Did your issue had any of the "$" label on it?

Copilot Summary

🤖 Generated by Copilot at 4574f34

Refactored the collection form component to use NeoField and changed the heading level to <h1>. Increased the playwright test timeout to 5 minutes to prevent test failures.

🤖 Generated by Copilot at 4574f34

<h1> for form
NeoField and playwright tests
Winter of refactor

@pbkompasz pbkompasz marked this pull request as ready for review September 4, 2023 18:14
@pbkompasz pbkompasz requested a review from a team as a code owner September 4, 2023 18:14
@pbkompasz pbkompasz requested review from floyd-li and Jarsen136 and removed request for a team September 4, 2023 18:14
@netlify
Copy link

netlify bot commented Sep 4, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 4574f34
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64f61e99a172dd00077d9f9e
😎 Deploy Preview https://deploy-preview-7145--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad
Copy link
Contributor

reviewpad bot commented Sep 4, 2023

AI-Generated Summary: This pull request includes two different changes. In the first change, the developer adds a 5-minute timeout to the build process in the file 'playwright.config.ts'. This is likely to prevent excessively long build times. In the second change, the developer fixes a failing test in the 'BaseCollectionForm.vue' file. Specifically, he changes an HTML header from h2 to h1, probably to correctly represent the hierarchy of the content.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Sep 4, 2023
@reviewpad
Copy link
Contributor

reviewpad bot commented Sep 4, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

@codeclimate
Copy link

codeclimate bot commented Sep 4, 2023

Code Climate has analyzed commit 4574f34 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented Sep 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@roiLeo roiLeo requested a review from prury September 5, 2023 06:39
@prury
Copy link
Member

prury commented Sep 5, 2023

aren't we using the new create collection already that already generates a h1 in the collection create page?
playwright tests are already succeeding as far as i can see
i would change the tests timeout to 2 min instead of 5 tho
@roiLeo do you think my assumptions are correct?

@roiLeo
Copy link
Contributor

roiLeo commented Sep 5, 2023

aren't we using the new create collection already that already generates a h1 in the collection create page?

Yes you are right.

Tried to run tests locally and it worked on this branch but not on main (pnpm exec playwright test)

Capture d’écran 2023-09-05 à 4 06 56 PM

@prury
Copy link
Member

prury commented Sep 5, 2023

can i close this one then?

@roiLeo
Copy link
Contributor

roiLeo commented Sep 5, 2023

can i close this one then?

Tried to run tests locally and it worked on this branch but not on main

Did you try to run playwright tests on your local env?

@prury
Copy link
Member

prury commented Sep 5, 2023

can i close this one then?

Tried to run tests locally and it worked on this branch but not on main

Did you try to run playwright tests on your local env?

oh, got what you've said now, will try

@prury
Copy link
Member

prury commented Sep 5, 2023

Did you try to run playwright tests on your local env?

works fine on my local env (synced main branch)

image

@roiLeo
Copy link
Contributor

roiLeo commented Sep 5, 2023

works fine on my local env (synced main branch)

Tried again and it worked
Capture d’écran 2023-09-05 à 4 50 28 PM

but earlier no
Capture d’écran 2023-09-05 à 4 52 00 PM

feel free to close it

@prury
Copy link
Member

prury commented Sep 5, 2023

Closing as is not needed

@prury prury closed this Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants