refactor: unify create page #7208

preschian · 2023-09-07T13:47:57Z

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

Bugfix
Feature
Refactoring

Needs QA check

@kodadot/qa-guild please review

Context

Closes Simple Mint v2 #5939

Did your issue had any of the "$" label on it?

My DOT address: Payout

Screenshot 📸

screenshot

Copilot Summary

`🤖 Generated by Copilot at c2833a6`

Added new pages and components for creating single NFTs on different blockchains, refactored some existing components and composables, and removed some unused files and code.

`🤖 Generated by Copilot at c2833a6`

To create NFTs with more ease
We added some pages and styles
CreateNft has options galore
CreateLanding lets you explore
And CreateNftPreview beguiles

…nify-create-nft-page

kodabot · 2023-09-07T13:48:02Z

WARNING @preschian PR for issue #5939 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #5939

netlify · 2023-09-07T13:48:02Z

✅ Deploy Preview for koda-canary ready!

Name	Link
🔨 Latest commit	`6a71a18`
🔍 Latest deploy log	https://app.netlify.com/sites/koda-canary/deploys/65141fd47491a3000868ed69
😎 Deploy Preview	https://deploy-preview-7208--koda-canary.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Jarsen136 · 2023-09-07T15:12:20Z

I discovered a UI issue

components/create/CreateNft.vue

prury · 2023-09-07T16:35:44Z

Mobile:

locales/en.json

prury · 2023-09-07T16:49:50Z

Minted one nft just for experience:
https://deploy-preview-7208--koda-canary.netlify.app/ahk/gallery/111-3

tags will be added later?

duplicated/wrong text:

this pretty text also missing:

roiLeo

some stuff

components/create/CreateCollection.vue

components/create/CreateLanding.vue

components/create/CreateNft.vue

components/create/create.scss

composables/useDeposit.ts

composables/useGraphql.ts

queries/subsquid/general/nftByBlockNumber.graphql

utils/ipfs.ts

components/create/CreateNft.vue

components/create/CreateNftPreview.vue

preschian · 2023-09-25T09:43:40Z

Smoll issue:

sale class doing weird stuff on default label

not sure how to fix this one. looks fine if I change font-family to monospace cc @roiLeo

one important thing: Selecting Kusama on NFT creation is not loading the collections

I would expand this it seems the collections dropdown is generally not reactive

be logged out => navigate to nft create page => log in => collections don't load

be logged in => navigate to nft create page => log out => collections don't disappear

change network => collections don't update

fixed cc @prury @daiagi

the text talks about collection, but it's the create NFT page

fixed

I think it would be better to implement the transition to the 2nd nft page via URL (i.e. separate page for it / URL param)
as it is now, there's no way of navigating back from this screen:

fixed

prury · 2023-09-25T14:34:16Z

Minting round:
Basilisk:
minting✔️, listing✔️, redirection✔️
https://basilisk.subscan.io/tx/0x90989609d21316285df72b937cdec6fecc856ab62e0e3ae6dfa9bc78b8b5655a ✔️

RMRK1
minting✔️ , listing ❌(only asked for 1 tx i believe) , redirection✔️, copies ✔️, attributes ✔️
https://kusama.subscan.io/tx/0x7dc555b746ea1d5c3c9491fe68d23db721942e8934f07a9ca477af939b170134

RMRK 2
minting✔️ , listing ❌ , redirection✔️, copies ✔️, attributes ✔️
https://kusama.subscan.io/tx/0x3c6309eea5873e5468ae96a43133be442b773e9bb665e482f08a9bc3efe9f4ab

Asset Hub Kusama:
minting✔️ , listing ✔️ , redirection✔️, copies ✔️, attributes ✔️
https://assethub-kusama.subscan.io/tx/0xf0be2655bb71a5e4864ee389eb63566e7e6eab009442819cb8b0390b24c5c125

Asset Hub Polkadot:
minting✔️ , listing ✔️ , redirection✔️, copies ✔️, attributes ✔️
https://assethub-polkadot.subscan.io/tx/0x84d398aebdef6a73bd5d34d2fcb47b428ef5ecde358dc02de3f32b17ab570cc1

small:

also:
redirection message not appearing('you will be redirected to, bla bla')

preschian · 2023-09-26T10:48:56Z

RMRK1 minting✔️ , listing ❌(only asked for 1 tx i believe) , redirection✔️, copies ✔️, attributes ✔️ kusama.subscan.io/tx/0x7dc555b746ea1d5c3c9491fe68d23db721942e8934f07a9ca477af939b170134

RMRK 2 minting✔️ , listing ❌ , redirection✔️, copies ✔️, attributes ✔️ kusama.subscan.io/tx/0x3c6309eea5873e5468ae96a43133be442b773e9bb665e482f08a9bc3efe9f4ab

TIL, that rmrk needs to list that manually. want to test that on snek, but the endpoint is still down on my end :(

…nify-create-nft-page

daiagi · 2023-09-27T11:56:47Z

The icons should be bigger no?

preschian · 2023-09-27T11:58:16Z

The icons should be bigger no?

correct, will update that also 🙏

daiagi

beautiful work

daiagi · 2023-09-27T12:05:37Z

pages/_prefix/create/index.vue

+      title,
+      type: 'article',
+      description: 'Create carbonless NFTs with low on-chain fees',
+      url: '/create/nft',


missing prefix?

components/create/CreateCollection.vue

exezbcz · 2023-09-27T12:18:42Z

for follow-up issue I guess:

I think it would be good for UX to have in the collection drop-down a menu item that appears only if not logged in. clicking this menu item would open the log-in modal (similar to shopping cart) also, it would be nice to have if logged in but no collection is available on the account => drop-down item to create a new collection (similar to massmint)

@exezbcz wdyt?

sorry for the late answer, yes, I have created issue, soon design and letsgo

exezbcz · 2023-09-27T12:20:12Z

after this pr, there should be the dropdown for create

it should redirect you directly to the page where you choose from collection/nft

inconsistent font size

codeclimate · 2023-09-27T12:28:34Z

Code Climate has analyzed commit 6a71a18 and detected 0 issues on this pull request.

View more on Code Climate.

sonarcloud · 2023-09-27T12:28:40Z

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
7.0% Duplication

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

preschian · 2023-09-27T12:35:04Z

inconsistent font size

updated

prury · 2023-09-27T13:05:28Z

RMRK minting + listing now working, thank you @preschian
really nice work!

yangwao · 2023-09-27T13:33:34Z

pay 100 usd

yangwao · 2023-09-27T13:33:47Z

😍 Perfect, I’ve sent the payout
💵 $100 @ 4.06 USD/DOT ~ 24.631 $DOT
🧗 1xjvRADwdJcnmUCLWerEHR4iGCT5EBTm4D4fzLLg4LcAC9p
🔗 0x98c6e573765adf45bdf4f8491d99b0301ac08561df490c74177d6dfc68fb3d47

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

preschian added 8 commits September 7, 2023 15:01

refactor: unify create nft page

536624b

Merge branch 'main' of github.com:kodadot/nft-gallery into refactor/u…

cd368ba

…nify-create-nft-page

fix: retry for nft id

3de759d

style: mobile padding

950a9e7

chore: add chainDecimals

7e81bad

feat: create landing page

979b631

feat: image preview

a576a4c

refactor: replace existing pages

c2833a6

reviewpad bot added the large Pull request is large label Sep 7, 2023

chore: text

97ea17b

preschian marked this pull request as ready for review September 7, 2023 14:32

preschian requested a review from a team as a code owner September 7, 2023 14:32

preschian requested review from roiLeo and prury and removed request for a team September 7, 2023 14:32

reviewpad bot added the waiting-for-review label Sep 7, 2023

prury requested a review from Jarsen136 September 7, 2023 15:01

Jarsen136 requested a review from daiagi September 7, 2023 15:10

style: width

d725651

prury reviewed Sep 7, 2023

View reviewed changes

components/create/CreateNft.vue Show resolved Hide resolved

prury requested a review from EthVlad September 7, 2023 16:29

prury reviewed Sep 7, 2023

View reviewed changes

locales/en.json Outdated Show resolved Hide resolved

prury added the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label Sep 7, 2023

roiLeo reviewed Sep 8, 2023

View reviewed changes

Jarsen136 reviewed Sep 11, 2023

View reviewed changes

components/create/CreateNft.vue Outdated Show resolved Hide resolved

components/create/CreateNft.vue Outdated Show resolved Hide resolved

components/create/CreateNft.vue Outdated Show resolved Hide resolved

components/create/CreateNftPreview.vue Outdated Show resolved Hide resolved

preschian added 3 commits September 25, 2023 16:18

chore: text on deposit

c73cf29

fix: use query instead

e9c228d

fix: somehow neofield sale broken

2b3f6d6

preschian added 4 commits September 27, 2023 18:34

fix: listed nft on remark

7d798b5

chore: remove console.log

29b5793

styles: box color

6c288e3

Merge branch 'main' of github.com:kodadot/nft-gallery into refactor/u…

c22afd7

…nify-create-nft-page

daiagi approved these changes Sep 27, 2023

View reviewed changes

exezbcz mentioned this pull request Sep 27, 2023

Not connected wallet collection selection #7382

Closed

styles: seo url, font-size and icon

6a71a18

prury added S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked and removed S-changes-requested-🤞 PR is almost good to go, just some fine tunning labels Sep 27, 2023

prury approved these changes Sep 27, 2023

View reviewed changes

yangwao merged commit 497e36e into main Sep 27, 2023
13 of 14 checks passed

yangwao deleted the refactor/unify-create-nft-page branch September 27, 2023 13:33

yangwao added the paid pull-request has been paid label Sep 27, 2023

prury mentioned this pull request Sep 27, 2023

What is current Playwright test coverage? #7051

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: unify create page #7208

refactor: unify create page #7208

preschian commented Sep 7, 2023 •

edited by ghost

Loading

kodabot commented Sep 7, 2023

netlify bot commented Sep 7, 2023 •

edited

Loading

Jarsen136 commented Sep 7, 2023

prury commented Sep 7, 2023

prury commented Sep 7, 2023 •

edited

Loading

roiLeo left a comment

preschian commented Sep 25, 2023

prury commented Sep 25, 2023

preschian commented Sep 26, 2023

daiagi commented Sep 27, 2023

preschian commented Sep 27, 2023

daiagi left a comment

daiagi Sep 27, 2023

roiLeo Sep 27, 2023

exezbcz commented Sep 27, 2023

for follow-up issue I guess:

exezbcz commented Sep 27, 2023 •

edited

Loading

codeclimate bot commented Sep 27, 2023

sonarcloud bot commented Sep 27, 2023

preschian commented Sep 27, 2023

prury commented Sep 27, 2023

yangwao commented Sep 27, 2023

yangwao commented Sep 27, 2023

refactor: unify create page #7208

refactor: unify create page #7208

Conversation

preschian commented Sep 7, 2023 • edited by ghost Loading

PR Type

Needs QA check

Context

Did your issue had any of the "$" label on it?

Screenshot 📸

Copilot Summary

🤖 Generated by Copilot at c2833a6

🤖 Generated by Copilot at c2833a6

kodabot commented Sep 7, 2023

netlify bot commented Sep 7, 2023 • edited Loading

✅ Deploy Preview for koda-canary ready!

Jarsen136 commented Sep 7, 2023

prury commented Sep 7, 2023

prury commented Sep 7, 2023 • edited Loading

roiLeo left a comment

Choose a reason for hiding this comment

preschian commented Sep 25, 2023

prury commented Sep 25, 2023

preschian commented Sep 26, 2023

daiagi commented Sep 27, 2023

preschian commented Sep 27, 2023

daiagi left a comment

Choose a reason for hiding this comment

daiagi Sep 27, 2023

Choose a reason for hiding this comment

roiLeo Sep 27, 2023

Choose a reason for hiding this comment

exezbcz commented Sep 27, 2023

for follow-up issue I guess:

exezbcz commented Sep 27, 2023 • edited Loading

codeclimate bot commented Sep 27, 2023

sonarcloud bot commented Sep 27, 2023

preschian commented Sep 27, 2023

prury commented Sep 27, 2023

yangwao commented Sep 27, 2023

yangwao commented Sep 27, 2023

preschian commented Sep 7, 2023 •

edited by ghost

Loading

`🤖 Generated by Copilot at c2833a6`

`🤖 Generated by Copilot at c2833a6`

netlify bot commented Sep 7, 2023 •

edited

Loading

prury commented Sep 7, 2023 •

edited

Loading

exezbcz commented Sep 27, 2023 •

edited

Loading