Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: tools arb passable #1291

Merged
merged 1 commit into from
Jan 15, 2023
Merged

fix: tools arb passable #1291

merged 1 commit into from
Jan 15, 2023

Conversation

erights
Copy link
Contributor

@erights erights commented Sep 21, 2022 •
edited
Loading

Follows Agoric/agoric-sdk#6296 , to move those enhancements to test-rankOrder to endo as well.

@erights erights self-assigned this Sep 21, 2022
@erights erights mentioned this pull request Sep 21, 2022
Merged
@erights erights mentioned this pull request Sep 26, 2022
Merged
@kriskowal
Copy link
Member

I presume s/arb/are in the PR title and branch name, but I’m prepared to be surprised by a new acronym!

@erights
Copy link
Contributor Author

erights commented Sep 27, 2022

It is fast-check speak for "arbitrary"

@kriskowal
Copy link
Member

I was almost as prepared for a new abbreviation! Thanks.

@erights erights force-pushed the markm-tools-arb-passable branch 2 times, most recently from 3c40c00 to 0bbc136 Compare September 27, 2022 00:37
@erights erights marked this pull request as ready for review September 27, 2022 01:57
@erights erights changed the title WIP: tools arb passable fix: tools arb passable Oct 1, 2022
@erights erights requested a review from mhofman October 11, 2022 23:53
gibson042
gibson042 approved these changes Oct 12, 2022
View reviewed changes
Copy link
Contributor

@gibson042 gibson042 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@erights erights mentioned this pull request Oct 19, 2022
Merged
@erights erights force-pushed the markm-tools-arb-passable branch 3 times, most recently from 2eea1b8 to 6728582 Compare November 5, 2022 04:20
@erights erights force-pushed the markm-binary-marshal branch 2 times, most recently from 132ff75 to 8ac6c3d Compare November 5, 2022 06:21
@erights erights mentioned this pull request Nov 7, 2022
Merged
Base automatically changed from markm-binary-marshal to master November 7, 2022 06:14
@erights erights force-pushed the markm-tools-arb-passable branch 5 times, most recently from af80a24 to cef2a1f Compare November 12, 2022 01:43
@erights erights force-pushed the markm-tools-arb-passable branch 3 times, most recently from 7f1c1bc to a49e8da Compare November 24, 2022 01:36
@erights erights force-pushed the markm-tools-arb-passable branch 2 times, most recently from 69f4b47 to f648918 Compare December 2, 2022 22:10
@erights erights mentioned this pull request Dec 11, 2022
Merged
@erights erights force-pushed the markm-tools-arb-passable branch 2 times, most recently from 5e1aa08 to c05b65f Compare December 23, 2022 22:52
@erights erights mentioned this pull request Jan 10, 2023
Draft
@erights erights force-pushed the markm-tools-arb-passable branch 2 times, most recently from efbde5f to a077351 Compare January 14, 2023 22:42
@erights erights merged commit 368d7cb into master Jan 15, 2023
@erights erights deleted the markm-tools-arb-passable branch January 15, 2023 04:59
@erights erights mentioned this pull request Jan 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gibson042 gibson042 gibson042 approved these changes

@mhofman mhofman Awaiting requested review from mhofman

Assignees

@erights erights

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@erights @kriskowal @gibson042