fix: marshal export what others import #1447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that @endo/marshal has what it should (due to #1439 and #1291 ), when this version of endo is released and agoric-sdk is upgraded to depend on it, we have a potential problem: deep imports by code in agoric-sdk into the midst of internal modules in endo. In particular, the compat requirements #1439 was written to meet was to continue to support code that imports what @endo/marshal explicitly exports. But #1439 was not written to support code that deeply imports from the internals of marshal.
The best answer to that is for agoric-sdk to stop deeply importing from marshal, which is what Agoric/agoric-sdk#6792 will accomplish. But Agoric/agoric-sdk#6792 cannot work until agoric-sdk has been upgraded to depend on a version of endo in which those imports are exported directly by marshal, which is what this PR does.