Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: arb passable tools #6296

Merged
merged 2 commits into from
Oct 19, 2022
Merged

fix: arb passable tools #6296

merged 2 commits into from
Oct 19, 2022

Conversation

erights
Copy link
Member

@erights erights commented Sep 21, 2022

Move the generation of fast-check arb passables into a separate module in a new store/tools directory. This establishes a pattern of putting arb generators into tools/ directories, where they are still only to support testing, can be exported and reused by other packages for their own testing purposes.

@erights erights self-assigned this Sep 21, 2022
@erights erights force-pushed the markm-arb-tools branch 2 times, most recently from d10b854 to ef37b24 Compare September 21, 2022 21:20
@erights erights changed the title WIP: arb passable tools fix: arb passable tools Sep 21, 2022
@erights erights marked this pull request as ready for review September 21, 2022 21:29
@erights erights changed the base branch from master to markm-test-rankOrder-works-ava-3or4 September 27, 2022 00:07
@erights erights force-pushed the markm-test-rankOrder-works-ava-3or4 branch from 202df6a to 2fc05a1 Compare September 27, 2022 02:02
@erights erights force-pushed the markm-test-rankOrder-works-ava-3or4 branch from 2fc05a1 to 19d23d2 Compare September 29, 2022 03:45
@erights erights force-pushed the markm-test-rankOrder-works-ava-3or4 branch from 19d23d2 to f268899 Compare September 29, 2022 20:42
Base automatically changed from markm-test-rankOrder-works-ava-3or4 to master September 29, 2022 21:23
Copy link
Member

@gibson042 gibson042 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good after a few tweaks.

packages/store/tools/arb-passable.js Outdated Show resolved Hide resolved
packages/store/tools/arb-passable.js Outdated Show resolved Hide resolved
packages/store/tools/arb-passable.js Outdated Show resolved Hide resolved
packages/store/tools/arb-passable.js Outdated Show resolved Hide resolved
packages/store/test/test-rankOrder.js Outdated Show resolved Hide resolved
@erights
Copy link
Member Author

erights commented Oct 8, 2022

Took all your suggestions. PTAL

@erights
Copy link
Member Author

erights commented Oct 11, 2022

ping

@erights
Copy link
Member Author

erights commented Oct 13, 2022

ping

Copy link
Member

@gibson042 gibson042 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@erights erights added automerge:squash Automatically squash merge and removed automerge:squash Automatically squash merge labels Oct 18, 2022
@erights erights added automerge:squash Automatically squash merge and removed automerge:squash Automatically squash merge labels Oct 18, 2022
@mergify mergify bot merged commit d91ee8c into master Oct 19, 2022
@mergify mergify bot deleted the markm-arb-tools branch October 19, 2022 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge:squash Automatically squash merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants