refactor: use encodePassable,rankOrder from endo #6660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erights
force-pushed
the
markm-use-endo-rankOrder
branch
from
b736219
to
cac4dfc
Compare
erights
force-pushed
the
markm-use-endo-rankOrder
branch
2 times, most recently
from
cfd4eb3
to
e26c8e9
Compare
erights
force-pushed
the
markm-use-endo-rankOrder
branch
from
e26c8e9
to
096dac7
Compare
turadg
approved these changes
Jan 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that endojs/endo#1291 is merged, this PR is ready for review. endojs/endo#1291 completed the endo portion of the migration of encodePassable and rankOrder from agoric-sdk to endo. What remains is for agoric-sdk to delete its own redundant copies.
Note that this PR works in agoric-sdk now, because it actually only depended on the encodePassable and rankOrder that had already been moved to endo. It was waiting for endojs/endo#1291 only to ensure that an improvement to test quality didn't get lost in the shuffle.
This PR is a step towards #6792 which can only be merged after it can depend on endojs/endo#1447 .