Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dashboard] Move Sharing Saved Object Props into Meta Object #119913

Merged
merged 5 commits into from
Dec 1, 2021
Merged

[Dashboard] Move Sharing Saved Object Props into Meta Object #119913

merged 5 commits into from
Dec 1, 2021

Conversation

ThomThomson
Copy link
Contributor

Summary

Fixes #119677.

This PR makes the attribute service's unwrap method return a generically typed meta object alongside the saved object attributes. Getting the input as a value type will not include this, but when using the unwrap method to load the saved object for a by reference panel, the unwrap meta info can be used.

The SharingSavedObjectProps has been moved into this new unwrap meta key for both Maps and Lens.

Checklist

Delete any items that are not applicable to this PR.

@ThomThomson ThomThomson changed the title Remove sharing saved object props from by value Lens and Maps panels. [Dashboard] Move Sharing Saved Object Props into Meta Object Nov 29, 2021
@ThomThomson ThomThomson added Feature:Dashboard Dashboard related features Feature:Lens [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas Team:Visualizations Visualization editors, elastic-charts and infrastructure impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:medium Medium Level of Effort release_note:skip Skip the PR/issue when compiling release notes v7.16.0 v8.0.0 v8.1.0 labels Nov 29, 2021
@ThomThomson ThomThomson marked this pull request as ready for review December 1, 2021 14:43
@ThomThomson ThomThomson requested review from a team as code owners December 1, 2021 14:43
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

nreese
nreese approved these changes Dec 1, 2021
View reviewed changes
Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maps changes LGTM - thanks for fixing

@botelastic botelastic bot added the Feature:Embedding Embedding content via iFrame label Dec 1, 2021
@mbondyra mbondyra self-requested a review December 1, 2021 15:28
@Heenawter Heenawter mentioned this pull request Dec 1, 2021
Closed
3 tasks
Dosant
Dosant approved these changes Dec 1, 2021
View reviewed changes
Copy link
Contributor

@Dosant Dosant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AppService code lgtm

src/plugins/embeddable/public/lib/attribute_service/attribute_service.tsx Outdated Show resolved Hide resolved
@ThomThomson @Dosant
Update src/plugins/embeddable/public/lib/attribute_service/attribute_…
dbfbb5a 
…service.tsx

Co-authored-by: Anton Dosov <dosantappdev@gmail.com>
@ThomThomson
Copy link
Contributor Author

@elasticmachine merge upstream

@mbondyra
Update embeddable.tsx
f3d9991 
make sure conflict error logic will execute
mbondyra
mbondyra approved these changes Dec 1, 2021
View reviewed changes
Copy link
Contributor

@mbondyra mbondyra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and works fine for Lens 🆗 Thanks a lot for fixing this!

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dashboard 274.6KB 274.6KB +11.0B
lens 965.6KB 965.7KB +72.0B
maps 2.6MB 2.6MB +78.0B
total +161.0B

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
embeddable 3 4 +1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
embeddable 63.7KB 63.7KB +38.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

crob611
crob611 approved these changes Dec 1, 2021
View reviewed changes
Copy link
Contributor

@crob611 crob611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Presentation changes look good 👍

@ThomThomson ThomThomson merged commit 9f302fc into elastic:main Dec 1, 2021
@ThomThomson ThomThomson mentioned this pull request Dec 1, 2021
Merged
ThomThomson added a commit to ThomThomson/kibana that referenced this pull request Dec 1, 2021
@ThomThomson
[Dashboard] Move Sharing Saved Object Props into Meta Object (elastic…
ab38313 
…#119913)

Co-authored-by: Anton Dosov <dosantappdev@gmail.com>
Co-authored-by: Marta Bondyra <marta.bondyra@gmail.com>
# Conflicts:
#	x-pack/plugins/lens/public/embeddable/embeddable.tsx
@ThomThomson ThomThomson mentioned this pull request Dec 1, 2021
Merged
ThomThomson added a commit to ThomThomson/kibana that referenced this pull request Dec 1, 2021
@ThomThomson
[Dashboard] Move Sharing Saved Object Props into Meta Object (elastic…
16ba7a8 
…#119913)

Co-authored-by: Anton Dosov <dosantappdev@gmail.com>
Co-authored-by: Marta Bondyra <marta.bondyra@gmail.com>
# Conflicts:
#	x-pack/plugins/lens/public/embeddable/embeddable.tsx
ThomThomson added a commit that referenced this pull request Dec 1, 2021
@ThomThomson
[Dashboard] Move Sharing Saved Object Props into Meta Object (#119913) (
a55ba0a 
#120176)

Co-authored-by: Anton Dosov <dosantappdev@gmail.com>
Co-authored-by: Marta Bondyra <marta.bondyra@gmail.com>
# Conflicts:
#	x-pack/plugins/lens/public/embeddable/embeddable.tsx
ThomThomson added a commit that referenced this pull request Dec 1, 2021
@ThomThomson
[Dashboard] Move Sharing Saved Object Props into Meta Object (#119913) (
d998df5 
#120177)

Co-authored-by: Anton Dosov <dosantappdev@gmail.com>
Co-authored-by: Marta Bondyra <marta.bondyra@gmail.com>
# Conflicts:
#	x-pack/plugins/lens/public/embeddable/embeddable.tsx
@mbondyra mbondyra mentioned this pull request Dec 2, 2021
Merged
9 tasks
@Heenawter Heenawter mentioned this pull request Dec 8, 2021
Merged
3 tasks
TinLe pushed a commit to TinLe/kibana that referenced this pull request Dec 22, 2021
@ThomThomson @Dosant
@mbondyra @TinLe
[Dashboard] Move Sharing Saved Object Props into Meta Object (elastic…
7e29c75 
…#119913)

Co-authored-by: Anton Dosov <dosantappdev@gmail.com>
Co-authored-by: Marta Bondyra <marta.bondyra@gmail.com>
gbamparop pushed a commit to gbamparop/kibana that referenced this pull request Jan 12, 2022
@ThomThomson @Dosant
@mbondyra @gbamparop
[Dashboard] Move Sharing Saved Object Props into Meta Object (elastic…
ec50860 
…#119913)

Co-authored-by: Anton Dosov <dosantappdev@gmail.com>
Co-authored-by: Marta Bondyra <marta.bondyra@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nreese nreese nreese approved these changes

@crob611 crob611 crob611 approved these changes

@mbondyra mbondyra mbondyra approved these changes

@Dosant Dosant Dosant approved these changes

Assignees
No one assigned
Labels
[Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation Feature:Dashboard Dashboard related features Feature:Embedding Embedding content via iFrame Feature:Lens impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:medium Medium Level of Effort release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.16.0 v8.0.0 v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SharingSavedObjectProps Injected into Dashboard Saved Object
8 participants
@ThomThomson @elasticmachine @kibana-ci @nreese @crob611 @mbondyra @Dosant @kibanamachine