[Dashboard] Fix blank panel save and display issue. #120815

Heenawter · 2021-12-08T18:28:03Z

Closes #118624
Relies on #119913

Summary

Originally, blank panel titles resulted in issues when panel states were compared in diff_dashboard_state.ts because each of the following panel object states was considered to be different:

panel object has title = ''
panel object has title = undefined
panel object does not contain the title key

This caused unexpected behavior when dealing with empty titles. To fix this, I started by creating a special case inside of diff_dashboard_state.ts for comparing panels so that each one of the above scenarios is seen as equal.

However, as part of this bug fix, it was noticed that the behaviour when a panel is linked/unlinked to/from the library was inconsistent - to fix this, the panel's title always gets overwritten when it is linked to the library and the attribute title is dropped when a panel is unlinked (since by value panels do not have attribute titles).

To hopefully prevent these types of issues in the future, a full test suite related to panel titles was added.

Video of Fix in Action

Dashboard-FixedBlankPanelSave.mp4

Flaky Test
To ensure that the new test suite was not flaky, I ran it 100 times and it passed every single time.

Checklist

Delete any items that are not applicable to this PR.

Unit or functional tests were updated or added to match the most common scenarios
This was checked for cross-browser compatibility

For maintainers

This was checked for breaking API changes and was labeled appropriately

elasticmachine · 2021-12-09T16:21:38Z

Pinging @elastic/kibana-presentation (Team:Presentation)

ThomThomson

Functional tests

Great to see the flaky test runner results! I have no input at all about the functional test suite. It looks good, runs well, is well commented, and doesn't repeat itself!

I tested this locally by:

Setting the title to a blank string and saving - no unsaved changes ✔️
Giving a custom title to a panel and saving - no unsaved changes ✔️
Adding a by value panel to the library - custom title is default in modal - custom title is replaced with library title ✔️
Unlinking a panel from the library - library title is moved to panel title, resetting defaults to blank title ✔️
Editing a panel title causes unsaved changes - resetting that title causes unsaved changes to disappear ✔️
I also imported a dashboard from 7.9 with a few titles hidden. I can confirm that titles that were hidden in 7.9 are still hidden after being imported in this PR. ✔️✔️✔️

I ran through all of the above tests with Lens, Maps & Visualize panels, and everything looks good except for one problem with visualize.

Visualize unlink issue

Because visualize doesn't store its by value information under the attributes key, unsetting explicitInput.attributes.title doesn't do anything. Therefore unlinking a visualize by reference panel, then saving the dashboard will not clear the unsaved changes badge. This should be a pretty quick fix!

Overall, everything is looking awesome, and we should be able to merge this soon. I also left one tiny nit.

Thanks for tackling this as your first major PR!

ThomThomson · 2021-12-09T19:16:32Z

src/plugins/embeddable/public/lib/attribute_service/attribute_service.tsx

-          // Combine input and wrapped input to preserve any passed in explicit Input.
-          resolve({ ...newInput, ...wrappedInput });
+          // Combine input and wrapped input to preserve any passed in explicit Input while ensuring that the
+          // library title ovewrites the original title


ThomThomson · 2021-12-09T19:17:10Z

src/plugins/embeddable/public/lib/panel/panel_header/panel_header.tsx

-        title={title}
-      />
-    </figcaption>
+    <span data-test-subj="dashboardPanelTitle__wrapper">


If you have the data-test-subj above on line 156, do you need to wrap all of this with the same data-test-subj?

Unfortunately, yup! The data-test-subj from line 156 is for when the panel title is explicitly hidden using the toggle - the one on line 215, on the other hand, is for when the title is anything else (including when it is set to the empty string). This is the only way to be able to capture all titles regardless of whether or not they are explicitly hidden.

ThomThomson · 2021-12-09T19:18:25Z

x-pack/test/functional/apps/dashboard/panel_titles.ts

+import expect from '@kbn/expect';
+import { FtrProviderContext } from '../../ftr_provider_context';
+
+export default function ({ getService, getPageObjects }: FtrProviderContext) {


This is a very well put together test suite 🔥🔥

… defined when unlinking.

Heenawter · 2021-12-09T20:55:25Z

src/plugins/visualizations/public/vis.ts

@@ -200,7 +200,7 @@ export class Vis<TVisParams = VisParams> {
      data: {
        aggs: aggs as any,
        searchSource: this.data.searchSource ? this.data.searchSource.getSerializedFields() : {},
-        savedSearchId: this.data.savedSearchId,
+        ...(this.data.savedSearchId ? { savedSearchId: this.data.savedSearchId } : {}),


When adding a by reference Visualize panel, the savedSearchId key does not exist in this.data. However, when unlinking, this key was injected in to this.data via this original line - i.e. this.data.savedSearchId = undefined | string. Unfortunately, our current deep comparison of panels when saving treats a key not existing and key = undefined as unequal - this prevented the unsaved changes badge from being cleared.

To prevent this, the savedSearchID key only gets added if it has a value.

Heenawter · 2021-12-09T21:52:48Z

Visualize unlink issue

Because visualize doesn't store its by value information under the attributes key, unsetting explicitInput.attributes.title doesn't do anything. Therefore unlinking a visualize by reference panel, then saving the dashboard will not clear the unsaved changes badge. This should be a pretty quick fix!

This is fixed via commit 84afa07 ☺️

ThomThomson

With the slight changes to the visualize serialization method, there are no longer any problems with comparisons on unlink / add to library.

Everything LGTM!

jloleysens

Tested locally and behaviour LGTM. I left a couple of comments on how I think code could be made clearer and restructuring of functional tests - I won't block on those though 👍🏻 great work @Heenawter

jloleysens · 2021-12-13T10:43:10Z

x-pack/test/functional/apps/dashboard/panel_titles.ts

+      // unlink so that panel goes back to by value for next tests
+      await dashboardPanelActions.unlinkFromLibary();


Tests should be fully isolated from each other so that if ordering ever changes everything should still work. This, and other post-test teardown logic should live inside of an after that ensures each test starts from the same point.

Perhaps we can navigate to dashboard home if we need to refresh the page and create helpers for setting up a new panel in before?

This is great feedback, thanks! :)

jloleysens · 2021-12-13T11:14:25Z

src/plugins/embeddable/public/lib/attribute_service/attribute_service.tsx

-          resolve({ ...newInput, ...wrappedInput });
+          // Combine input and wrapped input to preserve any passed in explicit Input while ensuring that the
+          // library title ovewrites the original title
+          resolve({ ...newInput, ...wrappedInput, title: newAttributes.title });


nit; This code overall is a little tricksy to follow 😅 it seems a little clearer to me if we did:

const wrappedInput = (await this.wrapAttributes(newAttributes, true, { title: props.newTitle, })) as RefType;

perhaps @Dosant has some input (pun intended) too.

flash1293

VisEditors changes LGTM

LeeDr · 2021-12-13T15:39:11Z

For version labels, v7.16.0 has already shipped and 7.16.1 is probably going to be released today.
It looks like the next release will be 7.17.0 (but always a possibility of a 7.16.2).

kibana-ci · 2021-12-15T00:42:41Z

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`dashboard`	275.1KB	275.4KB	+233.0B
`visualizations`	59.4KB	59.4KB	+32.0B
total			+265.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`dashboard`	65.3KB	65.4KB	+65.0B
`embeddable`	63.8KB	63.9KB	+130.0B
total			+195.0B

History

💚 Build #13152 succeeded 77c622f
💔 Build #13037 failed f99cdf1
💚 Build #13022 succeeded 9b63b69
💚 Build #12966 succeeded 3fcd626
💚 Build #12599 succeeded 84afa07
💛 Build #12481 was flaky 2a475ff

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @Heenawter

@dmlemeshko

* Added special case to panel comparison. * Fixed panel title behaviour when linking/unlinking to/from the library. * Added panel title test suite. * Made the injection of the 'savedSearchId' key conditional on if it is defined when unlinking. * Adjusted use of 'setValue()' based on feedback from @dmlemeshko * Refractor test suite. * Improved code for removal of title on library link.

kibanamachine · 2021-12-17T00:44:59Z

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 120815 or prevent reminders by adding the backport:skip label.

kibanamachine · 2021-12-20T00:54:58Z

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 120815 or prevent reminders by adding the backport:skip label.

kibanamachine · 2021-12-20T16:13:11Z

💔 Backport failed

Status	Branch	Result
❌	8.0	Commit could not be cherrypicked due to conflicts
❌	7.17	Commit could not be cherrypicked due to conflicts

To backport manually run:
node scripts/backport --pr 120815

@dmlemeshko

* Added special case to panel comparison. * Fixed panel title behaviour when linking/unlinking to/from the library. * Added panel title test suite. * Made the injection of the 'savedSearchId' key conditional on if it is defined when unlinking. * Adjusted use of 'setValue()' based on feedback from @dmlemeshko * Refractor test suite. * Improved code for removal of title on library link. # Conflicts: # src/plugins/embeddable/public/lib/attribute_service/attribute_service.tsx

@dmlemeshko

* Added special case to panel comparison. * Fixed panel title behaviour when linking/unlinking to/from the library. * Added panel title test suite. * Made the injection of the 'savedSearchId' key conditional on if it is defined when unlinking. * Adjusted use of 'setValue()' based on feedback from @dmlemeshko * Refractor test suite. * Improved code for removal of title on library link. # Conflicts: # src/plugins/embeddable/public/lib/attribute_service/attribute_service.tsx

@dmlemeshko

* Added special case to panel comparison. * Fixed panel title behaviour when linking/unlinking to/from the library. * Added panel title test suite. * Made the injection of the 'savedSearchId' key conditional on if it is defined when unlinking. * Adjusted use of 'setValue()' based on feedback from @dmlemeshko * Refractor test suite. * Improved code for removal of title on library link. # Conflicts: # src/plugins/embeddable/public/lib/attribute_service/attribute_service.tsx

@dmlemeshko

* Added special case to panel comparison. * Fixed panel title behaviour when linking/unlinking to/from the library. * Added panel title test suite. * Made the injection of the 'savedSearchId' key conditional on if it is defined when unlinking. * Adjusted use of 'setValue()' based on feedback from @dmlemeshko * Refractor test suite. * Improved code for removal of title on library link.

@dmlemeshko

* Added special case to panel comparison. * Fixed panel title behaviour when linking/unlinking to/from the library. * Added panel title test suite. * Made the injection of the 'savedSearchId' key conditional on if it is defined when unlinking. * Adjusted use of 'setValue()' based on feedback from @dmlemeshko * Refractor test suite. * Improved code for removal of title on library link.

@dmlemeshko

* Added special case to panel comparison. * Fixed panel title behaviour when linking/unlinking to/from the library. * Added panel title test suite. * Made the injection of the 'savedSearchId' key conditional on if it is defined when unlinking. * Adjusted use of 'setValue()' based on feedback from @dmlemeshko * Refractor test suite. * Improved code for removal of title on library link. (cherry picked from commit b6013d1) # Conflicts: # src/plugins/embeddable/public/lib/attribute_service/attribute_service.tsx

@dmlemeshko

…124295) * [Dashboard] Fix blank panel save and display issue. (#120815) * Added special case to panel comparison. * Fixed panel title behaviour when linking/unlinking to/from the library. * Added panel title test suite. * Made the injection of the 'savedSearchId' key conditional on if it is defined when unlinking. * Adjusted use of 'setValue()' based on feedback from @dmlemeshko * Refractor test suite. * Improved code for removal of title on library link. (cherry picked from commit b6013d1) # Conflicts: # src/plugins/embeddable/public/lib/attribute_service/attribute_service.tsx * replace lens basic with esarchiver * remove describe.only Co-authored-by: Hannah Mudge <Heenawter@users.noreply.github.com>

Closes #156539 Closes #156544 ## Summary As part of investigating the attached flaky test suite, I realized that the flakiness was because we weren't waiting long enough for a panel to be added and/or removed from the library - so, I added a check to ensure the library notification appears in `saveToLibrary`, and similarly I added a check to ensure that the library notification **disappears** in `unlinkFromLibary`. However, after adding these extra checks, the following test started to fail: https://github.com/elastic/kibana/blob/23a45bde21b36be49a1174b9bde1fc340de67534/x-pack/test/functional/apps/dashboard/group2/panel_titles.ts#L148-L155 Way, way, way back in `8.1`, one of my [first PRs](#120815) was meant to fix some problems with dashboard panel titles - as part of this, I was **supposed** to make sure that, if a by-reference panel is given a custom panel title, the title should remain the same after unlinking (i.e. it should remain as the custom title rather than resetting to the by-reference title). So, I added the above test to verify this behaviour. Turns out, though, that this test had a flaw - because we weren't waiting long enough for the panel to actually be disconnected from the library, this test was only passing because it was grabbing and comparing titles **before** the unlink was complete - so, even though the title actually **was** being reset back to the original library title, this test did not catch this bug. This has been the case since `8.1` when this test was introduced - not sure how it was missed, but we never actually fixed the bug where dashboard panel titles are getting reset when unlinking from the library. So, this PR actually accomplishes two things: 1) It fixes the flakiness of the attached tests by adding the extra library notification checks: <a href="https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2217"><img src="https://user-images.githubusercontent.com/8698078/236044233-8a07aadc-8a55-40f2-9ed2-798a91501f68.png"/></a> 2) It ensures that, if a by-reference panel has a custom title, unlinking it from the library will not impact that title. ### Before https://user-images.githubusercontent.com/8698078/236062484-b1cedc47-cb19-4273-aec7-17d24b55953b.mov ### After https://user-images.githubusercontent.com/8698078/236062862-aace4f09-d007-401a-ba57-b9b74fda0b33.mov ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

Closes elastic#156539 Closes elastic#156544 ## Summary As part of investigating the attached flaky test suite, I realized that the flakiness was because we weren't waiting long enough for a panel to be added and/or removed from the library - so, I added a check to ensure the library notification appears in `saveToLibrary`, and similarly I added a check to ensure that the library notification **disappears** in `unlinkFromLibary`. However, after adding these extra checks, the following test started to fail: https://github.com/elastic/kibana/blob/23a45bde21b36be49a1174b9bde1fc340de67534/x-pack/test/functional/apps/dashboard/group2/panel_titles.ts#L148-L155 Way, way, way back in `8.1`, one of my [first PRs](elastic#120815) was meant to fix some problems with dashboard panel titles - as part of this, I was **supposed** to make sure that, if a by-reference panel is given a custom panel title, the title should remain the same after unlinking (i.e. it should remain as the custom title rather than resetting to the by-reference title). So, I added the above test to verify this behaviour. Turns out, though, that this test had a flaw - because we weren't waiting long enough for the panel to actually be disconnected from the library, this test was only passing because it was grabbing and comparing titles **before** the unlink was complete - so, even though the title actually **was** being reset back to the original library title, this test did not catch this bug. This has been the case since `8.1` when this test was introduced - not sure how it was missed, but we never actually fixed the bug where dashboard panel titles are getting reset when unlinking from the library. So, this PR actually accomplishes two things: 1) It fixes the flakiness of the attached tests by adding the extra library notification checks: <a href="https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2217"><img src="https://user-images.githubusercontent.com/8698078/236044233-8a07aadc-8a55-40f2-9ed2-798a91501f68.png"/></a> 2) It ensures that, if a by-reference panel has a custom title, unlinking it from the library will not impact that title. ### Before https://user-images.githubusercontent.com/8698078/236062484-b1cedc47-cb19-4273-aec7-17d24b55953b.mov ### After https://user-images.githubusercontent.com/8698078/236062862-aace4f09-d007-401a-ba57-b9b74fda0b33.mov ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) (cherry picked from commit ce7ef40)

…#156871) # Backport This will backport the following commits from `main` to `8.8`: - [[Dashboard] Fix "Unlink from library" panel title bug (#156589)](#156589)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport)  Co-authored-by: Hannah Mudge <Heenawter@users.noreply.github.com>

Closes elastic#156539 Closes elastic#156544 ## Summary As part of investigating the attached flaky test suite, I realized that the flakiness was because we weren't waiting long enough for a panel to be added and/or removed from the library - so, I added a check to ensure the library notification appears in `saveToLibrary`, and similarly I added a check to ensure that the library notification **disappears** in `unlinkFromLibary`. However, after adding these extra checks, the following test started to fail: https://github.com/elastic/kibana/blob/23a45bde21b36be49a1174b9bde1fc340de67534/x-pack/test/functional/apps/dashboard/group2/panel_titles.ts#L148-L155 Way, way, way back in `8.1`, one of my [first PRs](elastic#120815) was meant to fix some problems with dashboard panel titles - as part of this, I was **supposed** to make sure that, if a by-reference panel is given a custom panel title, the title should remain the same after unlinking (i.e. it should remain as the custom title rather than resetting to the by-reference title). So, I added the above test to verify this behaviour. Turns out, though, that this test had a flaw - because we weren't waiting long enough for the panel to actually be disconnected from the library, this test was only passing because it was grabbing and comparing titles **before** the unlink was complete - so, even though the title actually **was** being reset back to the original library title, this test did not catch this bug. This has been the case since `8.1` when this test was introduced - not sure how it was missed, but we never actually fixed the bug where dashboard panel titles are getting reset when unlinking from the library. So, this PR actually accomplishes two things: 1) It fixes the flakiness of the attached tests by adding the extra library notification checks: <a href="https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2217"><img src="https://user-images.githubusercontent.com/8698078/236044233-8a07aadc-8a55-40f2-9ed2-798a91501f68.png"/></a> 2) It ensures that, if a by-reference panel has a custom title, unlinking it from the library will not impact that title. ### Before https://user-images.githubusercontent.com/8698078/236062484-b1cedc47-cb19-4273-aec7-17d24b55953b.mov ### After https://user-images.githubusercontent.com/8698078/236062862-aace4f09-d007-401a-ba57-b9b74fda0b33.mov ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

Heenawter added 2 commits December 8, 2021 11:26

Added special case to panel comparison.

e18448e

Fixed panel title behaviour when linking/unlinking to/from the library.

7781d60

Heenawter changed the title ~~Fix blank title save bug 2021 11 18 v2~~ [Dashboard] Fix blank panel save and display issue. Dec 8, 2021

Heenawter self-assigned this Dec 8, 2021

Heenawter added Feature:Dashboard Dashboard related features impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:large Large Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas labels Dec 8, 2021

Heenawter force-pushed the fix-blank-title-save-bug_2021-11-18_v2 branch from 1f4c2fd to 2a475ff Compare December 8, 2021 19:45

Added panel title test suite.

2a475ff

Heenawter added v7.16.0 v8.0.0 v8.1.0 release_note:fix labels Dec 8, 2021

Heenawter force-pushed the fix-blank-title-save-bug_2021-11-18_v2 branch from e142cd7 to 2a475ff Compare December 9, 2021 15:59

Heenawter marked this pull request as ready for review December 9, 2021 16:21

Heenawter requested review from a team as code owners December 9, 2021 16:21

ThomThomson reviewed Dec 9, 2021

View reviewed changes

botelastic bot added the Feature:Embedding Embedding content via iFrame label Dec 9, 2021

Made the injection of the 'savedSearchId' key conditional on if it is…

84afa07

… defined when unlinking.

Heenawter requested a review from a team as a code owner December 9, 2021 20:47

Heenawter commented Dec 9, 2021

View reviewed changes

ThomThomson approved these changes Dec 9, 2021

View reviewed changes

jloleysens approved these changes Dec 13, 2021

View reviewed changes

flash1293 approved these changes Dec 13, 2021

View reviewed changes

Heenawter force-pushed the fix-blank-title-save-bug_2021-11-18_v2 branch from f99cdf1 to 77c622f Compare December 14, 2021 15:36

Improved code for removal of title on library link.

12bae8b

Heenawter enabled auto-merge (squash) December 14, 2021 23:23

Heenawter merged commit b6013d1 into elastic:main Dec 15, 2021

kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Dec 17, 2021

Heenawter added auto-backport Deprecated - use backport:version if exact versions are needed and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Dec 20, 2021

Heenawter mentioned this pull request Dec 20, 2021

[8.0] [Dashboard] Fix blank panel save and display issue. (#120815) #121660

Merged

Heenawter mentioned this pull request Dec 20, 2021

[7.17] [Dashboard] Fix blank panel save and display issue. (#120815) #121661

Closed

Heenawter deleted the fix-blank-title-save-bug_2021-11-18_v2 branch December 20, 2021 17:54

ThomThomson removed the v7.17.0 label Jan 12, 2022

Heenawter mentioned this pull request Jan 12, 2022

Kibana triggers discard changes warning on dashboards if user tries to show/hide panel titles for panels with saved objects from the library after save #122868

Closed

ThomThomson mentioned this pull request Feb 1, 2022

[7.17] [Dashboard] Fix blank panel save and display issue. (#120815) #124295

Merged

Heenawter mentioned this pull request May 3, 2023

[Dashboard] Fix "Unlink from library" panel title bug #156589

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Dashboard] Fix blank panel save and display issue. #120815

[Dashboard] Fix blank panel save and display issue. #120815

Heenawter commented Dec 8, 2021 •

edited

Loading

elasticmachine commented Dec 9, 2021

ThomThomson left a comment •

edited

Loading

ThomThomson Dec 9, 2021

ThomThomson Dec 9, 2021

Heenawter Dec 9, 2021

ThomThomson Dec 9, 2021

Heenawter Dec 9, 2021

Heenawter Dec 9, 2021

Heenawter commented Dec 9, 2021

Visualize unlink issue

ThomThomson left a comment

jloleysens left a comment •

edited

Loading

jloleysens Dec 13, 2021 •

edited

Loading

Heenawter Dec 13, 2021

jloleysens Dec 13, 2021 •

edited

Loading

flash1293 left a comment

LeeDr commented Dec 13, 2021

kibana-ci commented Dec 15, 2021

kibanamachine commented Dec 17, 2021

kibanamachine commented Dec 20, 2021

kibanamachine commented Dec 20, 2021

		// unlink so that panel goes back to by value for next tests
		await dashboardPanelActions.unlinkFromLibary();

[Dashboard] Fix blank panel save and display issue. #120815

[Dashboard] Fix blank panel save and display issue. #120815

Conversation

Heenawter commented Dec 8, 2021 • edited Loading

Summary

Checklist

For maintainers

elasticmachine commented Dec 9, 2021

ThomThomson left a comment • edited Loading

Choose a reason for hiding this comment

Functional tests

I tested this locally by:

Visualize unlink issue

ThomThomson Dec 9, 2021

Choose a reason for hiding this comment

ThomThomson Dec 9, 2021

Choose a reason for hiding this comment

Heenawter Dec 9, 2021

Choose a reason for hiding this comment

ThomThomson Dec 9, 2021

Choose a reason for hiding this comment

Heenawter Dec 9, 2021

Choose a reason for hiding this comment

Heenawter Dec 9, 2021

Choose a reason for hiding this comment

Heenawter commented Dec 9, 2021

Visualize unlink issue

ThomThomson left a comment

Choose a reason for hiding this comment

jloleysens left a comment • edited Loading

Choose a reason for hiding this comment

jloleysens Dec 13, 2021 • edited Loading

Choose a reason for hiding this comment

Heenawter Dec 13, 2021

Choose a reason for hiding this comment

jloleysens Dec 13, 2021 • edited Loading

Choose a reason for hiding this comment

flash1293 left a comment

Choose a reason for hiding this comment

LeeDr commented Dec 13, 2021

kibana-ci commented Dec 15, 2021

💚 Build Succeeded

Metrics [docs]

Async chunks

Page load bundle

History

kibanamachine commented Dec 17, 2021

kibanamachine commented Dec 20, 2021

kibanamachine commented Dec 20, 2021

💔 Backport failed

Heenawter commented Dec 8, 2021 •

edited

Loading

ThomThomson left a comment •

edited

Loading

jloleysens left a comment •

edited

Loading

jloleysens Dec 13, 2021 •

edited

Loading

jloleysens Dec 13, 2021 •

edited

Loading