Update embeddable.tsx

make sure conflict error logic will execute
elastic · Dec 1, 2021 · f3d9991 · f3d9991
1 parent 0f21c6f
commit f3d9991
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/x-pack/plugins/lens/public/embeddable/embeddable.tsx b/x-pack/plugins/lens/public/embeddable/embeddable.tsx
@@ -284,10 +284,10 @@ export class Embeddable
   }
 
   private maybeAddConflictError(
-    errors: ErrorMessage[],
+    errors?: ErrorMessage[],
     sharingSavedObjectProps?: SharingSavedObjectProps
   ) {
-    const ret = [...errors];
+    const ret = [...(errors || [])];
 
     if (sharingSavedObjectProps?.outcome === 'conflict' && !!this.deps.spaces) {
       ret.push({
@@ -303,7 +303,7 @@ export class Embeddable
       });
     }
 
-    return ret;
+    return ret?.length ? ret : undefined;
   }
 
   async initializeSavedVis(input: LensEmbeddableInput) {
@@ -330,7 +330,7 @@ export class Embeddable
       this.deps.documentToExpression
     );
     this.expression = expression;
-    this.errors = errors && this.maybeAddConflictError(errors, metaInfo?.sharingSavedObjectProps);
+    this.errors = this.maybeAddConflictError(errors, metaInfo?.sharingSavedObjectProps);
 
     if (this.errors) {
       this.logError('validation');