Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.16] [Dashboard] Move Sharing Saved Object Props into Meta Object (#119913) #120177

Merged
merged 1 commit into from
Dec 1, 2021

Conversation

ThomThomson
Copy link
Contributor

Backports the following commits to 7.16:

…#119913)

Co-authored-by: Anton Dosov <dosantappdev@gmail.com>
Co-authored-by: Marta Bondyra <marta.bondyra@gmail.com>
# Conflicts:
#	x-pack/plugins/lens/public/embeddable/embeddable.tsx
@ThomThomson ThomThomson enabled auto-merge (squash) December 1, 2021 21:22
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dashboard 141.4KB 141.4KB +11.0B
lens 1.0MB 1.0MB +105.0B
maps 2.7MB 2.7MB +78.0B
total +194.0B

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
embeddable 3 4 +1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
embeddable 68.7KB 68.7KB +38.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@ThomThomson ThomThomson merged commit d998df5 into elastic:7.16 Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants