Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to using Adopt JenkinsFiles for Test #1450

Closed
AdamBrousseau opened this issue Mar 15, 2018 · 2 comments
Closed

Switch to using Adopt JenkinsFiles for Test #1450

AdamBrousseau opened this issue Mar 15, 2018 · 2 comments
Labels
comp:build

Comments

@AdamBrousseau
Copy link
Contributor

AdamBrousseau commented Mar 15, 2018 •
edited
Loading

Currently we have our own JeknkinsFiles for Test purposes (also here).

We should be pulling the Test Jenkins files from AdoptOpenJDK/openjdk-tests. This will benefit us by not having to maintain our own "copies"

This work will require some help and coordination form the test team so we can have a smooth transition.

This may cause us to break out our PR builds into several builds (just like the nightly flow). There are a few issues with this.

  1. Moving the SDK around can be slow on some machines (SDK archiving is very slow on zLinux machines #659)
  2. GH-PR-Trigger plugin only works with "1-build". Currently the PR builds run compile & test in a single build/job. The top-level job would be responsible for communicating with GitHub. We could switch to using "Build Status Messages" (see example) instead of the simple "Test result one liner" (which is inaccurate Aborted pull request testing contains confusing message #981).

also related #1409 #1779 #2037
This was referenced Mar 15, 2018
Merged
Closed
@AdamBrousseau AdamBrousseau mentioned this issue Mar 27, 2018
Closed
3 tasks
@AdamBrousseau AdamBrousseau mentioned this issue Apr 19, 2018
Closed
@llxia llxia mentioned this issue Apr 26, 2018
Closed
@AdamBrousseau AdamBrousseau mentioned this issue May 11, 2018
Closed
4 tasks
@AdamBrousseau AdamBrousseau mentioned this issue Jun 6, 2018
Merged
@AdamBrousseau
Copy link
Contributor Author

AdamBrousseau commented Jun 14, 2018 •
edited
Loading

Partially resolved via #2037

AdamBrousseau added a commit to AdamBrousseau/openj9 that referenced this issue Jun 16, 2018
@AdamBrousseau
Remove duplicate functional testing
caf3117 
- Remove old style sanity & extended (functional)
  from nightly builds.
- Machine resources are limited and new style (Adopt Pipelines)
  functional testing is stable, so this removes the
  old style (OpenJ9 pipelines)

Related eclipse-openj9#2117
Issue eclipse-openj9#1450
[skip ci]

Signed-off-by: Adam Brousseau <adam.brousseau88@gmail.com>
This was referenced Jun 16, 2018
Merged
Closed
AdamBrousseau added a commit to AdamBrousseau/openj9 that referenced this issue Aug 16, 2018
@AdamBrousseau
Run sanity.functional in the OMR build
c170746 
- Switch to using jobs that use Adopt test scripts
- All platforms are now supported (including win)

[skip ci]
Issue eclipse-openj9#1450 eclipse-openj9#1779 adoptium/aqa-tests#506

Signed-off-by: Adam Brousseau <adam.brousseau88@gmail.com>
@AdamBrousseau AdamBrousseau mentioned this issue Aug 16, 2018
Merged
AdamBrousseau added a commit to AdamBrousseau/openj9 that referenced this issue Aug 16, 2018
@AdamBrousseau
Remove obsolete test paths for non-Adopt test builds
15ba064 
- We no longer run JDK9 so we can remove this case.
  If we need to run 9 at some point in the future, test
  jobs will need to be created using the Adopt test scripts.
- Windows is now supported using the Adopt test scripts

[skip ci]
Issue eclipse-openj9#1450 eclipse-openj9#1779 adoptium/aqa-tests#506

Signed-off-by: Adam Brousseau <adam.brousseau88@gmail.com>
@AdamBrousseau AdamBrousseau mentioned this issue Aug 16, 2018
Merged
@AdamBrousseau AdamBrousseau mentioned this issue Aug 28, 2018
Closed
@AdamBrousseau AdamBrousseau mentioned this issue Aug 29, 2018
Merged
@AdamBrousseau
Copy link
Contributor Author

#2728 should resolve this

@AdamBrousseau AdamBrousseau mentioned this issue Nov 19, 2018
Merged
@AdamBrousseau AdamBrousseau mentioned this issue Dec 12, 2018
Merged
AdamBrousseau added a commit to AdamBrousseau/openj9 that referenced this issue Dec 18, 2018
@AdamBrousseau
Set job variables for PR builds based on PR case not build case
0ae098f 
- Remove support for test cases since we no longer
  use our test pipelines (eclipse-openj9#1450)
- Set job variables for PullRequest builds based on PR case
  not build case. This avoids setting job properties for PR builds
  which removes the GH trigger configuration
- Remove test node labels as these are no longer in use

[skip ci]

Signed-off-by: Adam Brousseau <adam.brousseau88@gmail.com>
Yuehan-Lin pushed a commit to Yuehan-Lin/openj9 that referenced this issue Feb 5, 2019
@AdamBrousseau @Yuehan-Lin
Set job variables for PR builds based on PR case not build case
c158fa9 
- Remove support for test cases since we no longer
  use our test pipelines (eclipse-openj9#1450)
- Set job variables for PullRequest builds based on PR case
  not build case. This avoids setting job properties for PR builds
  which removes the GH trigger configuration
- Remove test node labels as these are no longer in use

[skip ci]

Signed-off-by: Adam Brousseau <adam.brousseau88@gmail.com>
AdamBrousseau added a commit to AdamBrousseau/openj9 that referenced this issue Feb 14, 2019
@AdamBrousseau
No longer pass VENDOR variables to Test jobs
6455e29 
- Adopt test pipelines do not use these variables.
- These were originally used when we had our own test jobs
- Cleanup dead code

[skip ci]
Related eclipse-openj9#1450

Signed-off-by: Adam Brousseau <adam.brousseau88@gmail.com>
@dsouzai dsouzai mentioned this issue Feb 26, 2019
Closed
3 tasks
AdamBrousseau added a commit to AdamBrousseau/openj9 that referenced this issue Mar 25, 2019
@AdamBrousseau
No longer pass VENDOR variables to Test jobs
4364590 
- Adopt test pipelines do not use these variables.
- These were originally used when we had our own test jobs
- Cleanup dead code

[skip ci]
Related eclipse-openj9#1450

Signed-off-by: Adam Brousseau <adam.brousseau88@gmail.com>
AdamBrousseau added a commit to AdamBrousseau/openj9 that referenced this issue Jun 11, 2019
@AdamBrousseau
Remove obsolete pipeline code
a0819cf 
- We no longer run our own testing so this
  code is no longer needed.
- Remove PullRequest pipelines as they are no longer in use.
- Combine 'build' and 'pullRequest' variable setup cases
  as they are identical.
- Also remove temp reverse spec map used prior to eclipse-openj9#2836.

Related eclipse-openj9#1450
Depends eclipse-openj9#2728 eclipse-openj9#2638 eclipse-openj9#2467 eclipse-openj9#2272 eclipse-openj9#2836 eclipse-openj9#4443
[skip ci]
Signed-off-by: Adam Brousseau <adam.brousseau88@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
comp:build
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AdamBrousseau @pshipton