Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No longer pass VENDOR variables to Test jobs #3738

Merged
merged 1 commit into from
Mar 26, 2019
Merged

No longer pass VENDOR variables to Test jobs #3738

merged 1 commit into from
Mar 26, 2019

Conversation

AdamBrousseau
Copy link
Contributor

  • Adopt test pipelines do not use these variables.
  • These were originally used when we had our own test jobs
  • Cleanup dead code

[skip ci]
Related #1450

Signed-off-by: Adam Brousseau adam.brousseau88@gmail.com

@AdamBrousseau
Copy link
Contributor Author

AdamBrousseau commented Nov 19, 2018 •
edited
Loading

@vsebe for review.
Unless the test team thinks they could use these in the *near future? Which I think they could and I have a few ideas in mind we can discuss.
cc @smlambert @llxia

Edit: Once we are done discussing I should test this change before we merge.

@AdamBrousseau AdamBrousseau changed the title No longer pass VENDOR variables to Test jobs WIP: No longer pass VENDOR variables to Test jobs Nov 19, 2018
@AdamBrousseau AdamBrousseau mentioned this pull request Nov 19, 2018
Merged
@AdamBrousseau AdamBrousseau changed the title WIP: No longer pass VENDOR variables to Test jobs No longer pass VENDOR variables to Test jobs Feb 12, 2019
@AdamBrousseau
Copy link
Contributor Author

@llxia Please confirm the Test pipelines do not use these variables.

@AdamBrousseau
Copy link
Contributor Author

I'll do a test build with and without Artifactory before we merge this.

@llxia
Copy link
Contributor

llxia commented Feb 13, 2019

If I am not wrong, these variables were created for getting test material from other repos (i.e., internal test repos). Are we using the same script for internal builds? If so, we may still need these for internal builds.

@AdamBrousseau
Copy link
Contributor Author

The variables I am removing are used for Vendor variable file

VARIABLE_FILE
VENDOR_CREDENTIALS_ID
VENDOR_REPO
VENDOR_BRANCH

The variables you are thinking of are used for Vendor tests:

VENDOR_TEST_REPOS
VENDOR_TEST_BRANCHES
VENDOR_TEST_SHAS
VENDOR_TEST_DIRS
USER_CREDENTIALS_ID

I think we used them in our test jobs before we switched to Adopt test pipelines in order to set up our envs.

@llxia
Copy link
Contributor

llxia commented Feb 13, 2019

I'll do a test build with and without Artifactory before we merge this.

Please paste the test build link. If it passes, I will merge this PR. Thanks.

@AdamBrousseau
No longer pass VENDOR variables to Test jobs
4364590 
- Adopt test pipelines do not use these variables.
- These were originally used when we had our own test jobs
- Cleanup dead code

[skip ci]
Related eclipse-openj9#1450

Signed-off-by: Adam Brousseau <adam.brousseau88@gmail.com>
@AdamBrousseau
Copy link
Contributor Author

@llxia better late than never :)
https://ci.eclipse.org/openj9/job/Pipeline-Build-Test-JDK11-linux_x86-64_cmprssptrs/707

@llxia llxia merged commit 4d3df00 into eclipse-openj9:master Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@llxia llxia llxia approved these changes

Assignees
No one assigned
Labels
comp:build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AdamBrousseau @llxia @pshipton