Remove obsolete pipeline code #2743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdamBrousseau
force-pushed
the
remove_old_test_code
branch
2 times, most recently
from
6f3b780
to
c1f3dd2
Compare
AdamBrousseau
force-pushed
the
remove_old_test_code
branch
from
c1f3dd2
to
5e58926
Compare
AdamBrousseau
force-pushed
the
remove_old_test_code
branch
2 times, most recently
from
fdb82f3
to
cb09130
Compare
AdamBrousseau
force-pushed
the
remove_old_test_code
branch
2 times, most recently
from
b3d2f45
to
ec3bae4
Compare
AdamBrousseau
changed the title
|
jenkins test sanity.functional plinux jdk11 |
AdamBrousseau
changed the title
|
@vsebe for review |
vsebe
suggested changes
Jun 11, 2019
| /* | ||
| * Set the JDK_FOLDER variable with the value provided in the variables file. | ||
| */ | ||
| def set_jdk_folder() { |
There was a problem hiding this comment.
set_jdk_folder() is still required by the build() method - see stage('Java Version'){...} in common/build script
There was a problem hiding this comment.
Good catch. Odd I thought I had done a PR build before but it clearly fails now. Going to try * in the path and see if that works.
There was a problem hiding this comment.
That won't work. Added these functions back in.
| /* | ||
| * Set the RELEASE variable with the value provided in the variables file. | ||
| */ | ||
| def set_release() { |
There was a problem hiding this comment.
this method is still required - see stage('Java Version'){...} in common/build script
| @@ -385,8 +371,6 @@ def set_build_variables() { | |||
| BOOT_JDK = get_value(VARIABLES."${SPEC}".boot_jdk, SDK_VERSION) | |||
| FREEMARKER = VARIABLES."${SPEC}".freemarker | |||
| OPENJDK_REFERENCE_REPO = VARIABLES."${SPEC}".openjdk_reference_repo | |||
| set_release() | |||
| set_jdk_folder() | |||
There was a problem hiding this comment.
see comments above (still required - see stage('Java Version'){...} in common/build script)
|
jenkins compile plinux jdk11 |
- We no longer run our own testing so this code is no longer needed. - Remove PullRequest pipelines as they are no longer in use. - Combine 'build' and 'pullRequest' variable setup cases as they are identical. - Also remove temp reverse spec map used prior to eclipse-openj9#2836. Related eclipse-openj9#1450 Depends eclipse-openj9#2728 eclipse-openj9#2638 eclipse-openj9#2467 eclipse-openj9#2272 eclipse-openj9#2836 eclipse-openj9#4443 [skip ci] Signed-off-by: Adam Brousseau <adam.brousseau88@gmail.com>
AdamBrousseau
force-pushed
the
remove_old_test_code
branch
from
ec3bae4
to
a0819cf
Compare
|
jenkins compile plinux jdk11 |
pshipton
approved these changes
Jun 21, 2019
AdamBrousseau
added a commit
to AdamBrousseau/openj9
that referenced
this pull request
Jun 28, 2019
- Add .groovy extensions to all pipeline files. Allows for automatic syntax highlighting in editors. - Move Build pipeline to pipeline folder - Update all references with new file names and locations [skip ci] Depends eclipse-openj9#2743 Signed-off-by: Adam Brousseau <adam.brousseau88@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
code is no longer needed.
as they are identical.
Related #1450
Depends
#2728#2638#2467#2272#2836#4443[skip ci]
Signed-off-by: Adam Brousseau adam.brousseau88@gmail.com