Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Jenkins Build files #1897

Closed
2 of 4 tasks
AdamBrousseau opened this issue May 11, 2018 · 2 comments
Closed
2 of 4 tasks

Refactor Jenkins Build files #1897

AdamBrousseau opened this issue May 11, 2018 · 2 comments

Comments

@AdamBrousseau
Copy link
Contributor

AdamBrousseau commented May 11, 2018

Currently, we have too much duplication between our top level Jenkins build files. We need to come up with a solution to refactor these so we can reduce or eliminate this repetitive code.

Files in question:

One proposal is to parse the build name to set the SPEC and SDK_VERISON. Prototyped in #1396
Another option is to pass the SPEC and SDK_VERSION as build parameters.

The Build* and PullRequest-Compile* files are now identical (except for an extra timeout). So we could at least eliminate all the PullRequest-Compile files. However this would be an exception to the current convention. A larger refactor may make this irrelevant.

@AdamBrousseau
Copy link
Contributor Author

I think I'm ok with passing them in as build parameters if we use choice params and only give one choice. That way, they can't easily be changed on the fly. Although, I'll have to try it out because when we call a Build job from an upstream pipeline, we don't pass SPEC and SDK. So I'm not sure if the defaults will be picked up. I recall a few years ago that the defaults would get ignored if you passed params and didn't pass the expected ones.

@AdamBrousseau
Copy link
Contributor Author

#2093

vsebe added a commit to vsebe/openj9 that referenced this issue Jun 14, 2018
- add Jenkins file for build and test any platform
- add pipeline wrapper for any platform
These Jenkins files allow the OpenJ9 extensions build and test for any
supported version and platform. New platforms can be added easily
without creating new Jenkins files only parameterized Jenkins jobs.
Pipeline-Build-Test-Any-Platform could also replace the all of the
Pipeline-Build-Test-JDK<version>-<platform> wrappers.
Build-Test-Any-Platform could replace all of the
Build-JDK<version>-<platform>, Test-Sanity-JDK<version>-<platform>,
Test-Extended-JDK<version>-<platform> and
PullRequest-*-JDK<version>-<platform> scripts.

Fixes eclipse-openj9#1897

[ci skip]

Signed-off-by: Violeta Sebe <vsebe@ca.ibm.com>
AdamBrousseau added a commit to AdamBrousseau/openj9 that referenced this issue Aug 29, 2018
- Pipeline* files
- Build* files
- Test* files
- These have been replaced by Pipeline-Build-Test-Any-Platform
  and Build-Test-Any-Platform and Adopt's openjdk-tests

[skip ci]
Issue eclipse-openj9#1897

Signed-off-by: Adam Brousseau <adam.brousseau88@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants