Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(start_planner): allow lane departure check override #6512

Conversation

danielsanchezaran
Copy link
Contributor

@danielsanchezaran danielsanchezaran commented Feb 29, 2024

Description

Add a parameter: allow_check_shift_path_lane_departure_override to disable lane departure check IF the ego vehicle's original pose happens to not be fully inside a lanelet(s).

Note, some refactoring is also done.

NOTE: requires launch changes-> autowarefoundation/autoware_launch#893

Tests performed

PSim tests. Example video:

cap-.2024-02-29-10-27-22.mp4

the above video shows the inclusion of the requested feature, First, I show how the start planner works if lane departure check is disabled, 2nd I enable lane departure check but also the new option to override lane departure if partly outside of lane when starting, finally I turn off the override option and the lane departure check is executed (and no path is generated) Is this the expected behavior?

Evaluator tests: TIER IV INTERNAL LINK -> No degradation related to start planner

Effects on system behavior

If enabled (default is false) this parameters disables lane departure check if the initial ego pose is already protruding outside lanelets.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added component:planning Route planning, decision-making, and navigation. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) labels Feb 29, 2024
@danielsanchezaran danielsanchezaran force-pushed the feat/allow_lane_departure_check_override branch from 6840e85 to 2df8ba0 Compare February 29, 2024 02:29
@github-actions github-actions bot removed component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) labels Feb 29, 2024
@danielsanchezaran danielsanchezaran self-assigned this Feb 29, 2024
@github-actions github-actions bot added the type:documentation Creating or refining documentation. (auto-assigned) label Feb 29, 2024
@danielsanchezaran danielsanchezaran marked this pull request as ready for review February 29, 2024 03:53
@danielsanchezaran danielsanchezaran added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Feb 29, 2024
@danielsanchezaran danielsanchezaran force-pushed the feat/allow_lane_departure_check_override branch from 4a0f3da to 7fefab8 Compare February 29, 2024 03:54
Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks so nice!
Thank you so much for quick work!!!!!

@danielsanchezaran danielsanchezaran force-pushed the feat/allow_lane_departure_check_override branch 3 times, most recently from ebb4e3d to 4fe39f0 Compare February 29, 2024 07:07
Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
@danielsanchezaran danielsanchezaran force-pushed the feat/allow_lane_departure_check_override branch from 4fe39f0 to 57c7883 Compare February 29, 2024 08:57
Copy link

codecov bot commented Feb 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 73 lines in your changes are missing coverage. Please review.

Project coverage is 14.80%. Comparing base (a88a428) to head (57c7883).
Report is 7 commits behind head on main.

Files Patch % Lines
..._start_planner_module/src/start_planner_module.cpp 0.00% 55 Missing ⚠️
...r_path_start_planner_module/src/shift_pull_out.cpp 0.00% 8 Missing ⚠️
...path_start_planner_module/start_planner_module.hpp 0.00% 5 Missing ⚠️
...behavior_path_start_planner_module/src/manager.cpp 0.00% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6512   +/-   ##
=======================================
  Coverage   14.80%   14.80%           
=======================================
  Files        1917     1917           
  Lines      131915   131878   -37     
  Branches    39202    39195    -7     
=======================================
- Hits        19524    19523    -1     
+ Misses      90609    90573   -36     
  Partials    21782    21782           
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 14.81% <ø> (+0.01%) ⬆️ Carriedforward from a88a428

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielsanchezaran danielsanchezaran merged commit c36e2ef into autowarefoundation:main Feb 29, 2024
20 of 22 checks passed
@danielsanchezaran danielsanchezaran deleted the feat/allow_lane_departure_check_override branch February 29, 2024 09:26
danielsanchezaran added a commit to tier4/autoware.universe that referenced this pull request Mar 4, 2024
…ndation#6512)

* small refactor

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* another refactor

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* further refactoring

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* add param to override lane_departure_check when starting outside lane

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* update documentation

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

---------

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
shmpwk added a commit to tier4/autoware.universe that referenced this pull request Mar 5, 2024
* feat(start_planner): allow lane departure check override (autowarefoundation#6512)

* small refactor

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* another refactor

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* further refactoring

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* add param to override lane_departure_check when starting outside lane

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* update documentation

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

---------

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* eliminate merge conflict problems

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* Update planning/behavior_path_start_planner_module/src/manager.cpp

---------

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Co-authored-by: Shumpei Wakabayashi <42209144+shmpwk@users.noreply.github.com>
HansRobo pushed a commit that referenced this pull request Mar 12, 2024
* small refactor

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* another refactor

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* further refactoring

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* add param to override lane_departure_check when starting outside lane

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* update documentation

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

---------

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
kaigohirao pushed a commit to kaigohirao/autoware.universe that referenced this pull request Mar 22, 2024
…ndation#6512)

* small refactor

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* another refactor

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* further refactoring

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* add param to override lane_departure_check when starting outside lane

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* update documentation

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

---------

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Signed-off-by: kaigohirao <kaigo.hirao@proxima-ai-tech.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…ndation#6512)

* small refactor

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* another refactor

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* further refactoring

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* add param to override lane_departure_check when starting outside lane

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* update documentation

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

---------

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
danielsanchezaran added a commit to tier4/autoware.universe that referenced this pull request Jun 3, 2024
…ndation#6512)

* small refactor

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* another refactor

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* further refactoring

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* add param to override lane_departure_check when starting outside lane

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* update documentation

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

---------

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants