Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(start_planner): override lane departure check #1169

Merged

Conversation

danielsanchezaran
Copy link

Description

Original PR: #1165
Ticket: https://tier4.atlassian.net/browse/RT1-5046

Related links

Tests performed

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

danielsanchezaran and others added 2 commits March 4, 2024 14:47
…ndation#6512)

* small refactor

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* another refactor

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* further refactoring

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* add param to override lane_departure_check when starting outside lane

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* update documentation

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

---------

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
@danielsanchezaran danielsanchezaran marked this pull request as ready for review March 4, 2024 06:14
@shmpwk shmpwk deleted the branch beta/v0.20.1.4 March 5, 2024 08:37
@shmpwk shmpwk closed this Mar 5, 2024
@shmpwk shmpwk reopened this Mar 5, 2024
@shmpwk shmpwk changed the base branch from beta/v0.20.1.2 to beta/v0.20.1.4 March 5, 2024 09:51
Copy link
Collaborator

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shmpwk shmpwk merged commit a2d7c2b into beta/v0.20.1.4 Mar 5, 2024
13 of 14 checks passed
@shmpwk shmpwk deleted the cherry-pick/v0.44.3.0-override-lane-departure-check branch March 5, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants