Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(start_planner): allow lane departure check override #893

Conversation

danielsanchezaran
Copy link
Contributor

Description

Add necessary change for autowarefoundation/autoware.universe#6512

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@danielsanchezaran danielsanchezaran force-pushed the feat/allow_lane_departure_check_override branch from 11e1834 to 0d2df1e Compare February 29, 2024 03:16
Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

@danielsanchezaran danielsanchezaran merged commit c15583e into autowarefoundation:main Feb 29, 2024
9 of 10 checks passed
@danielsanchezaran danielsanchezaran deleted the feat/allow_lane_departure_check_override branch February 29, 2024 09:26
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request Apr 8, 2024
…n#796)

* feat(start_planner): allow lane departure check override (autowarefoundation#893)

new param added

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* set lane departure check as true by default

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* fix changed value

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* fix repeated value

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

---------

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
yuki-takagi-66 pushed a commit to tier4/autoware_launch that referenced this pull request Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants