feat(behavior_velocity_planner_common): add objects_of_interest_marker_intereface to behavior_velocity_planner #5875

rej55 · 2023-12-14T10:35:47Z

Description

Apply objects_of_interest_marker_interface to behavior_velocity_planner.
Furthermore, apply to behavior_velocity_no_stopping_area_module as example.

Tests performed

TIER IV INTERNAL TEST

planning simulator

If vehicle is stuck:

If vehicle is not stuck:

Notes for reviewers

Interface changes

See #5564

Effects on system behavior

Objects of interest marker data can be shown.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

I've confirmed the contribution guidelines.
The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

The PR follows the pull request guidelines.
The PR has been properly tested.
The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

There are no open discussions or they are tracked via tickets.
The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

…r_intereface to behavior_velocity_planner Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>

…ts of interest marker Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>

kosuke55

LGTM!

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>

codecov · 2023-12-14T11:34:48Z

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (3d40702) 15.34% compared to head (3cb3bde) 15.34%.
Report is 4 commits behind head on main.

Files	Patch %	Lines
...city_planner_common/src/scene_module_interface.cpp	60.00%	1 Missing and 3 partials ⚠️
...topping_area_module/src/scene_no_stopping_area.cpp	0.00%	2 Missing ⚠️
...velocity_planner_common/scene_module_interface.hpp	50.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #5875   +/-   ##
=======================================
  Coverage   15.34%   15.34%           
=======================================
  Files        1743     1743           
  Lines      119950   119963   +13     
  Branches    36480    36485    +5     
=======================================
+ Hits        18401    18408    +7     
- Misses      80963    80967    +4     
- Partials    20586    20588    +2

Flag	Coverage Δ		*Carryforward flag
differential	`12.33% <50.00%> (?)`
total	`15.34% <ø> (+<0.01%)`	⬆️	Carriedforward from 3d40702

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…r_intereface to behavior_velocity_planner (autowarefoundation#5875) * feat(behavior_velocity_planner_common): add objects_of_interest_marker_intereface to behavior_velocity_planner Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com> * fix(behavior_velocity_planner_common): add functions to publish objects of interest marker Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com> * feat(no_stopping_area): insert object data Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com> * refactor(behavior_velocity_planner_common): rename function Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com> --------- Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>

…r_intereface to behavior_velocity_planner (autowarefoundation#5875) * feat(behavior_velocity_planner_common): add objects_of_interest_marker_intereface to behavior_velocity_planner Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com> * fix(behavior_velocity_planner_common): add functions to publish objects of interest marker Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com> * feat(no_stopping_area): insert object data Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com> * refactor(behavior_velocity_planner_common): rename function Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com> --------- Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com> Signed-off-by: karishma <karishma@interpl.ai>

…r_intereface to behavior_velocity_planner (autowarefoundation#5875) * feat(behavior_velocity_planner_common): add objects_of_interest_marker_intereface to behavior_velocity_planner Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com> * fix(behavior_velocity_planner_common): add functions to publish objects of interest marker Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com> * feat(no_stopping_area): insert object data Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com> * refactor(behavior_velocity_planner_common): rename function Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com> --------- Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>

rej55 added 3 commits December 14, 2023 13:33

feat(behavior_velocity_planner_common): add objects_of_interest_marke…

366667f

…r_intereface to behavior_velocity_planner Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>

fix(behavior_velocity_planner_common): add functions to publish objec…

09e3ead

…ts of interest marker Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>

feat(no_stopping_area): insert object data

f3a594f

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>

rej55 requested review from isamu-takagi, soblin, shmpwk, tkimura4 and kosuke55 as code owners December 14, 2023 10:35

github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Dec 14, 2023

rej55 added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 14, 2023

kosuke55 approved these changes Dec 14, 2023

View reviewed changes

refactor(behavior_velocity_planner_common): rename function

3cb3bde

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>

rej55 mentioned this pull request Dec 14, 2023

feat(rviz_config): add objects of interest marker autowarefoundation/autoware_launch#738

Merged

7 tasks

rej55 assigned soblin Dec 15, 2023

soblin approved these changes Dec 15, 2023

View reviewed changes

rej55 merged commit 1f82854 into autowarefoundation:main Dec 15, 2023
23 of 24 checks passed

rej55 deleted the feat/objects_of_interest_marker_for_bvp branch December 15, 2023 00:42

tier4-autoware-public-bot bot mentioned this pull request Dec 20, 2023

chore: sync upstream tier4/autoware.universe#1078

Merged

yuki-takagi-66 mentioned this pull request Dec 26, 2023

feat(crosswalk): add interset makers #5967

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(behavior_velocity_planner_common): add objects_of_interest_marker_intereface to behavior_velocity_planner #5875

feat(behavior_velocity_planner_common): add objects_of_interest_marker_intereface to behavior_velocity_planner #5875

rej55 commented Dec 14, 2023

kosuke55 left a comment

codecov bot commented Dec 14, 2023 •

edited

Loading

feat(behavior_velocity_planner_common): add objects_of_interest_marker_intereface to behavior_velocity_planner #5875

feat(behavior_velocity_planner_common): add objects_of_interest_marker_intereface to behavior_velocity_planner #5875

Conversation

rej55 commented Dec 14, 2023

Description

Related links

Tests performed

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

In-review checklist for the PR reviewers

Post-review checklist for the PR author

kosuke55 left a comment

Choose a reason for hiding this comment

codecov bot commented Dec 14, 2023 • edited Loading

Codecov Report

codecov bot commented Dec 14, 2023 •

edited

Loading