Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(objects_of_interest_marker_interface): add objects of interest marker interface #5564

Merged

Conversation

rej55
Copy link
Contributor

@rej55 rej55 commented Nov 13, 2023

Description

To visualize what objects planning modules interest, I add an interface to visualize interest objects.

Furthermore, I apply this interface to lane change module temporary.
Applying to other modules and commonalize is future work.

File structure:

  • planning/interest_objects_marker_interface
    • include
      • coloring.hpp
        • Coloring utilities
      • interest_objects_marker_interface.hpp
        • Main class
      • marker_data.hpp
        • Data definitions for marker visualization
      • marker_utils.hpp
        • Utilities to create marker
    • src
      • coloring.cpp
      • interest_objects_marker_interface.cpp
      • marker_data.cpp
      • marker_utils.cpp
    • CMakeLists.txt
    • package.xml
    • README.md

Related links

Tests performed

TIER IV INTERNAL TEST

Tested in planning simulator.

Screencast.from.2023.11.21.17.19.17.webm

Notes for reviewers

Interface changes

Topics for visualizing interest objects are added.

/planning/debug/interest_objects_marker/**

In this PR, lane change module is only added.

Effects on system behavior

We can view the interest objects for planning modules.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Nov 13, 2023
@rej55 rej55 force-pushed the feat/interest_objects_visualization branch 3 times, most recently from 2dea793 to e09fc98 Compare November 21, 2023 02:12
@rej55 rej55 marked this pull request as ready for review November 21, 2023 08:30
@rej55 rej55 force-pushed the feat/interest_objects_visualization branch from a85f02d to 1172566 Compare November 21, 2023 08:48
…interface

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
…tions

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
@rej55 rej55 force-pushed the feat/interest_objects_visualization branch from 14cd394 to 1d5545f Compare November 24, 2023 08:47
@rej55 rej55 changed the title feat(interest_objects_marker_interface): add interest objects marker interface feat(objects_of_interest_marker_interface): add objects of interest marker interface Nov 24, 2023
@rej55 rej55 added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Nov 24, 2023
Copy link
Contributor

@kosuke55 kosuke55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! thanks!!

@rej55 rej55 enabled auto-merge (squash) November 24, 2023 08:50
Copy link

codecov bot commented Nov 24, 2023

Codecov Report

Attention: 1167 lines in your changes are missing coverage. Please review.

Comparison is base (765a596) 15.32% compared to head (1d5545f) 12.54%.
Report is 58 commits behind head on main.

Files Patch % Lines
...s/drivable_area_expansion/static_drivable_area.cpp 11.54% 623 Missing and 74 partials ⚠️
.../scene_module/goal_planner/goal_planner_module.cpp 0.66% 148 Missing and 2 partials ⚠️
...cene_module/start_planner/start_planner_module.cpp 7.27% 51 Missing ⚠️
planning/behavior_path_planner/src/utils/utils.cpp 35.89% 31 Missing and 19 partials ⚠️
...er/src/scene_module/avoidance/avoidance_module.cpp 0.00% 35 Missing and 2 partials ⚠️
..._of_interest_marker_interface/src/marker_utils.cpp 0.00% 36 Missing ⚠️
...rface/src/objects_of_interest_marker_interface.cpp 5.71% 30 Missing and 3 partials ⚠️
...ing/behavior_path_planner/src/utils/path_utils.cpp 42.30% 0 Missing and 30 partials ⚠️
.../scene_module/goal_planner/goal_planner_module.hpp 9.52% 15 Missing and 4 partials ⚠️
...th_planner/src/scene_module/lane_change/normal.cpp 0.00% 14 Missing ⚠️
... and 14 more
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5564       +/-   ##
===========================================
- Coverage   15.32%   12.54%    -2.78%     
===========================================
  Files        1721      111     -1610     
  Lines      118559    15089   -103470     
  Branches    37995     8467    -29528     
===========================================
- Hits        18169     1893    -16276     
+ Misses      79657    10238    -69419     
+ Partials    20733     2958    -17775     
Flag Coverage Δ
differential 12.54% <11.72%> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rej55 rej55 merged commit c1c9098 into autowarefoundation:main Nov 24, 2023
31 of 35 checks passed
@rej55 rej55 deleted the feat/interest_objects_visualization branch November 24, 2023 15:03
rej55 added a commit to tier4/autoware.universe that referenced this pull request Nov 29, 2023
…arker interface (autowarefoundation#5564)

* feat(interest_objects_marker_interface): add interest objects marker interface

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>

* feat(interest_objects_marker_interface): change marker type

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>

* feat(interest_objects_marker_interface): change markers

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>

* feat(interest_objects_marker_interface): fix lane change interface

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>

* feat(interest_objects_marker_interface): fix interface

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>

* refactor(interest_objects_marker_interface): fix interface

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>

* refactor(interest_objects_marker_interface): refactor and add descriptions

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>

* refactor(lane_change): refactor

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>

* docs(interest_objects_visualization): add contents (under construction)

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>

* chore(interest_objects_visualization): fix includes and package.xml

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>

* fix(interest_objects_marker_interface): fix

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>

* refactor(objects_of_interest_marker_interface): rename interface

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>

---------

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
kyoichi-sugahara added a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Dec 13, 2023
kyoichi-sugahara added a commit to tier4/autoware.universe that referenced this pull request Dec 13, 2023
…terest marker interface (autowarefoundation#5564)"

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
danielsanchezaran pushed a commit to tier4/autoware.universe that referenced this pull request Dec 15, 2023
…arker interface (autowarefoundation#5564)

* feat(interest_objects_marker_interface): add interest objects marker interface

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>

* feat(interest_objects_marker_interface): change marker type

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>

* feat(interest_objects_marker_interface): change markers

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>

* feat(interest_objects_marker_interface): fix lane change interface

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>

* feat(interest_objects_marker_interface): fix interface

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>

* refactor(interest_objects_marker_interface): fix interface

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>

* refactor(interest_objects_marker_interface): refactor and add descriptions

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>

* refactor(lane_change): refactor

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>

* docs(interest_objects_visualization): add contents (under construction)

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>

* chore(interest_objects_visualization): fix includes and package.xml

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>

* fix(interest_objects_marker_interface): fix

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>

* refactor(objects_of_interest_marker_interface): rename interface

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>

---------

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants