fix(static_drivable_area_expansion): fix bug in expansion logic for hatched road marking #5842

satoshi-ota · 2023-12-12T00:58:22Z

Description

`🤖[deprecated] Generated by Copilot at e633b12`

This pull request improves the behavior path avoidance module by enhancing the debug visualization and fixing a polygon closure bug. It also corrects a typo in the planning module documentation.

Related Ticket: https://tier4.atlassian.net/browse/RT1-4407

Tests performed

simplescreenrecorder-2023-12-12_09.46.31.mp4

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

I've confirmed the contribution guidelines.
The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

The PR follows the pull request guidelines.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

TomohitoAndo

LGTM

codecov · 2023-12-15T11:38:22Z

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (90d5b94) 15.30% compared to head (60d0b58) 15.29%.

Files	Patch %	Lines
...s/drivable_area_expansion/static_drivable_area.cpp	0.00%	4 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5842      +/-   ##
==========================================
- Coverage   15.30%   15.29%   -0.01%     
==========================================
  Files        1747     1747              
  Lines      120119   120123       +4     
  Branches    36570    36574       +4     
==========================================
- Hits        18380    18378       -2     
- Misses      81124    81127       +3     
- Partials    20615    20618       +3

Flag	Coverage Δ		*Carryforward flag
differential	`11.71% <0.00%> (?)`
total	`15.29% <ø> (-0.01%)`	⬇️	Carriedforward from 90d5b94

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

kyoichi-sugahara

LGTM!

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

satoshi-ota · 2023-12-17T02:33:23Z

only expasion for hatched_road_marking

Before

After

enable both of hatched_road_marking and intersection_area

…atched road marking (autowarefoundation#5842) fix(utils): fix drivable area expansion logic for zebra zone Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

…atched road marking (autowarefoundation#5842) (#1075) fix(utils): fix drivable area expansion logic for zebra zone Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

…atched road marking (autowarefoundation#5842) fix(utils): fix drivable area expansion logic for zebra zone Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> Signed-off-by: karishma <karishma@interpl.ai>

…atched road marking (autowarefoundation#5842) (autowarefoundation#1075) fix(utils): fix drivable area expansion logic for zebra zone Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* feat(avoidance): keep stopping until all shift lines are registered Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * feat(map_loader): display curbstone as marker array (autowarefoundation#4958) display curbstone as marker array Signed-off-by: Shohei Sakai <saka1s.jp@gmail.com> Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com> * revert refactoring due to cherry-pick * feat(ndt_scan_matcher): use glog (autowarefoundation#5465) (#1031) * feat(ndt_scan_matcher): use glog * style(pre-commit): autofix * update * style(pre-commit): autofix --------- Signed-off-by: kminoda <koji.minoda@tier4.jp> Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * feat(out_of_lane): improve reuse of previous decision (#1017) * Do not directly reuse a prev stop point but project it on the new path Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp> * Improve reuse of the previously inserted stop point Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp> * Fix precision of inserted stop point Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp> --------- Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp> * fix(system_monitor): output command line (autowarefoundation#5430) (#1057) * fix(system_monitor): output command line * style(pre-commit): autofix --------- Signed-off-by: takeshi.iwanari <takeshi.iwanari@tier4.jp> Co-authored-by: takeshi-iwanari <takeshi.iwanari@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * chore: pull tracking object merger from awf/main Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * feat(intersection): check path margin for overshoot vehicles on red light (autowarefoundation#5394) (#1056) Co-authored-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * fix(ndt_scan_matcher): delete diagnostics thread (autowarefoundation#5532) Signed-off-by: yamato-ando <Yamato ANDO> Co-authored-by: yamato-ando <Yamato ANDO> * fix(ndt_scan_matcher): delete unmerged feature * fix(ndt_scan_matcher): fixed a lock scope in update_ndt (autowarefoundation#5951) Fixed the lock scope in update_ndt Signed-off-by: Shintaro SAKODA <shintaro.sakoda@tier4.jp> * fix(static_drivable_area_expansion): fix bug in expansion logic for hatched road marking (autowarefoundation#5842) (#1075) fix(utils): fix drivable area expansion logic for zebra zone Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * fix(bvp): traffic light state debug (#1083) Signed-off-by: Mehmet Dogru <mdogru@leodrive.ai> * fix(traffic_light): stop if the traffic light signal timed out (autowarefoundation#5819) (#1124) * fix(traffic_light): stop if the traffic light signal timed out * fix(traffic_light): fix README format --------- Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com> Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com> * refactor(mpc_lateral_controller): add debug info of qp solver (autowarefoundation#5459) (#1098) * add debug info of qp solver * no info for EigenLeastSquareLLT * return 0 in base class --------- Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> Co-authored-by: Kyoichi Sugahara <kyoichi.sugahara@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> --------- Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> Signed-off-by: Shohei Sakai <saka1s.jp@gmail.com> Signed-off-by: kminoda <koji.minoda@tier4.jp> Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp> Signed-off-by: takeshi.iwanari <takeshi.iwanari@tier4.jp> Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> Signed-off-by: yamato-ando <Yamato ANDO> Signed-off-by: Shintaro SAKODA <shintaro.sakoda@tier4.jp> Signed-off-by: Mehmet Dogru <mdogru@leodrive.ai> Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com> Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> Co-authored-by: satoshi-ota <satoshi.ota928@gmail.com> Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com> Co-authored-by: Tomohito ANDO <tomohito.ando@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Maxime CLEMENT <78338830+maxime-clem@users.noreply.github.com> Co-authored-by: takeshi-iwanari <takeshi.iwanari@tier4.jp> Co-authored-by: yoshiri <yoshiyoshidetteiu@gmail.com> Co-authored-by: Mamoru Sobue <mamoru.sobue@tier4.jp> Co-authored-by: Yamato Ando <yamato.ando@gmail.com> Co-authored-by: Shinnosuke Hirakawa <shinnosuke.hirakawa@tier4.jp> Co-authored-by: SakodaShintaro <shintaro.sakoda@tier4.jp> Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com> Co-authored-by: Mehmet Dogru <48479081+mehmetdogru@users.noreply.github.com> Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com> Co-authored-by: Kyoichi Sugahara <kyoichi.sugahara@tier4.jp>

…atched road marking (autowarefoundation#5842) fix(utils): fix drivable area expansion logic for zebra zone Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Dec 12, 2023

satoshi-ota force-pushed the fix/zebra-zone branch from e633b12 to e415316 Compare December 15, 2023 01:35

github-actions bot removed the type:documentation Creating or refining documentation. (auto-assigned) label Dec 15, 2023

satoshi-ota marked this pull request as ready for review December 15, 2023 01:36

satoshi-ota requested review from rej55, kosuke55, soblin, maxime-clem, shmpwk, TakaHoribe, takayuki5168, tkimura4 and zulfaqar-azmi-t4 as code owners December 15, 2023 01:36

satoshi-ota assigned TomohitoAndo Dec 15, 2023

TomohitoAndo self-requested a review December 15, 2023 07:58

TomohitoAndo approved these changes Dec 15, 2023

View reviewed changes

satoshi-ota added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 15, 2023

kyoichi-sugahara approved these changes Dec 15, 2023

View reviewed changes

fix(utils): fix drivable area expansion logic for zebra zone

60d0b58

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

satoshi-ota force-pushed the fix/zebra-zone branch from e415316 to 60d0b58 Compare December 17, 2023 02:31

satoshi-ota enabled auto-merge (squash) December 17, 2023 02:36

satoshi-ota disabled auto-merge December 17, 2023 02:46

satoshi-ota merged commit 2175b57 into autowarefoundation:main Dec 17, 2023
19 of 24 checks passed

satoshi-ota deleted the fix/zebra-zone branch December 17, 2023 07:18

satoshi-ota mentioned this pull request Dec 18, 2023

fix(static_drivable_area_expansion): fix bug in expansion logic for hatched road marking (#5842) tier4/autoware.universe#1075

Merged

4 tasks

tier4-autoware-public-bot bot mentioned this pull request Dec 20, 2023

chore: sync upstream tier4/autoware.universe#1078

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(static_drivable_area_expansion): fix bug in expansion logic for hatched road marking #5842

fix(static_drivable_area_expansion): fix bug in expansion logic for hatched road marking #5842

satoshi-ota commented Dec 12, 2023 •

edited by ghost

Loading

TomohitoAndo left a comment

codecov bot commented Dec 15, 2023 •

edited

Loading

kyoichi-sugahara left a comment

satoshi-ota commented Dec 17, 2023 •

edited

Loading

fix(static_drivable_area_expansion): fix bug in expansion logic for hatched road marking #5842

fix(static_drivable_area_expansion): fix bug in expansion logic for hatched road marking #5842

Conversation

satoshi-ota commented Dec 12, 2023 • edited by ghost Loading

Description

🤖[deprecated] Generated by Copilot at e633b12

Tests performed

Effects on system behavior

Pre-review checklist for the PR author

In-review checklist for the PR reviewers

Post-review checklist for the PR author

TomohitoAndo left a comment

Choose a reason for hiding this comment

codecov bot commented Dec 15, 2023 • edited Loading

Codecov Report

kyoichi-sugahara left a comment

Choose a reason for hiding this comment

satoshi-ota commented Dec 17, 2023 • edited Loading

Before

After

satoshi-ota commented Dec 12, 2023 •

edited by ghost

Loading

`🤖[deprecated] Generated by Copilot at e633b12`

codecov bot commented Dec 15, 2023 •

edited

Loading

satoshi-ota commented Dec 17, 2023 •

edited

Loading