build(traffic_light_fine_detector): disable downloading artifacts by default

[esteve]

Description

Use the DOWNLOAD_ARTIFACTS option to not download artifacts by default, same rationale as #4110.

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

• I've confirmed the contribution guidelines.
• The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

• The PR follows the pull request guidelines.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

• There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

[ambroise-arm]

The structure looks like

if(data_exist)
	msg(found)
	if(hash_match)
		msg(ok)
		return
	else
		msg(diff)
		if(DOWNLOAD)
			download
		else
			msg(warn)
else
	if(DOWNLOAD)
		download
	else
		msg(warn)

Would it make sense to simplify as

if(data_exist)
	msg(found)
	if(hash_match)
		msg(ok)
		return
	msg(diff)
if(DOWNLOAD)
	download
else
	msg(warn)

It would avoid the duplication of the download commands.

[codecov]

Codecov Report

Patch coverage has no change and project coverage change: -0.66% ⚠️

Comparison is base (e1a86f9) 14.90% compared to head (50dc52a) 14.24%.
Report is 7 commits behind head on main.

❗ Current head 50dc52a differs from pull request most recent head 281fc63. Consider uploading reports for the commit 281fc63 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4201      +/-   ##
==========================================
- Coverage   14.90%   14.24%   -0.66%     
==========================================
  Files        1547     1582      +35     
  Lines      106635   108937    +2302     
  Branches    32625    31442    -1183     
==========================================
- Hits        15890    15516     -374     
- Misses      73431    76531    +3100     
+ Partials    17314    16890     -424     

Flag	Coverage Δ		*Carryforward flag
differential	0.00% <ø> (?)
total	14.24% <ø> (-0.66%)	⬇️	Carriedforward from 632f35f

*This pull request uses carry forward flags. Click here to find out more.

see 396 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[esteve]

@ambroise-arm thanks for having a look. I've updated the logic in 5c00581, could you check that it addresses your feedback? Thanks.

[ambroise-arm]

Looks good to me!

[Mingyu1991]

LGTM

[miursh]

@esteve Can we close this PR since #4896 is already merged?

[esteve]

@miursh yeah, thanks for the reminder