-
Notifications
You must be signed in to change notification settings - Fork 630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(yabloc_pose_initializer): disable downloading artifacts by default #4110
fix(yabloc_pose_initializer): disable downloading artifacts by default #4110
Conversation
Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
3d8f47d
to
2fa6d6d
Compare
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #4110 +/- ##
==========================================
- Coverage 14.35% 14.34% -0.01%
==========================================
Files 1569 1569
Lines 107991 107988 -3
Branches 31249 31248 -1
==========================================
- Hits 15498 15496 -2
Misses 75639 75639
+ Partials 16854 16853 -1
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
@esteve Hi! I think this PR looks good. |
@KYabuuchi thanks for the feedback. We're currently not building However, if we ever include it as part of the |
I understand. It makes sense now. 👍 |
@KYabuuchi thanks for approving this PR, I will merge it and add it to the list of PRs that disable downloading artifacts by default. |
Description
Other packages that use artifacts, have a
DOWNLOAD_ARTIFACTS
option, so that they can be built without access to the internet (e.g. when built with Debian'ssbuild
). This PR adds such option and defaults it tooff
.See autowarefoundation/autoware-deb-packages#18
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.