Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(behavior_path_planner): define DrivableAreaInfo and commonize generateDrivableArea #3263

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Apr 4, 2023

Description

Tests performed

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

…ea generation

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@mergify
Copy link

mergify bot commented Apr 4, 2023

⚠️ The sha of the head commit of this PR conflicts with #3249. Mergify cannot evaluate rules on this PR. ⚠️

@takayuki5168 takayuki5168 changed the title Feat/common drivable area generation feat(behavior_path_planner): define DrivableAreaInfo and commonize generateDrivableArea Apr 4, 2023
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Apr 4, 2023
@codecov
Copy link

codecov bot commented Apr 4, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.94 ⚠️

Comparison is base (4373a81) 13.22% compared to head (47e0b66) 12.29%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3263      +/-   ##
==========================================
- Coverage   13.22%   12.29%   -0.94%     
==========================================
  Files        1263     1361      +98     
  Lines       89266    94511    +5245     
  Branches    27059    27240     +181     
==========================================
- Hits        11809    11616     -193     
- Misses      65033    70546    +5513     
+ Partials    12424    12349      -75     
Flag Coverage Δ *Carryforward flag
differential 5.52% <0.00%> (?)
total 12.30% <ø> (-0.93%) ⬇️ Carriedforward from 25247ba

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...ner/include/behavior_path_planner/data_manager.hpp 21.42% <ø> (ø)
...er/scene_module/lane_change/lane_change_module.hpp 0.00% <ø> (ø)
...ne_module/lane_following/lane_following_module.hpp 0.00% <ø> (ø)
...lanner/include/behavior_path_planner/utilities.hpp 83.33% <ø> (ø)
...ehavior_path_planner/src/behavior_tree_manager.cpp 0.00% <0.00%> (ø)
...er/src/scene_module/avoidance/avoidance_module.cpp 0.00% <0.00%> (ø)
...rc/scene_module/lane_change/lane_change_module.cpp 0.00% <0.00%> (ø)
...ne_module/lane_following/lane_following_module.cpp 0.00% <0.00%> (ø)
...ehavior_path_planner/src/util/lane_change/util.cpp 0.00% <0.00%> (ø)
planning/behavior_path_planner/src/utilities.cpp 7.65% <0.00%> (-0.24%) ⬇️

... and 204 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@takayuki5168 takayuki5168 deleted the feat/common-drivable-area-generation branch May 20, 2023 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant