-
Notifications
You must be signed in to change notification settings - Fork 630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(behavior_path_planner): change method to combine drivable lanes #3249
feat(behavior_path_planner): change method to combine drivable lanes #3249
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #3249 +/- ##
==========================================
- Coverage 12.41% 12.35% -0.06%
==========================================
Files 1364 1364
Lines 95145 96250 +1105
Branches 27066 27816 +750
==========================================
+ Hits 11812 11892 +80
- Misses 70909 71843 +934
- Partials 12424 12515 +91
*This pull request uses carry forward flags. Click here to find out more.
... and 7 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
25247ba
to
33a3b33
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…utowarefoundation#3249) * feat(behavior_path_planner): change method to combine drivable lanes Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * applied to lane change Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * revert cmake Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix typo --------- Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com>
Description
We have to combine drivable lanes from the multiple modules when the number of running modules is larger than 1.
I separated the implementation into generateDrivableLanes which depends on each module and combineDrivableLanes which can be used for any module.
In the near future, I will move combineDrivableLanes outside the module so that there will be no conflict of drivable area generation with any pairs of modules.
Tests performed
with BT: https://evaluation.tier4.jp/evaluation/reports/fb9bd427-c48a-5203-92fa-7723d1ca0aa4?project_id=prd_jt
without BT: planning simulator works well with avoidance/lane change.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.