Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(behavior_path_planner): change method to combine drivable lanes #3249

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Apr 3, 2023

Description

We have to combine drivable lanes from the multiple modules when the number of running modules is larger than 1.
I separated the implementation into generateDrivableLanes which depends on each module and combineDrivableLanes which can be used for any module.

In the near future, I will move combineDrivableLanes outside the module so that there will be no conflict of drivable area generation with any pairs of modules.

  • TODO
    • planning simulator with old archi
    • planning simulator with new archi by @satoshi-ota

Tests performed

with BT: https://evaluation.tier4.jp/evaluation/reports/fb9bd427-c48a-5203-92fa-7723d1ca0aa4?project_id=prd_jt
without BT: planning simulator works well with avoidance/lane change.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Apr 3, 2023
@codecov
Copy link

codecov bot commented Apr 3, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.06 ⚠️

Comparison is base (145de9f) 12.41% compared to head (bb0989c) 12.35%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3249      +/-   ##
==========================================
- Coverage   12.41%   12.35%   -0.06%     
==========================================
  Files        1364     1364              
  Lines       95145    96250    +1105     
  Branches    27066    27816     +750     
==========================================
+ Hits        11812    11892      +80     
- Misses      70909    71843     +934     
- Partials    12424    12515      +91     
Flag Coverage Δ *Carryforward flag
differential 5.55% <0.00%> (?)
total 12.41% <ø> (-0.01%) ⬇️ Carriedforward from 33a3b33

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...rc/scene_module/lane_change/lane_change_module.cpp 0.00% <ø> (ø)
...ehavior_path_planner/src/util/lane_change/util.cpp 0.00% <0.00%> (ø)

... and 7 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168 takayuki5168 force-pushed the feat/change-drivable-area-combine-method branch from 25247ba to 33a3b33 Compare April 4, 2023 16:19
Copy link
Contributor

@satoshi-ota satoshi-ota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

image

@takayuki5168 takayuki5168 merged commit fe9c742 into autowarefoundation:main Apr 5, 2023
@takayuki5168 takayuki5168 deleted the feat/change-drivable-area-combine-method branch April 5, 2023 12:13
ktro2828 pushed a commit to ktro2828/autoware.universe that referenced this pull request Apr 7, 2023
…utowarefoundation#3249)

* feat(behavior_path_planner): change method to combine drivable lanes

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* applied to lane change

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* revert cmake

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix typo

---------

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants