Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(behavior_path_planner): fix overlapping function usage in parking #3260

Merged
merged 1 commit into from
Apr 4, 2023

Conversation

purewater0901
Copy link
Contributor

@purewater0901 purewater0901 commented Apr 4, 2023

Description

Fix remover overlapping function usage in geometric parking

Tests performed

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: yutaka <purewater0901@gmail.com>
Copy link
Contributor

@kosuke55 kosuke55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!!

@kosuke55 kosuke55 changed the title feat(behavior_path_planner): fix overlapping function usage in parking fix(behavior_path_planner): fix overlapping function usage in parking Apr 4, 2023
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Apr 4, 2023
@codecov
Copy link

codecov bot commented Apr 4, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.83 🎉

Comparison is base (ef6a353) 12.39% compared to head (b7f4342) 13.23%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3260      +/-   ##
==========================================
+ Coverage   12.39%   13.23%   +0.83%     
==========================================
  Files        1364     1263     -101     
  Lines       95255    89270    -5985     
  Branches    27078    27061      -17     
==========================================
+ Hits        11809    11811       +2     
+ Misses      71022    65036    -5986     
+ Partials    12424    12423       -1     
Flag Coverage Δ *Carryforward flag
differential 5.54% <0.00%> (?)
total 13.23% <ø> (+0.83%) ⬆️ Carriedforward from 25c154d

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...lanner/include/behavior_path_planner/utilities.hpp 83.33% <ø> (ø)
...ic_parallel_parking/geometric_parallel_parking.cpp 0.00% <0.00%> (ø)
...ehavior_path_planner/src/util/lane_change/util.cpp 0.00% <0.00%> (ø)
planning/behavior_path_planner/src/utilities.cpp 7.87% <0.00%> (+0.30%) ⬆️

... and 103 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@purewater0901 purewater0901 merged commit 11b73eb into main Apr 4, 2023
@purewater0901 purewater0901 deleted the fix/parking-overlapping-points branch April 4, 2023 06:17
ktro2828 pushed a commit to ktro2828/autoware.universe that referenced this pull request Apr 7, 2023
…autowarefoundation#3260)

feat(behavior_path_planner): fix overlapping function usage in parking

Signed-off-by: yutaka <purewater0901@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants