Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: regex for multi-region IPs #16410

Merged
merged 2 commits into from
Aug 23, 2021

Conversation

AAfghahi
Copy link
Member

SUMMARY

The regional IPs were not showing up correctly for the Database Connection Modal. This changes the logic.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Aug 23, 2021

Codecov Report

Merging #16410 (ebe06aa) into master (c768941) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

❗ Current head ebe06aa differs from pull request most recent head ce560f3. Consider uploading reports for the commit ce560f3 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16410      +/-   ##
==========================================
- Coverage   76.55%   76.55%   -0.01%     
==========================================
  Files        1000     1000              
  Lines       53483    53484       +1     
  Branches     6818     6818              
==========================================
  Hits        40945    40945              
- Misses      12300    12301       +1     
  Partials      238      238              
Flag Coverage Δ
javascript 70.69% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/views/CRUD/data/database/DatabaseModal/index.tsx 44.24% <0.00%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c768941...ce560f3. Read the comment docs.

@hughhhh hughhhh self-requested a review August 23, 2021 20:43
@hughhhh hughhhh merged commit a6aad52 into apache:master Aug 23, 2021
Object.entries(regionalIPs).forEach(([regex, ipRange]) => {
if (regex.match(hostname)) {
Object.entries(regionalIPs).forEach(([ipRegion, ipRange]) => {
const regex = new RegExp(ipRegion);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you used to have the case insensitive flag on this? Do you want to bring it back in?

amitmiran137 pushed a commit to nielsen-oss/superset that referenced this pull request Aug 24, 2021
* master: (582 commits)
  feat: config to customize bootstrap data overrides (apache#16386)
  fix: regex for multi-region IPs (apache#16410)
  chore: Changes the DatabaseSelector to use the new Select component (apache#16334)
  chore: Displays the dataset description in a tooltip in the datasets list (apache#16392)
  fix(pylint): Fix master (apache#16405)
  chore(pylint): Enable useless-suppression check (apache#16388)
  feat: Add extraVolumes and extraVolumeMounts to all main containers (apache#16361)
  initial commit (apache#16366)
  fix: big number default date format (apache#16383)
  initial commit (apache#16380)
  fix: import dashboard w/o metadata (apache#16360)
  test: Functional RTL for email report modal II (apache#16148)
  fix: update table ID in query context on chart import (apache#16374)
  docs: document FLASK_APP_MUTATOR (apache#16286)
  feat: Add new dev commands to Makefile (apache#16327)
  fix: call external metadata endpoint with correct rison object (apache#16369)
  fix: Fix parsing onSaving reports toast when user hasn't saved chart (apache#16330)
  fix: columns/index rebuild (apache#16355)
  chore(viz): bump deckgl plugin to 0.4.11 (apache#16353)
  fix: Blank space in Change dataset modal without warning message (apache#16324)
  ...

# Conflicts:
#	superset/app.py
#	superset/models/dashboard.py
#	tests/integration_tests/charts/filter_sets/__init__.py
#	tests/integration_tests/charts/filter_sets/conftest.py
#	tests/integration_tests/charts/filter_sets/consts.py
#	tests/integration_tests/charts/filter_sets/create_api_tests.py
#	tests/integration_tests/charts/filter_sets/delete_api_tests.py
#	tests/integration_tests/charts/filter_sets/get_api_tests.py
#	tests/integration_tests/charts/filter_sets/update_api_tests.py
#	tests/integration_tests/charts/filter_sets/utils.py
#	tests/integration_tests/superset_test_config.py
henryyeh pushed a commit to preset-io/superset that referenced this pull request Aug 24, 2021
* regex for multi-region IPs

* Update index.tsx

(cherry picked from commit a6aad52)
@rosemarie-chiu
Copy link
Contributor

🏷 2021.31

opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
* regex for multi-region IPs

* Update index.tsx
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 28, 2021
* regex for multi-region IPs

* Update index.tsx
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.4.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset:2021.31 size/XS 🚢 1.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants