Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add new dev commands to Makefile #16327

Merged
merged 2 commits into from
Aug 20, 2021
Merged

feat: Add new dev commands to Makefile #16327

merged 2 commits into from
Aug 20, 2021

Conversation

hughhhh
Copy link
Member

@hughhhh hughhhh commented Aug 18, 2021

SUMMARY

Added 2 commands to allow users to spin up the node (FE) and flask app (BE) for development. Also change make update to use npm ci instead

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Aug 18, 2021

Codecov Report

Merging #16327 (9f11039) into master (2c595b0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #16327   +/-   ##
=======================================
  Coverage   76.63%   76.63%           
=======================================
  Files        1000     1000           
  Lines       53426    53426           
  Branches     6819     6819           
=======================================
  Hits        40945    40945           
  Misses      12244    12244           
  Partials      237      237           
Flag Coverage Δ
hive 81.38% <ø> (ø)
javascript 70.77% <ø> (ø)
mysql 81.63% <ø> (+0.04%) ⬆️
postgres 81.61% <ø> (-0.05%) ⬇️
presto 81.45% <ø> (-0.05%) ⬇️
python 82.17% <ø> (ø)
sqlite 81.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c595b0...9f11039. Read the comment docs.

Makefile Outdated
flask run -p 8088 --with-threads --reload --debugger

node-app:
cd superset-frontend; npm run dev-server -- --devserverPort=9001
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why 9001?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no specific reason i'll remove that line

@lyndsiWilliams
Copy link
Member

This is awesome! 🔥

@@ -58,7 +58,7 @@ update-py:

update-js:
# Install js packages
cd superset-frontend; npm install
cd superset-frontend; npm ci
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A suggestion; instead of using cd do this:

Suggested change
cd superset-frontend; npm ci
pushd superset-frontend; npm ci; popd

This will bring back the user to the directory they were when they ran the command.

@@ -81,3 +81,9 @@ py-lint: pre-commit

js-format:
cd superset-frontend; npm run prettier
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

flask run -p 8088 --with-threads --reload --debugger

node-app:
cd superset-frontend; npm run dev-server
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running the command you still land in the root just tested it locally so we don't need to change it

@hughhhh hughhhh merged commit ea803c3 into master Aug 20, 2021
MaxHuiYYDS pushed a commit to MaxHuiYYDS/superset that referenced this pull request Aug 22, 2021
* updating makefile

* Update Makefile
amitmiran137 pushed a commit to nielsen-oss/superset that referenced this pull request Aug 24, 2021
* master: (582 commits)
  feat: config to customize bootstrap data overrides (apache#16386)
  fix: regex for multi-region IPs (apache#16410)
  chore: Changes the DatabaseSelector to use the new Select component (apache#16334)
  chore: Displays the dataset description in a tooltip in the datasets list (apache#16392)
  fix(pylint): Fix master (apache#16405)
  chore(pylint): Enable useless-suppression check (apache#16388)
  feat: Add extraVolumes and extraVolumeMounts to all main containers (apache#16361)
  initial commit (apache#16366)
  fix: big number default date format (apache#16383)
  initial commit (apache#16380)
  fix: import dashboard w/o metadata (apache#16360)
  test: Functional RTL for email report modal II (apache#16148)
  fix: update table ID in query context on chart import (apache#16374)
  docs: document FLASK_APP_MUTATOR (apache#16286)
  feat: Add new dev commands to Makefile (apache#16327)
  fix: call external metadata endpoint with correct rison object (apache#16369)
  fix: Fix parsing onSaving reports toast when user hasn't saved chart (apache#16330)
  fix: columns/index rebuild (apache#16355)
  chore(viz): bump deckgl plugin to 0.4.11 (apache#16353)
  fix: Blank space in Change dataset modal without warning message (apache#16324)
  ...

# Conflicts:
#	superset/app.py
#	superset/models/dashboard.py
#	tests/integration_tests/charts/filter_sets/__init__.py
#	tests/integration_tests/charts/filter_sets/conftest.py
#	tests/integration_tests/charts/filter_sets/consts.py
#	tests/integration_tests/charts/filter_sets/create_api_tests.py
#	tests/integration_tests/charts/filter_sets/delete_api_tests.py
#	tests/integration_tests/charts/filter_sets/get_api_tests.py
#	tests/integration_tests/charts/filter_sets/update_api_tests.py
#	tests/integration_tests/charts/filter_sets/utils.py
#	tests/integration_tests/superset_test_config.py
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
* updating makefile

* Update Makefile
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 28, 2021
* updating makefile

* Update Makefile
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.4.0 labels Mar 13, 2024
@mistercrunch mistercrunch deleted the hugh/mkfile-improve branch March 26, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants