-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Displays the dataset description in a tooltip in the datasets list #16392
chore: Displays the dataset description in a tooltip in the datasets list #16392
Conversation
Codecov Report
@@ Coverage Diff @@
## master #16392 +/- ##
==========================================
- Coverage 76.57% 76.56% -0.01%
==========================================
Files 1000 1000
Lines 53489 53493 +4
Branches 6816 6818 +2
==========================================
+ Hits 40957 40959 +2
- Misses 12296 12298 +2
Partials 236 236
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/testenv up |
@michael-s-molina Ephemeral environment spinning up at http://35.166.203.100:8080. Credentials are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice, LGTM!
Ephemeral environment shutdown and build artifacts deleted. |
i don't think this is good solution!!!!!! |
Could you elaborate as to why, or what alternate approach you would suggest? |
@rusackas |
* master: (582 commits) feat: config to customize bootstrap data overrides (apache#16386) fix: regex for multi-region IPs (apache#16410) chore: Changes the DatabaseSelector to use the new Select component (apache#16334) chore: Displays the dataset description in a tooltip in the datasets list (apache#16392) fix(pylint): Fix master (apache#16405) chore(pylint): Enable useless-suppression check (apache#16388) feat: Add extraVolumes and extraVolumeMounts to all main containers (apache#16361) initial commit (apache#16366) fix: big number default date format (apache#16383) initial commit (apache#16380) fix: import dashboard w/o metadata (apache#16360) test: Functional RTL for email report modal II (apache#16148) fix: update table ID in query context on chart import (apache#16374) docs: document FLASK_APP_MUTATOR (apache#16286) feat: Add new dev commands to Makefile (apache#16327) fix: call external metadata endpoint with correct rison object (apache#16369) fix: Fix parsing onSaving reports toast when user hasn't saved chart (apache#16330) fix: columns/index rebuild (apache#16355) chore(viz): bump deckgl plugin to 0.4.11 (apache#16353) fix: Blank space in Change dataset modal without warning message (apache#16324) ... # Conflicts: # superset/app.py # superset/models/dashboard.py # tests/integration_tests/charts/filter_sets/__init__.py # tests/integration_tests/charts/filter_sets/conftest.py # tests/integration_tests/charts/filter_sets/consts.py # tests/integration_tests/charts/filter_sets/create_api_tests.py # tests/integration_tests/charts/filter_sets/delete_api_tests.py # tests/integration_tests/charts/filter_sets/get_api_tests.py # tests/integration_tests/charts/filter_sets/update_api_tests.py # tests/integration_tests/charts/filter_sets/utils.py # tests/integration_tests/superset_test_config.py
@zhxjdwh @rusackas @junlincc I think we need to separate the features a little bit:
|
SUMMARY
Closes #16309
@junlincc @jinghua-qa @rusackas @zhxjdwh @mistercrunch
AFTER SCREENSHOTS OR ANIMATED GIF
Screen.Recording.2021-08-21.at.3.17.46.PM.mov
TESTING INSTRUCTIONS
Check the video for instructions.
ADDITIONAL INFORMATION