-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ensure certified fields are populated in metrics #16380
Conversation
Codecov Report
@@ Coverage Diff @@
## master #16380 +/- ##
==========================================
+ Coverage 76.58% 76.64% +0.05%
==========================================
Files 1000 1000
Lines 53481 53483 +2
Branches 6815 6816 +1
==========================================
+ Hits 40958 40990 +32
+ Misses 12287 12257 -30
Partials 236 236
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/testenv up |
@junlincc Ephemeral environment spinning up at http://54.214.150.214:8080. Credentials are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM! Muchas gracias!
lgtm tested!! thank you for the fix :) |
... oh, and it looked good in testing, too! |
Ephemeral environment shutdown and build artifacts deleted. |
* master: (582 commits) feat: config to customize bootstrap data overrides (apache#16386) fix: regex for multi-region IPs (apache#16410) chore: Changes the DatabaseSelector to use the new Select component (apache#16334) chore: Displays the dataset description in a tooltip in the datasets list (apache#16392) fix(pylint): Fix master (apache#16405) chore(pylint): Enable useless-suppression check (apache#16388) feat: Add extraVolumes and extraVolumeMounts to all main containers (apache#16361) initial commit (apache#16366) fix: big number default date format (apache#16383) initial commit (apache#16380) fix: import dashboard w/o metadata (apache#16360) test: Functional RTL for email report modal II (apache#16148) fix: update table ID in query context on chart import (apache#16374) docs: document FLASK_APP_MUTATOR (apache#16286) feat: Add new dev commands to Makefile (apache#16327) fix: call external metadata endpoint with correct rison object (apache#16369) fix: Fix parsing onSaving reports toast when user hasn't saved chart (apache#16330) fix: columns/index rebuild (apache#16355) chore(viz): bump deckgl plugin to 0.4.11 (apache#16353) fix: Blank space in Change dataset modal without warning message (apache#16324) ... # Conflicts: # superset/app.py # superset/models/dashboard.py # tests/integration_tests/charts/filter_sets/__init__.py # tests/integration_tests/charts/filter_sets/conftest.py # tests/integration_tests/charts/filter_sets/consts.py # tests/integration_tests/charts/filter_sets/create_api_tests.py # tests/integration_tests/charts/filter_sets/delete_api_tests.py # tests/integration_tests/charts/filter_sets/get_api_tests.py # tests/integration_tests/charts/filter_sets/update_api_tests.py # tests/integration_tests/charts/filter_sets/utils.py # tests/integration_tests/superset_test_config.py
SUMMARY
This pr fixes an issue where the certified fields are not populated after saving them in the metrics tab in the edit dataset modal.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
existing certified metric
Screen.Recording.2021-08-20.at.2.19.51.PM.mov
adding metrics with certified fields
Uploading Screen Recording 2021-08-20 at 2.23.11 PM.mov…
TESTING INSTRUCTIONS
Go to edit dataset modal within explore. Add info to the certified fields under the metrics tab and save. Test they are still populated when reopening the modal
ADDITIONAL INFORMATION