New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Stop _id property from directly rendering the _id view #78

Merged

oliverfoster merged 2 commits into master from issue/208

Aug 3, 2022

Member

oliverfoster commented Aug 2, 2022

fixes adaptlearning/adapt-contrib-core#208

Fix

Tutor explicitly does not render the _id view in the notify

refs adaptlearning/adapt-contrib-core#211

oliverfoster added 2 commits

August 2, 2022 17:15


          Fix: Prevent _id from rendering

9b4d9d9


          Changed variable name

c3a6c99

oliverfoster added the bug label

oliverfoster self-assigned this

oliverfoster requested a review from cahirodoherty-learningpool

August 2, 2022 16:22

cahirodoherty-learningpool approved these changes

View reviewed changes

Contributor

cahirodoherty-learningpool left a comment

👀

ethan-lp approved these changes

View reviewed changes

eleanor-heath approved these changes

View reviewed changes

oliverfoster merged commit df1da66 into master

oliverfoster deleted the issue/208 branch

August 3, 2022 11:03

github-actions bot pushed a commit that referenced this pull request


          Chore(release): 4.2.3 [skip ci]

175857d

## [4.2.3](v4.2.2...v4.2.3) (2022-08-03)

### Fix

* Stop _id property from directly rendering the _id view (#78) ([df1da66](df1da66)), closes [#78](#78)

github-actions bot commented Aug 3, 2022

🎉 This PR is included in version 4.2.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

github-actions bot added the released label

github-actions bot pushed a commit to nagyist/adapt-contrib-tutor that referenced this pull request


          Chore(release): 2.2.0 [skip ci]

7679d6a

# [2.2.0](v2.1.2...v2.2.0) (2023-05-27)

### chore

* added package.json ([677347b](677347b))
* added package.json ([94afb62](94afb62)), closes [#3072](https://github.com/nagyist/adapt-contrib-tutor/issues/3072)

### Fix

* _globals schema nesting (adaptlearning#90) ([c385e3c](c385e3c)), closes [adaptlearning#90](https://github.com/nagyist/adapt-contrib-tutor/issues/90)
* Added gitignore for release automation (adaptlearning#77) ([bef3c93](bef3c93)), closes [adaptlearning#77](https://github.com/nagyist/adapt-contrib-tutor/issues/77)
* Added release automation (adaptlearning#73) ([c04b610](c04b610)), closes [adaptlearning#73](https://github.com/nagyist/adapt-contrib-tutor/issues/73)
* Bump http-cache-semantics from 4.1.0 to 4.1.1 (adaptlearning#82) ([076e8c5](076e8c5)), closes [adaptlearning#82](https://github.com/nagyist/adapt-contrib-tutor/issues/82)
* Check tutor type on page revisit before displaying inline feedback (fixes adaptlearning#91) (adaptlearning#92) ([e4f5761](e4f5761)), closes [adaptlearning#91](https://github.com/nagyist/adapt-contrib-tutor/issues/91) [adaptlearning#92](https://github.com/nagyist/adapt-contrib-tutor/issues/92)
* Framework bumped to v5.22.8 ([8a17aae](8a17aae))
* Inline feedback normalisation across course and component config (fixes adaptlearning#87) (adaptlearning#88) ([f03b1ee](f03b1ee)), closes [adaptlearning#87](https://github.com/nagyist/adapt-contrib-tutor/issues/87) [adaptlearning#88](https://github.com/nagyist/adapt-contrib-tutor/issues/88)
* New style schema added. (adaptlearning#84) ([5be15e0](5be15e0)), closes [adaptlearning#84](https://github.com/nagyist/adapt-contrib-tutor/issues/84)
* Normalizing template icons ([cff3c07](cff3c07))
* replace deprecated a11y_attrs_heading usage (refs adaptlearning#67) (adaptlearning#76) ([f34b5fa](f34b5fa)), closes [adaptlearning#67](https://github.com/nagyist/adapt-contrib-tutor/issues/67) [adaptlearning#76](https://github.com/nagyist/adapt-contrib-tutor/issues/76)
* Stop _id property from directly rendering the _id view (adaptlearning#78) ([df1da66](df1da66)), closes [adaptlearning#78](https://github.com/nagyist/adapt-contrib-tutor/issues/78)
* Version numbers removed from Readme files ([7b6f5bd](7b6f5bd))

### New

* Issue and pr project addition automation (Fixes #3315) ([46f531d](46f531d)), closes [#3315](https://github.com/nagyist/adapt-contrib-tutor/issues/3315)
* Issue and pr project addition automation (refs adaptlearning/adapt_framework#3315) ([a666b69](a666b69))

### Update

* `"inline"` feedback restoration (adaptlearning#81) ([f5f35a2](f5f35a2)), closes [adaptlearning#81](https://github.com/nagyist/adapt-contrib-tutor/issues/81)
* Add accessible title (refs adaptlearning#74) (adaptlearning#75) ([bbe81f6](bbe81f6)), closes [adaptlearning#74](https://github.com/nagyist/adapt-contrib-tutor/issues/74) [adaptlearning#75](https://github.com/nagyist/adapt-contrib-tutor/issues/75)
* Switch to model.getFeedback allowing more complex feedback objects (adaptlearning#79) ([25fe47c](25fe47c)), closes [adaptlearning#79](https://github.com/nagyist/adapt-contrib-tutor/issues/79)

### Upgrade

* Bump yaml and semantic-release (adaptlearning#93) ([723a352](723a352)), closes [adaptlearning#93](https://github.com/nagyist/adapt-contrib-tutor/issues/93)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels