Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Add _shouldRenderId to notify api (fixes #208) #211

Merged
merged 2 commits into from
Aug 3, 2022
Merged

Fix: Add _shouldRenderId to notify api (fixes #208) #211

merged 2 commits into from
Aug 3, 2022

Conversation

oliverfoster
Copy link
Member

fixes #208

Fix

  • Notify should not render the subview specified by the _id unless _shouldRenderId = true

@oliverfoster oliverfoster added the bug Something isn't working label Aug 2, 2022
@oliverfoster oliverfoster self-assigned this Aug 2, 2022
@oliverfoster oliverfoster mentioned this pull request Aug 2, 2022
Merged
cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Aug 2, 2022
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@oliverfoster oliverfoster merged commit 8212d50 into master Aug 3, 2022
@oliverfoster oliverfoster deleted the issue/208 branch August 3, 2022 11:03
github-actions bot pushed a commit that referenced this pull request Aug 3, 2022
@semantic-release-bot
Chore(release): 6.14.2 [skip ci]
4992dfe 
## [6.14.2](v6.14.1...v6.14.2) (2022-08-03)

### Fix

* Add _shouldRenderId to notify api (fixes #208) (#211) ([8212d50](8212d50)), closes [#208](#208) [#211](#211)
* Device resize html classes rendering speed (fixes #209) (#210) ([1a0d56b](1a0d56b)), closes [#209](#209) [#210](#210)
@github-actions
Copy link

github-actions bot commented Aug 3, 2022

🎉 This PR is included in version 6.14.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@ethan-lp ethan-lp ethan-lp approved these changes

@eleanor-heath eleanor-heath eleanor-heath approved these changes

Assignees

@oliverfoster oliverfoster

Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Notify popup should allow disabling of subview
4 participants
@oliverfoster @cahirodoherty-learningpool @ethan-lp @eleanor-heath