Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update: Add accessible title (refs #74) #75

Merged
merged 13 commits into from
Aug 17, 2022
Merged

Update: Add accessible title (refs #74) #75

merged 13 commits into from
Aug 17, 2022

Conversation

chris-steele
Copy link
Contributor

@chris-steele chris-steele commented Jul 27, 2022 •
edited by oliverfoster
Loading

refs #74

Update

  • Provides a default heading if no title is provided

Testing

  1. Remove _feedback.title, title and displayTitle properties from question component and using AT note the heading provided matches the one given by _tutor.altTitle.

adaptlearning/adapt-contrib-core#173

cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Jul 27, 2022
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

oliverfoster
oliverfoster requested changes Jul 27, 2022
View reviewed changes
example.json Outdated Show resolved Hide resolved
@oliverfoster oliverfoster changed the title Provide accessible dialog heading if no title given Update: Add accessible title (refs #74) Jul 27, 2022
oliverfoster
oliverfoster reviewed Jul 27, 2022
View reviewed changes
js/TutorModel.js Outdated Show resolved Hide resolved
oliverfoster
oliverfoster reviewed Jul 28, 2022
View reviewed changes
example.json Outdated Show resolved Hide resolved
@oliverfoster
Copy link
Member

sorry, inline feedback, is that necessary?

@oliverfoster oliverfoster self-requested a review July 28, 2022 14:25
@chris-steele
Copy link
Contributor Author

I've (accidentally) included the change in this PR: adaptlearning/adapt-contrib-core#203

@oliverfoster
Copy link
Member

I meant this bit, does it also need the altTitle if block?

adapt-contrib-tutor/templates/tutor.hbs

Lines 8 to 12 in 248bc0f

<div class="tutor__title">
<div class="tutor__title-inner" {{a11y_attrs_heading 'notify'}}>
{{{compile title}}}
</div>
</div>

@chris-steele
Copy link
Contributor Author

Yep I think it does

@chris-steele
Copy link
Contributor Author

I'm concerned that we'll have conflicting lines if I put in altTitle now, do we need to merge #76 first?

@oliverfoster
Copy link
Member

Yea, #76 in first then merge master into here and deal with the merge conflict on this one. Go ahead and make the changes you need here and I'll talk you through resolving the merge conflict if you need.

@chris-steele
Copy link
Contributor Author

If I did it like this would that maybe save us a conflict? ;-)

@oliverfoster
Copy link
Member

Probably not because they're different commits. But we'll find out.

@chris-steele
Copy link
Contributor Author

Yeah that was a dumb suggestion I realised quite quickly!

joe-replin
joe-replin approved these changes Aug 16, 2022
View reviewed changes
Copy link
Contributor

@joe-replin joe-replin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in v5.19.6 of the FW and working great.

@oliverfoster oliverfoster merged commit bbe81f6 into master Aug 17, 2022
github-actions bot pushed a commit that referenced this pull request Aug 17, 2022
@semantic-release-bot
Chore(release): 4.3.0 [skip ci]
a99d6aa 
# [4.3.0](v4.2.3...v4.3.0) (2022-08-17)

### Update

* Add accessible title (refs #74) (#75) ([bbe81f6](bbe81f6)), closes [#74](#74) [#75](#75)
@github-actions
Copy link

🎉 This PR is included in version 4.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@oliverfoster oliverfoster deleted the issue/74 branch August 17, 2022 01:43
github-actions bot pushed a commit to nagyist/adapt-contrib-tutor that referenced this pull request May 27, 2023
@semantic-release-bot
Chore(release): 2.2.0 [skip ci]
7679d6a 
# [2.2.0](v2.1.2...v2.2.0) (2023-05-27)

### chore

* added package.json ([677347b](677347b))
* added package.json ([94afb62](94afb62)), closes [#3072](https://github.com/nagyist/adapt-contrib-tutor/issues/3072)

### Fix

* _globals schema nesting (adaptlearning#90) ([c385e3c](c385e3c)), closes [adaptlearning#90](https://github.com/nagyist/adapt-contrib-tutor/issues/90)
* Added gitignore for release automation (adaptlearning#77) ([bef3c93](bef3c93)), closes [adaptlearning#77](https://github.com/nagyist/adapt-contrib-tutor/issues/77)
* Added release automation (adaptlearning#73) ([c04b610](c04b610)), closes [adaptlearning#73](https://github.com/nagyist/adapt-contrib-tutor/issues/73)
* Bump http-cache-semantics from 4.1.0 to 4.1.1 (adaptlearning#82) ([076e8c5](076e8c5)), closes [adaptlearning#82](https://github.com/nagyist/adapt-contrib-tutor/issues/82)
* Check tutor type on page revisit before displaying inline feedback (fixes adaptlearning#91) (adaptlearning#92) ([e4f5761](e4f5761)), closes [adaptlearning#91](https://github.com/nagyist/adapt-contrib-tutor/issues/91) [adaptlearning#92](https://github.com/nagyist/adapt-contrib-tutor/issues/92)
* Framework bumped to v5.22.8 ([8a17aae](8a17aae))
* Inline feedback normalisation across course and component config (fixes adaptlearning#87) (adaptlearning#88) ([f03b1ee](f03b1ee)), closes [adaptlearning#87](https://github.com/nagyist/adapt-contrib-tutor/issues/87) [adaptlearning#88](https://github.com/nagyist/adapt-contrib-tutor/issues/88)
* New style schema added. (adaptlearning#84) ([5be15e0](5be15e0)), closes [adaptlearning#84](https://github.com/nagyist/adapt-contrib-tutor/issues/84)
* Normalizing template icons ([cff3c07](cff3c07))
* replace deprecated a11y_attrs_heading usage (refs adaptlearning#67) (adaptlearning#76) ([f34b5fa](f34b5fa)), closes [adaptlearning#67](https://github.com/nagyist/adapt-contrib-tutor/issues/67) [adaptlearning#76](https://github.com/nagyist/adapt-contrib-tutor/issues/76)
* Stop _id property from directly rendering the _id view (adaptlearning#78) ([df1da66](df1da66)), closes [adaptlearning#78](https://github.com/nagyist/adapt-contrib-tutor/issues/78)
* Version numbers removed from Readme files ([7b6f5bd](7b6f5bd))

### New

* Issue and pr project addition automation (Fixes #3315) ([46f531d](46f531d)), closes [#3315](https://github.com/nagyist/adapt-contrib-tutor/issues/3315)
* Issue and pr project addition automation (refs adaptlearning/adapt_framework#3315) ([a666b69](a666b69))

### Update

* `"inline"` feedback restoration (adaptlearning#81) ([f5f35a2](f5f35a2)), closes [adaptlearning#81](https://github.com/nagyist/adapt-contrib-tutor/issues/81)
* Add accessible title (refs adaptlearning#74) (adaptlearning#75) ([bbe81f6](bbe81f6)), closes [adaptlearning#74](https://github.com/nagyist/adapt-contrib-tutor/issues/74) [adaptlearning#75](https://github.com/nagyist/adapt-contrib-tutor/issues/75)
* Switch to model.getFeedback allowing more complex feedback objects (adaptlearning#79) ([25fe47c](25fe47c)), closes [adaptlearning#79](https://github.com/nagyist/adapt-contrib-tutor/issues/79)

### Upgrade

* Bump yaml and semantic-release (adaptlearning#93) ([723a352](723a352)), closes [adaptlearning#93](https://github.com/nagyist/adapt-contrib-tutor/issues/93)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joe-replin joe-replin joe-replin approved these changes

@oliverfoster oliverfoster oliverfoster approved these changes

@cahirodoherty-learningpool cahirodoherty-learningpool Awaiting requested review from cahirodoherty-learningpool

Assignees

@chris-steele chris-steele

Labels
accessibility enhancement released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chris-steele @oliverfoster @joe-replin @cahirodoherty-learningpool