Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: _globals schema nesting #90

Merged
merged 1 commit into from
Mar 21, 2023
Merged

Fix: _globals schema nesting #90

merged 1 commit into from
Mar 21, 2023

Conversation

joe-allen-89
Copy link
Contributor

Fixes (#89)

Fix

@joe-allen-89 joe-allen-89 self-assigned this Mar 17, 2023
@joe-allen-89 joe-allen-89 linked an issue Mar 17, 2023 that may be closed by this pull request
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

Copy link
Contributor

@guywillis guywillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@joe-allen-89 joe-allen-89 merged commit c385e3c into master Mar 21, 2023
@joe-allen-89 joe-allen-89 deleted the issue/89 branch March 21, 2023 15:57
github-actions bot pushed a commit that referenced this pull request Mar 21, 2023
## [4.5.5](v4.5.4...v4.5.5) (2023-03-21)

### Fix

* _globals schema nesting (#90) ([c385e3c](c385e3c)), closes [#90](#90)
@github-actions
Copy link

🎉 This PR is included in version 4.5.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

github-actions bot pushed a commit to nagyist/adapt-contrib-tutor that referenced this pull request May 27, 2023
# [2.2.0](v2.1.2...v2.2.0) (2023-05-27)

### chore

* added package.json ([677347b](677347b))
* added package.json ([94afb62](94afb62)), closes [#3072](https://github.com/nagyist/adapt-contrib-tutor/issues/3072)

### Fix

* _globals schema nesting (adaptlearning#90) ([c385e3c](c385e3c)), closes [adaptlearning#90](https://github.com/nagyist/adapt-contrib-tutor/issues/90)
* Added gitignore for release automation (adaptlearning#77) ([bef3c93](bef3c93)), closes [adaptlearning#77](https://github.com/nagyist/adapt-contrib-tutor/issues/77)
* Added release automation (adaptlearning#73) ([c04b610](c04b610)), closes [adaptlearning#73](https://github.com/nagyist/adapt-contrib-tutor/issues/73)
* Bump http-cache-semantics from 4.1.0 to 4.1.1 (adaptlearning#82) ([076e8c5](076e8c5)), closes [adaptlearning#82](https://github.com/nagyist/adapt-contrib-tutor/issues/82)
* Check tutor type on page revisit before displaying inline feedback (fixes adaptlearning#91) (adaptlearning#92) ([e4f5761](e4f5761)), closes [adaptlearning#91](https://github.com/nagyist/adapt-contrib-tutor/issues/91) [adaptlearning#92](https://github.com/nagyist/adapt-contrib-tutor/issues/92)
* Framework bumped to v5.22.8 ([8a17aae](8a17aae))
* Inline feedback normalisation across course and component config (fixes adaptlearning#87) (adaptlearning#88) ([f03b1ee](f03b1ee)), closes [adaptlearning#87](https://github.com/nagyist/adapt-contrib-tutor/issues/87) [adaptlearning#88](https://github.com/nagyist/adapt-contrib-tutor/issues/88)
* New style schema added. (adaptlearning#84) ([5be15e0](5be15e0)), closes [adaptlearning#84](https://github.com/nagyist/adapt-contrib-tutor/issues/84)
* Normalizing template icons ([cff3c07](cff3c07))
* replace deprecated a11y_attrs_heading usage (refs adaptlearning#67) (adaptlearning#76) ([f34b5fa](f34b5fa)), closes [adaptlearning#67](https://github.com/nagyist/adapt-contrib-tutor/issues/67) [adaptlearning#76](https://github.com/nagyist/adapt-contrib-tutor/issues/76)
* Stop _id property from directly rendering the _id view (adaptlearning#78) ([df1da66](df1da66)), closes [adaptlearning#78](https://github.com/nagyist/adapt-contrib-tutor/issues/78)
* Version numbers removed from Readme files ([7b6f5bd](7b6f5bd))

### New

* Issue and pr project addition automation (Fixes #3315) ([46f531d](46f531d)), closes [#3315](https://github.com/nagyist/adapt-contrib-tutor/issues/3315)
* Issue and pr project addition automation (refs adaptlearning/adapt_framework#3315) ([a666b69](a666b69))

### Update

* `"inline"` feedback restoration (adaptlearning#81) ([f5f35a2](f5f35a2)), closes [adaptlearning#81](https://github.com/nagyist/adapt-contrib-tutor/issues/81)
* Add accessible title (refs adaptlearning#74) (adaptlearning#75) ([bbe81f6](bbe81f6)), closes [adaptlearning#74](https://github.com/nagyist/adapt-contrib-tutor/issues/74) [adaptlearning#75](https://github.com/nagyist/adapt-contrib-tutor/issues/75)
* Switch to model.getFeedback allowing more complex feedback objects (adaptlearning#79) ([25fe47c](25fe47c)), closes [adaptlearning#79](https://github.com/nagyist/adapt-contrib-tutor/issues/79)

### Upgrade

* Bump yaml and semantic-release (adaptlearning#93) ([723a352](723a352)), closes [adaptlearning#93](https://github.com/nagyist/adapt-contrib-tutor/issues/93)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix nesting on v1 schema _globals
4 participants