Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update: Add accessible title (refs #74) #75

Merged
merged 13 commits into from
Aug 17, 2022
Merged

Update: Add accessible title (refs #74) #75

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
05abbea
Provide accessible dialog heading if no title given
chris-steele Jul 27, 2022
2cf43e7
Update example.json
chris-steele Jul 27, 2022
90eeeac
Update properties.schema
chris-steele Jul 27, 2022
26358ca
Amend how to determine default alternative title
chris-steele Jul 27, 2022
4907d28
Merge branch 'issue/74' of https://github.com/adaptlearning/adapt-con…
chris-steele Jul 27, 2022
94a08ea
Update example.json
chris-steele Jul 28, 2022
3654d7d
Update TutorModel.js
chris-steele Jul 28, 2022
50739ae
Update properties.schema
chris-steele Jul 28, 2022
7450117
provide inline feedback with accessible heading
chris-steele Jul 28, 2022
808fa86
Merge branch 'issue/74' of https://github.com/adaptlearning/adapt-con…
chris-steele Jul 28, 2022
71eb3f2
Revert provide inline feedback with accessible heading
chris-steele Jul 28, 2022
8066fcd
provide inline feedback with accessible heading
chris-steele Jul 28, 2022
2ec0aad
Merge branch 'master' into issue/74
oliverfoster Aug 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions js/TutorModel.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ export default class TutorModel extends Backbone.Model {
_attributes: { 'data-adapt-id': parentModel.get('_id') },
_id: parentModel.get('_id'),
_shouldRenderId: false,
altTitle: parentModel.get('altFeedbackTitle'),
chris-steele marked this conversation as resolved.
Show resolved Hide resolved
title: parentModel.get('feedbackTitle'),
body: parentModel.get('feedbackMessage')
});
Expand Down
8 changes: 8 additions & 0 deletions templates/tutor.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,19 @@
<div class="tutor__content">
<div class="tutor__content-inner">

{{#if title}}
<div class="tutor__title">
<div class="tutor__title-inner" role="heading" aria-level="{{a11y_aria_level _id '@component+1' _ariaLevel }}">
{{{compile title}}}
</div>
</div>
{{else if altTitle}}
<div class="tutor__title aria-label">
<div class="tutor__title-inner" role="heading" aria-level="{{a11y_aria_level _id '@component+1' _ariaLevel }}">
{{{compile altTitle}}}
</div>
</div>
{{/if}}

<div class="tutor__body">
<div class="tutor__body-inner">
Expand Down