Begin conversion from FactoryGirl to FactoryBot

[djberg96]

As you may or may not know, the factory_girl gem was renamed to factory_bot at some point last year. I thought it prudent to update the gem so that any future upgrades will be seamless.

For this PR I have not done a global sub/replace. Instead, this is just a first step that will enable easy transition for both this repository and the other associated repositories. Towards that end I have added a simple constant alias for now, so none of the existing specs will break. The idea is that folks could update the name "organically" through other PR's over time. Once done, the alias can be removed.

Update: on second thought, maybe it's easier to gsub everything up front and force the issue.

[Fryguy]

@miq-bot assign @bdunne

[himdel]

I'm getting..

$ cd manageiq-ui-classic ; bundle exec rake spec
...
/home/himdel/manageiq/spec/support/missing_factory_helper.rb:33:in `<top (required)>': uninitialized constant FactoryGirl (NameError)
	from /home/himdel/manageiq-ui-classic/spec/manageiq/spec/spec_helper.rb:21:in `block in <top (required)>'
	from /home/himdel/manageiq-ui-classic/spec/manageiq/spec/spec_helper.rb:21:in `each'
	from /home/himdel/manageiq-ui-classic/spec/manageiq/spec/spec_helper.rb:21:in `<top (required)>'

Looks like the FactoryGirl = FactoryBot line needs to be somewhere rails autoloader will find.

If I echo "FactoryGirl = FactoryBot" > manageiq/lib/factory_girl.rb it starts passing fine (though I'm not sure that's the right location given this should be spec-only).

EDIT: manageiq/spec/support/factory_girl.rb also works (but not with _helper).

[djberg96]

@himdel, Does it go away if you change FactoryGirl to FactoryBot in spec/support/missing_factory_helper.rb?

[himdel]

@djberg96 Well, not really, there are many other files in spec/support mentioning FactoryGirl, and their load order is not defined.

EDIT: actually, it does seem to help sometimes at least. Either I'm testing something wrong, or this depends on file ordering in the filesystem or some phase-of-the-moon thing like that.

[bdunne]

I think we should gsub FactoryGirl to FactoryBot in this entire repo in the same PR to avoid conflicts

[djberg96]

@bdunne Alright, maybe that would be the better approach. Locally, even after I did that, it still caused problems for the provider repos, but they can catch up.

[miq-bot]

This pull request is not mergeable. Please rebase and repush.

[miq-bot]

Checked commits https://github.com/djberg96/manageiq/compare/8f00b6b274ad3a62d104bb78fc49361c9b8589fa~...b9da4050acce3920b78f956e9076bdf24113d5aa with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
576 files checked, 187 offenses detected

spec/factories/chargeback_rate_detail.rb

• ⚠️ - Line 14, Col 74 - Lint/UnneededSplatExpansion - Pass array contents as separate arguments.

spec/factories/small_environment.rb

• ❗ - Line 14, Col 10 - Layout/ExtraSpacing - Unnecessary spacing detected.

spec/lib/ems_event_helper_spec.rb

• ❗ - Line 106, Col 14 - Layout/ExtraSpacing - Unnecessary spacing detected.
• ❗ - Line 106, Col 19 - Layout/SpaceAroundOperators - Operator = should be surrounded by a single space.
• ❗ - Line 109, Col 22 - Layout/ExtraSpacing - Unnecessary spacing detected.
• ❗ - Line 109, Col 24 - Layout/SpaceAroundOperators - Operator = should be surrounded by a single space.

spec/lib/extensions/ar_virtual_spec.rb

• ❗ - Line 944, Col 26 - Layout/AlignParameters - Align the parameters of a method call if they span more than one line.
• ❗ - Line 947, Col 66 - Layout/AlignParameters - Align the parameters of a method definition if they span more than one line.

spec/lib/miq_preloader_spec.rb

• ❗ - Line 85, Col 31 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.

spec/lib/rbac/filterer_spec.rb

• ❗ - Line 1446, Col 11 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 1447, Col 11 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 151, Col 19 - Layout/ExtraSpacing - Unnecessary spacing detected.

spec/lib/rbac_spec.rb

• ❗ - Line 23, Col 26 - Layout/AlignParameters - Align the parameters of a method call if they span more than one line.
• ❗ - Line 24, Col 61 - Layout/AlignParameters - Align the parameters of a method definition if they span more than one line.
• ❗ - Line 46, Col 28 - Layout/AlignParameters - Align the parameters of a method call if they span more than one line.

spec/lib/services/resource_sharer_spec.rb

• ❗ - Line 97, Col 28 - Layout/AlignParameters - Align the parameters of a method call if they span more than one line.

spec/lib/tasks/evm_application_spec.rb

• ❗ - Line 133, Col 21 - Layout/ExtraSpacing - Unnecessary spacing detected.
• ❗ - Line 21, Col 21 - Layout/ExtraSpacing - Unnecessary spacing detected.
• ❗ - Line 65, Col 21 - Layout/ExtraSpacing - Unnecessary spacing detected.

spec/models/assigned_server_role_spec.rb

• ❗ - Line 84, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 85, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 88, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 89, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.

spec/models/chargeback_container_project_spec.rb

• ❗ - Line 13, Col 16 - Layout/SpaceInsideBlockBraces - Space missing inside {.

spec/models/container_deployment_spec.rb

• ❗ - Line 13, Col 64 - Layout/AlignParameters - Align the parameters of a method call if they span more than one line.
• ❗ - Line 18, Col 70 - Layout/AlignParameters - Align the parameters of a method call if they span more than one line.

spec/models/container_label_tag_mapping_spec.rb

• ⚠️ - Line 245, Col 7 - Lint/UselessAssignment - Useless assignment to variable - user_tag. Did you mean user_tag1?

spec/models/custom_attribute_spec.rb

• ❗ - Line 3, Col 95 - Style/DateTime - Prefer Date or Time over DateTime.

spec/models/dialog_field_tag_control_spec.rb

• ❗ - Line 110, Col 102 - Layout/ExtraSpacing - Unnecessary spacing detected.
• ❗ - Line 110, Col 126 - Layout/ExtraSpacing - Unnecessary spacing detected.
• ❗ - Line 115, Col 101 - Layout/ExtraSpacing - Unnecessary spacing detected.
• ❗ - Line 115, Col 77 - Layout/ExtraSpacing - Unnecessary spacing detected.

spec/models/dialog_field_text_box_spec.rb

• ❗ - Line 98, Col 63 - Layout/ExtraSpacing - Unnecessary spacing detected.
• ❗ - Line 98, Col 66 - Layout/SpaceAroundOperators - Operator => should be surrounded by a single space.
• ❗ - Line 98, Col 88 - Layout/ExtraSpacing - Unnecessary spacing detected.
• ❗ - Line 98, Col 92 - Layout/SpaceAroundOperators - Operator => should be surrounded by a single space.

spec/models/disk_spec.rb

• ❗ - Line 32, Col 76 - Style/NumericLiterals - Use underscores(_) as decimal mark and separate every 3 digits with them.

spec/models/drift_state/purging_spec.rb

• ❗ - Line 16, Col 120 - Rails/PluralizationGrammar - Prefer 1.day.
• ❗ - Line 17, Col 120 - Rails/PluralizationGrammar - Prefer 1.day.
• ❗ - Line 21, Col 120 - Rails/PluralizationGrammar - Prefer 1.day.
• ❗ - Line 22, Col 120 - Rails/PluralizationGrammar - Prefer 1.day.
• ❗ - Line 25, Col 122 - Rails/PluralizationGrammar - Prefer 1.day.

spec/models/ems_refresh/metadata_relats_spec.rb

• ❗ - Line 13, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 14, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.

spec/models/hardware_spec.rb

• ❗ - Line 135, Col 66 - Style/NumericLiterals - Use underscores(_) as decimal mark and separate every 3 digits with them.
• ❗ - Line 167, Col 66 - Style/NumericLiterals - Use underscores(_) as decimal mark and separate every 3 digits with them.

spec/models/host_spec.rb

• ❗ - Line 490, Col 26 - Layout/AlignParameters - Align the parameters of a method call if they span more than one line.
• ❗ - Line 514, Col 26 - Layout/AlignParameters - Align the parameters of a method call if they span more than one line.

spec/models/manageiq/providers/inventory/persister/helpers/spec_mocked_data.rb

• ❗ - Line 177, Col 5 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 184, Col 5 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 191, Col 5 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 198, Col 5 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 205, Col 5 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 212, Col 5 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 219, Col 5 - Naming/VariableNumber - Use normalcase for variable numbers.

spec/models/metric/processing_spec.rb

• ❗ - Line 127, Col 39 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 195, Col 39 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.

spec/models/metric/purging_spec.rb

• ❗ - Line 48, Col 101 - Rails/PluralizationGrammar - Prefer 1.day.
• ❗ - Line 49, Col 101 - Rails/PluralizationGrammar - Prefer 1.day.
• ❗ - Line 53, Col 101 - Rails/PluralizationGrammar - Prefer 1.day.
• ❗ - Line 54, Col 101 - Rails/PluralizationGrammar - Prefer 1.day.

spec/models/miq_action_spec.rb

• ❗ - Line 159, Col 10 - Layout/ExtraSpacing - Unnecessary spacing detected.
• ❗ - Line 159, Col 15 - Layout/SpaceAroundOperators - Operator = should be surrounded by a single space.
• ❗ - Line 90, Col 10 - Layout/ExtraSpacing - Unnecessary spacing detected.
• ❗ - Line 90, Col 13 - Layout/SpaceAroundOperators - Operator = should be surrounded by a single space.

spec/models/miq_alert_spec.rb

• ❗ - Line 325, Col 102 - Layout/ExtraSpacing - Unnecessary spacing detected.
• ❗ - Line 325, Col 126 - Layout/ExtraSpacing - Unnecessary spacing detected.

spec/models/miq_enterprise_spec.rb

• ❗ - Line 34, Col 11 - Layout/ExtraSpacing - Unnecessary spacing detected.
• ❗ - Line 34, Col 13 - Layout/SpaceAroundOperators - Operator = should be surrounded by a single space.
• ❗ - Line 38, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 41, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 48, Col 12 - Layout/SpaceAroundOperators - Operator = should be surrounded by a single space.
• ❗ - Line 48, Col 9 - Layout/ExtraSpacing - Unnecessary spacing detected.

spec/models/miq_group_spec.rb

• ❗ - Line 289, Col 28 - Layout/AlignParameters - Align the parameters of a method call if they span more than one line.

spec/models/miq_policy_spec.rb

• ❗ - Line 267, Col 32 - Layout/AlignParameters - Align the parameters of a method call if they span more than one line.
• ❗ - Line 268, Col 77 - Layout/AlignParameters - Align the parameters of a method definition if they span more than one line.

spec/models/miq_provision_request_spec.rb

• ❗ - Line 174, Col 38 - Layout/AlignParameters - Align the parameters of a method call if they span more than one line.

spec/models/miq_provision_request_template_spec.rb

• ❗ - Line 5, Col 24 - Layout/AlignParameters - Align the parameters of a method call if they span more than one line.

spec/models/miq_report_result/purging_spec.rb

• ❗ - Line 18, Col 95 - Rails/PluralizationGrammar - Prefer 1.day.
• ❗ - Line 19, Col 95 - Rails/PluralizationGrammar - Prefer 1.day.
• ❗ - Line 23, Col 95 - Rails/PluralizationGrammar - Prefer 1.day.
• ❗ - Line 24, Col 95 - Rails/PluralizationGrammar - Prefer 1.day.
• ❗ - Line 27, Col 97 - Rails/PluralizationGrammar - Prefer 1.day.

spec/models/miq_report_result_spec.rb

• ❗ - Line 32, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 33, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 34, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 40, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.

spec/models/miq_report_spec.rb

• ❗ - Line 323, Col 10 - Layout/ExtraSpacing - Unnecessary spacing detected.
• ❗ - Line 323, Col 12 - Layout/SpaceAroundOperators - Operator = should be surrounded by a single space.

spec/models/miq_request_spec.rb

• ❗ - Line 197, Col 144 - Rails/TimeZone - Do not use Time.now without zone. Use one of Time.zone.now, Time.current, Time.now.in_time_zone, Time.now.utc, Time.now.getlocal, Time.now.iso8601, Time.now.jisx0301, Time.now.rfc3339, Time.now.to_i, Time.now.to_f instead.

spec/models/miq_server/worker_monitor_spec.rb

• ❗ - Line 91, Col 63 - Layout/ExtraSpacing - Unnecessary spacing detected.

spec/models/miq_widget_set_spec.rb

• ❗ - Line 68, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.

spec/models/miq_widget_spec.rb

• ❗ - Line 407, Col 15 - Layout/ExtraSpacing - Unnecessary spacing detected.
• ❗ - Line 407, Col 17 - Layout/SpaceAroundOperators - Operator = should be surrounded by a single space.
• ❗ - Line 431, Col 16 - Layout/SpaceAroundOperators - Operator = should be surrounded by a single space.
• ❗ - Line 431, Col 17 - Layout/ExtraSpacing - Unnecessary spacing detected.
• ❗ - Line 444, Col 16 - Layout/SpaceAroundOperators - Operator = should be surrounded by a single space.
• ❗ - Line 444, Col 17 - Layout/ExtraSpacing - Unnecessary spacing detected.

spec/models/mixins/relationship_mixin_spec.rb

• ❗ - Line 868, Col 38 - Layout/AlignParameters - Align the parameters of a method call if they span more than one line.

spec/models/notification_spec.rb

• ❗ - Line 123, Col 43 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.

spec/models/partition_alignment_spec.rb

• ❗ - Line 7, Col 68 - Layout/ExtraSpacing - Unnecessary spacing detected.

spec/models/service_ansible_tower_spec.rb

• ❗ - Line 24, Col 24 - Layout/AlignParameters - Align the parameters of a method call if they span more than one line.

spec/models/service_template_provision_request_quota_spec.rb

• ❗ - Line 116, Col 36 - Layout/AlignParameters - Align the parameters of a method call if they span more than one line.

spec/models/service_template_provision_request_spec.rb

• ❗ - Line 10, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 7, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 8, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 9, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.

spec/models/service_template_transformation_plan_request_spec.rb

• ⚠️ - Line 100, Col 9 - Lint/UselessAssignment - Useless assignment to variable - conversion_host.
• ⚠️ - Line 136, Col 9 - Lint/UselessAssignment - Useless assignment to variable - conversion_host.
• ⚠️ - Line 64, Col 9 - Lint/UselessAssignment - Useless assignment to variable - conversion_host.

spec/models/service_template_transformation_plan_task_spec.rb

• ❗ - Line 19, Col 13 - Layout/ExtraSpacing - Unnecessary spacing detected.

spec/models/storage_spec.rb

• ❗ - Line 266, Col 17 - Layout/ExtraSpacing - Unnecessary spacing detected.
• ❗ - Line 266, Col 19 - Layout/SpaceAroundOperators - Operator = should be surrounded by a single space.
• ❗ - Line 278, Col 17 - Layout/ExtraSpacing - Unnecessary spacing detected.
• ❗ - Line 278, Col 19 - Layout/SpaceAroundOperators - Operator = should be surrounded by a single space.
• ❗ - Line 315, Col 17 - Layout/ExtraSpacing - Unnecessary spacing detected.
• ❗ - Line 315, Col 19 - Layout/SpaceAroundOperators - Operator = should be surrounded by a single space.
• ❗ - Line 417, Col 16 - Layout/SpaceAroundOperators - Operator = should be surrounded by a single space.
• ❗ - Line 417, Col 17 - Layout/ExtraSpacing - Unnecessary spacing detected.
• ❗ - Line 422, Col 26 - Layout/AlignParameters - Align the parameters of a method call if they span more than one line.
• ❗ - Line 472, Col 26 - Layout/AlignParameters - Align the parameters of a method call if they span more than one line.

spec/models/tenant_spec.rb

• ❗ - Line 435, Col 17 - Layout/ExtraSpacing - Unnecessary spacing detected.
• ❗ - Line 507, Col 17 - Layout/ExtraSpacing - Unnecessary spacing detected.

spec/models/user_spec.rb

• ❗ - Line 278, Col 15 - Layout/ExtraSpacing - Unnecessary spacing detected.
• ❗ - Line 278, Col 17 - Layout/SpaceAroundOperators - Operator = should be surrounded by a single space.

spec/models/vim_performance_analysis_spec.rb

• ❗ - Line 23, Col 24 - Layout/AlignParameters - Align the parameters of a method call if they span more than one line.

spec/models/vim_performance_state_spec.rb

• ❗ - Line 12, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 13, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 14, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 15, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.

spec/models/vm_or_template_spec.rb

• ⚠️ - Line 722, Col 7 - Lint/UselessAssignment - Useless assignment to variable - disk.
• ⚠️ - Line 739, Col 7 - Lint/UselessAssignment - Useless assignment to variable - vm. Did you mean vm2?
• ❗ - Line 127, Col 103 - Layout/SpaceAroundOperators - Operator => should be surrounded by a single space.
• ❗ - Line 127, Col 55 - Layout/ExtraSpacing - Unnecessary spacing detected.
• ❗ - Line 127, Col 86 - Layout/ExtraSpacing - Unnecessary spacing detected.
• ❗ - Line 127, Col 98 - Layout/ExtraSpacing - Unnecessary spacing detected.
• ❗ - Line 128, Col 36 - Layout/ExtraSpacing - Unnecessary spacing detected.
• ❗ - Line 128, Col 51 - Layout/ExtraSpacing - Unnecessary spacing detected.
• ❗ - Line 128, Col 58 - Layout/SpaceAroundOperators - Operator => should be surrounded by a single space.
• ❗ - Line 189, Col 36 - Layout/ExtraSpacing - Unnecessary spacing detected.
• ❗ - Line 189, Col 57 - Layout/SpaceAroundOperators - Operator => should be surrounded by a single space.
• ❗ - Line 206, Col 36 - Layout/ExtraSpacing - Unnecessary spacing detected.
• ❗ - Line 206, Col 50 - Layout/ExtraSpacing - Unnecessary spacing detected.
• ❗ - Line 206, Col 57 - Layout/SpaceAroundOperators - Operator => should be surrounded by a single space.
• ❗ - Line 224, Col 36 - Layout/ExtraSpacing - Unnecessary spacing detected.
• ❗ - Line 224, Col 50 - Layout/ExtraSpacing - Unnecessary spacing detected.
• ❗ - Line 224, Col 57 - Layout/SpaceAroundOperators - Operator => should be surrounded by a single space.
• ❗ - Line 240, Col 10 - Layout/ExtraSpacing - Unnecessary spacing detected.
• ❗ - Line 240, Col 17 - Layout/SpaceAroundOperators - Operator = should be surrounded by a single space.
• ❗ - Line 240, Col 18 - Layout/ExtraSpacing - Unnecessary spacing detected.
• ❗ - Line 535, Col 10 - Layout/SpaceAroundOperators - Operator = should be surrounded by a single space.
• ❗ - Line 535, Col 11 - Layout/ExtraSpacing - Unnecessary spacing detected.
• ❗ - Line 540, Col 10 - Layout/SpaceAroundOperators - Operator = should be surrounded by a single space.
• ❗ - Line 540, Col 11 - Layout/ExtraSpacing - Unnecessary spacing detected.
• ❗ - Line 547, Col 10 - Layout/SpaceAroundOperators - Operator = should be surrounded by a single space.
• ❗ - Line 547, Col 11 - Layout/ExtraSpacing - Unnecessary spacing detected.
• ❗ - Line 554, Col 10 - Layout/SpaceAroundOperators - Operator = should be surrounded by a single space.
• ❗ - Line 554, Col 11 - Layout/ExtraSpacing - Unnecessary spacing detected.

spec/models/vm_scan_spec.rb

• ❗ - Line 11, Col 79 - Layout/SpaceAroundOperators - Operator => should be surrounded by a single space.
• ❗ - Line 12, Col 80 - Layout/SpaceAroundOperators - Operator => should be surrounded by a single space.
• ❗ - Line 418, Col 79 - Layout/SpaceAroundOperators - Operator => should be surrounded by a single space.
• ❗ - Line 419, Col 80 - Layout/SpaceAroundOperators - Operator => should be surrounded by a single space.

spec/models/vmdb_database_spec.rb

• ❗ - Line 100, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 101, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 102, Col 122 - Style/NumericLiterals - Use underscores(_) as decimal mark and separate every 3 digits with them.
• ❗ - Line 88, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 89, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 90, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 91, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 92, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 93, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 94, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 96, Col 138 - Style/NumericLiterals - Use underscores(_) as decimal mark and separate every 3 digits with them.
• ❗ - Line 96, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 97, Col 138 - Style/NumericLiterals - Use underscores(_) as decimal mark and separate every 3 digits with them.
• ❗ - Line 97, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 98, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 99, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.

spec/models/vmdb_index_spec.rb

• ❗ - Line 94, Col 88 - Layout/ExtraSpacing - Unnecessary spacing detected.

spec/models/vmdb_table_evm_spec.rb

• ❗ - Line 190, Col 88 - Layout/ExtraSpacing - Unnecessary spacing detected.

spec/models/zone_spec.rb

• ❗ - Line 178, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 68, Col 83 - Layout/SpaceInsideBlockBraces - Space missing inside }.
• ❗ - Line 83, Col 83 - Layout/SpaceInsideBlockBraces - Space missing inside }.

spec/support/quota_helper.rb

• ❗ - Line 122, Col 28 - Layout/AlignParameters - Align the parameters of a method call if they span more than one line.
• ❗ - Line 159, Col 35 - Layout/AlignParameters - Align the parameters of a method call if they span more than one line.

spec/tools/copy_reports_structure_spec.rb

• ❗ - Line 8, Col 13 - Layout/ExtraSpacing - Unnecessary spacing detected.
• ❗ - Line 9, Col 23 - Layout/ExtraSpacing - Unnecessary spacing detected.

[himdel]

The UI specs are passing for me locally now, thanks! 👍

[himdel]

Will this be backported to hammer?

If not, we should probably add FactoryBot = FactoryGirl to hammer (and gaprindashvili?) to ease backporting..

[bdunne]

@djberg96 Can you retest with the provider repos you had failures on earlier?

[djberg96]

@bdunne I ran it normally and with 3 of the providers locally (Google, Amazon and Azure). All passed.

[djberg96]

@bdunne Want me to try to cleanup these rubocop warnings, too?

[bdunne]

@djberg96 Would you mind creating a PR to hammer that only aliases FactoryBot to FactoryGirl? That would make backports much easier for @simaishi and the rest of the team.