Change FactoryGirl to FactoryBot #505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_label dependencies |
|
@miq-bot add_label hammer/no |
|
@djberg96 unrecognized command 'add', ignoring... Accepted commands are: add_label, add_reviewer, assign, close_issue, move_issue, remove_label, rm_label, set_milestone |
|
@miq-bot add_label gaprindashvili/no |
|
Checked commit https://github.com/djberg96/manageiq-providers-amazon/commit/343f1007d6a38c97a629b5bb89bd4d46e0eb559b with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 spec/models/authenticator/amazon_spec.rb
spec/models/manageiq/providers/amazon/cloud_manager/provision_spec.rb
|
agrare
approved these changes
Dec 13, 2018
agrare
added a commit
that referenced
this pull request
Dec 13, 2018
Change FactoryGirl to FactoryBot
26 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a followup to ManageIQ/manageiq#18279 where we're updating FactoryGirl to FactoryBot.