Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change FactoryGirl to FactoryBot #150

Merged
merged 1 commit into from
Dec 21, 2018
Merged

Change FactoryGirl to FactoryBot #150

merged 1 commit into from
Dec 21, 2018

Conversation

djberg96
Copy link

This PR is a followup to ManageIQ/manageiq#18279 where we're updating FactoryGirl to FactoryBot.

@miq-bot
Copy link
Member

miq-bot commented Dec 21, 2018

Checked commit https://github.com/djberg96/manageiq-consumption/commit/2228a39dd7e7913347058e6cd2ccd06148115416 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
20 files checked, 5 offenses detected

spec/models/data_rollup_spec.rb

spec/models/manager_spec.rb

spec/spec_helper.rb

@Fryguy Fryguy merged commit b095e88 into ManageIQ:master Dec 21, 2018
@Fryguy Fryguy added this to the Sprint 102 Ending Jan 7, 2019 milestone Dec 21, 2018
@Fryguy Fryguy self-assigned this Dec 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants