Change FactoryGirl to FactoryBot

[djberg96]

This PR is a followup to ManageIQ/manageiq#18279 where we're updating FactoryGirl to FactoryBot.

[djberg96]

@miq-bot add_labels dependencies, hammer/no, gaprindashvili/no

[miq-bot]

This pull request is not mergeable. Please rebase and repush.

[miq-bot]

Checked commits https://github.com/djberg96/manageiq-api/compare/bd6cfa4951fcb358c622ab0704ad33d35cff3ce3~...f26e2038f0adbabec681282b9f65a8ddcdb4417f with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
101 files checked, 90 offenses detected

spec/requests/automate_spec.rb

• ❗ - Line 11, Col 49 - Layout/SpaceAroundOperators - Operator => should be surrounded by a single space.

spec/requests/categories_spec.rb

• ❗ - Line 16, Col 5 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 17, Col 5 - Naming/VariableNumber - Use normalcase for variable numbers.

spec/requests/conditions_spec.rb

• ❗ - Line 182, Col 17 - Layout/ExtraSpacing - Unnecessary spacing detected.

spec/requests/events_spec.rb

• ❗ - Line 59, Col 17 - Layout/ExtraSpacing - Unnecessary spacing detected.

spec/requests/orchestration_templates_spec.rb

• ❗ - Line 237, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.

spec/requests/policy_actions_spec.rb

• ❗ - Line 76, Col 17 - Layout/ExtraSpacing - Unnecessary spacing detected.

spec/requests/querying_spec.rb

• ❗ - Line 542, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 543, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 544, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 545, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 554, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 555, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 556, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 566, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 567, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 568, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 578, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 579, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 580, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 590, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 591, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 592, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 602, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 603, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 604, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 653, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 654, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.

spec/requests/reports_spec.rb

• ❗ - Line 146, Col 5 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 147, Col 5 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 211, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 212, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 3, Col 5 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 4, Col 5 - Naming/VariableNumber - Use normalcase for variable numbers.

spec/requests/requests_spec.rb

• ❗ - Line 76, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 80, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.

spec/requests/service_orders_spec.rb

• ❗ - Line 162, Col 5 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 163, Col 5 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 202, Col 5 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 203, Col 5 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 292, Col 29 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 292, Col 9 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 356, Col 28 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 356, Col 9 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 397, Col 28 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 397, Col 9 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 438, Col 28 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 438, Col 9 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 476, Col 28 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 476, Col 9 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 541, Col 29 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 541, Col 9 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 579, Col 28 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 579, Col 9 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 603, Col 28 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 603, Col 9 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 618, Col 28 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 618, Col 9 - Naming/VariableNumber - Use normalcase for variable numbers.

spec/requests/service_requests_spec.rb

• ❗ - Line 238, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 242, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 306, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 369, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.

spec/requests/services_spec.rb

• ❗ - Line 603, Col 20 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 603, Col 9 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 653, Col 20 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 653, Col 9 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 703, Col 20 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 703, Col 9 - Naming/VariableNumber - Use normalcase for variable numbers.

spec/requests/tag_collections_spec.rb

• ❗ - Line 416, Col 13 - Layout/ExtraSpacing - Unnecessary spacing detected.
• ❗ - Line 566, Col 18 - Layout/ExtraSpacing - Unnecessary spacing detected.

spec/requests/tenant_quotas_spec.rb

• ❗ - Line 143, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 144, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 201, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 202, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 243, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 244, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 8, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 90, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 91, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 9, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.

spec/requests/tenants_spec.rb

• ❗ - Line 124, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 129, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 169, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 170, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 232, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 237, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 272, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 273, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 6, Col 5 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 7, Col 5 - Naming/VariableNumber - Use normalcase for variable numbers.

[djberg96]

@miq-bot remove_label unmergeable