Backport? (copy) the applicable parts of "New Tower credential types" #15598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdunne
force-pushed
the
manageiq-providers-ansible_tower_PR_9
branch
from
a20b628
to
85806d6
Compare
|
@jameswnl They should be two PR's since they're unrelated |
bdunne
force-pushed
the
manageiq-providers-ansible_tower_PR_9
branch
from
85806d6
to
950e16d
Compare
|
Checked commit bdunne@950e16d with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@miq-bot add_labels fine/yes |
|
Backported to Fine via #15780 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ManageIQ/manageiq-providers-ansible_tower#9
This was revealed by a test failure on the Network Credential in #15594 and took forever to debug.
I don't know what else may be missing, but that should be it for ManageIQ/manageiq-providers-ansible_tower#9
This is yet another reason to merge #15594 since the part that is tested would have been exposed much earlier on.
cc @carbonin @Fryguy @jrafanie