-
Notifications
You must be signed in to change notification settings - Fork 896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FINE] Porting newly supported Tower credential types to Fine #15780
Conversation
@miq-bot add_label wip |
@miq-bot remove_label wip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jameswnl Its realistically impossible to confirm that +13,656 −3,439
worth of changes is the same as in master
Can you try to at do these one PR at a time even if not cherry-picked?
I was glancing at all PRs listed in the description and had a quick look if they are included in here. So at least I tried to check :) But I'm with @agrare that it's not really 100% sure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@agrare as said in my previous comment, I looked at all individual commits and glanced over the corresponding PRs - so I'm 👍 with this PR as is
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
ping @simaishi
Since this isn't a blocker, I'll get this in later when we start working on the next release. |
@jameswnl prepare for more rebasing 😆 |
Some comments on commits jameswnl/manageiq@4305c94~...95767b1 lib/tasks_private/spec_helper.rake
|
Checked commits jameswnl/manageiq@4305c94~...95767b1 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 app/models/manageiq/providers/ansible_tower/shared/automation_manager/azure_credential.rb
app/models/manageiq/providers/ansible_tower/shared/automation_manager/google_credential.rb
app/models/manageiq/providers/ansible_tower/shared/automation_manager/network_credential.rb
app/models/manageiq/providers/ansible_tower/shared/automation_manager/openstack_credential.rb
app/models/manageiq/providers/ansible_tower/shared/automation_manager/rackspace_credential.rb
app/models/manageiq/providers/ansible_tower/shared/automation_manager/satellite6_credential.rb
app/models/manageiq/providers/ansible_tower/shared/inventory/parser/automation_manager.rb
lib/tasks_private/spec_helper.rake
spec/lib/miq_automation_engine/service_models/miq_ae_service_manageiq-providers-ansible_tower-automation_manager-azure_classic_credential_spec.rb
|
Travis errors are the ones fixed by #16531, if you close/open it should pass. |
Backporting via cherrypick proved to be complicated with too many conflicts. Instead this PR is created to port the feature to
Fine
and that effectively contains the followingThe following are original PRs for masters (manageiq repo and manageiq-provider-ansible_tower repo) and their corresponding commits in this PR.
The following 2 PRs are 1-liners that are included in the commits.