Support more Tower credential types #15558
Conversation
| @@ -113,7 +117,7 @@ def image_path(path, options = {}) | |||
| end | |||
|
|
|||
| VCR.configure do |c| | |||
| c.cassette_library_dir = Rails.root.join('spec/vcr_cassettes') | |||
| c.cassette_library_dir = File.join(external_tower_gem_dir, 'spec/vcr_cassettes') | |||
There was a problem hiding this comment.
@durandom @Fryguy This is the part I am not sure about.
This is pulling in only cassettes from the external tower repo's. Haven't been able to find ways to make vcr load from multiple cassettes paths because cassette_library_dir can be only 1. Need some advice here.
Good thing is: currently it's ok because manageiq specs don't use any other cassettes. And once we split the embedded code, it would be even less to worry about.
There was a problem hiding this comment.
another reason why the specs shouldnt rely on an external gem.
maybe you can wrap the it_behaves_like block with a VCR block? Not sure if thats possible and supported though, something like
VCR.with_cassette_library_dir('..') do
it_behaves_like '...'
end
There was a problem hiding this comment.
I like my solution better... https://github.com/ManageIQ/manageiq/pull/15594/files#diff-88d3c9989ff613ced10a9fe635834148R2
This change breaks everything else that uses VCR in ManageIQ
There was a problem hiding this comment.
Yes 👍
I was looking for answer like yours. Will incorporate.
|
@miq-bot add_labels enhancement, fine/yes |
| @@ -32,6 +32,10 @@ def image_path(path, options = {}) | |||
| # include the manageiq-gems-pending matchers | |||
| Dir[ManageIQ::Gems::Pending.root.join("spec/support/custom_matchers/*.rb")].each { |f| require f } | |||
|
|
|||
| # For embedded ansible to use external ansible tower's specs | |||
| external_tower_gem_dir = Gem::Specification.find_by_name("manageiq-providers-ansible_tower").gem_dir | |||
| Dir[File.join(external_tower_gem_dir, 'spec/support/**/*.rb')].each { |f| require f } | |||
There was a problem hiding this comment.
somehow it feels wrong to include shared examples from an external gem.
There was a problem hiding this comment.
@Fryguy @blomquisg how about moving the embedded ansible specs and code to the tower provider gem? I mean for the foreseeable future embedded will be very much like a tower provider
There was a problem hiding this comment.
yeah, probably a better compromise and much easier to maintain.
| @@ -113,7 +117,7 @@ def image_path(path, options = {}) | |||
| end | |||
|
|
|||
| VCR.configure do |c| | |||
| c.cassette_library_dir = Rails.root.join('spec/vcr_cassettes') | |||
| c.cassette_library_dir = File.join(external_tower_gem_dir, 'spec/vcr_cassettes') | |||
There was a problem hiding this comment.
another reason why the specs shouldnt rely on an external gem.
maybe you can wrap the it_behaves_like block with a VCR block? Not sure if thats possible and supported though, something like
VCR.with_cassette_library_dir('..') do
it_behaves_like '...'
end
|
This pull request is not mergeable. Please rebase and repush. |
|
Checked commits jameswnl/manageiq@8914aaf~...8fe5587 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 spec/spec_helper.rb
|
|
I merged the various "fixes" in the separate PR #15598 since they are unrelated this PR. |
|
This pull request is not mergeable. Please rebase and repush. |
Get the other Tower supported credential types into
Embedded_ansibleas well.Plus using the shared examples and cassettes from
manageiq-providers-ansible-towrand removing the duplicated set inmanageiq