Use shared tests from manageiq-providers-ansible_tower #15594
Conversation
|
Test failures are fixed by #15598 |
|
Embedded Ansible is the core team’s concern, not the Ansible Tower team's concern, so I am 👎 on merging the two. However, I feel the cassettes and shared examples should definitely live in the Tower repo. Embedded depends on Tower, not the other way around. |
spec/spec_helper.rb
Outdated
| @@ -31,6 +31,9 @@ def image_path(path, options = {}) | |||
| Dir[Rails.root.join("spec/shared/**/*.rb")].each { |f| require f } | |||
| # include the manageiq-gems-pending matchers | |||
| Dir[ManageIQ::Gems::Pending.root.join("spec/support/custom_matchers/*.rb")].each { |f| require f } | |||
| Vmdb::Plugins.instance.vmdb_plugins.each do |plugin| | |||
| Dir[plugin.root.join("spec/support/**/*.rb")].each { |f| require f } | |||
| end | |||
There was a problem hiding this comment.
I don't like this. The core shouldn't load all of the plugin's support dirs because we don't run their tests, except in the specific case of the shared examples for Tower.
|
|
||
| after do | ||
| VCR.configure { |c| c.cassette_library_dir = @old_library } | ||
| end |
There was a problem hiding this comment.
I think you can pass the cassette_dir as part of the use_cassette call, and then you don't need the before/after dance.
Remove duplicate VCR cassettes for ansible tower
| # To be extracted with embedded_ansible | ||
| require ManageIQ::Providers::AnsibleTower::Engine.root.join("spec/support/vcr_helper.rb").to_s | ||
| Dir[ManageIQ::Providers::AnsibleTower::Engine.root.join("spec/support/ansible_shared/**/*.rb")].each { |f| require f } | ||
|
|
There was a problem hiding this comment.
I am 👍 for this as it's a very prescriptive change, and is clearly labeled to be moved when embedded_ansible is extracted.
bdunne
changed the title
|
Checked commits bdunne/manageiq@9efea43~...8fea1b3 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
Depends on #15598
The spec files in ManageIQ can conflict and aren't updated as they are in the provider repo.
Based on ManageIQ/manageiq-providers-ansible_tower#10 and #15593